diff mbox series

Documentation: mtd: spinand: macronix: Add support for serial NAND flash

Message ID 20240603073953.16399-1-linchengming884@gmail.com
State New
Headers show
Series Documentation: mtd: spinand: macronix: Add support for serial NAND flash | expand

Commit Message

Cheng Ming Lin June 3, 2024, 7:39 a.m. UTC 
From: Cheng Ming Lin <chengminglin@mxic.com.tw>

MX35UF{1,2,4}GE4AD and MX35UF{1,2}GE4AC have been merge into 
Linux kernel mainline. 
Commit ID: "c374839f9b4475173e536d1eaddff45cb481dbdf".

For SPI-NAND flash support on Linux kernel LTS v5.4.y,
add SPI-NAND flash MX35UF{1,2,4}GE4AD and MX35UF{1,2}GE4AC in id tables.

Those five flashes have been validate on Xilinx zynq-picozed board and
Linux kernel LTS v5.4.y.

Signed-off-by: Cheng Ming Lin <chengminglin@mxic.com.tw>
---
 drivers/mtd/nand/spi/macronix.c | 45 +++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

Comments

Greg Kroah-Hartman June 3, 2024, 7:58 a.m. UTC | #1 
On Mon, Jun 03, 2024 at 03:39:53PM +0800, Cheng Ming Lin wrote:
> From: Cheng Ming Lin <chengminglin@mxic.com.tw>
> 
> MX35UF{1,2,4}GE4AD and MX35UF{1,2}GE4AC have been merge into 
> Linux kernel mainline. 

Trailing whitespace :(

> Commit ID: "c374839f9b4475173e536d1eaddff45cb481dbdf".

See the kernel documentation for how to properly reference commits in
changelog messages.

> For SPI-NAND flash support on Linux kernel LTS v5.4.y,
> add SPI-NAND flash MX35UF{1,2,4}GE4AD and MX35UF{1,2}GE4AC in id tables.
> 
> Those five flashes have been validate on Xilinx zynq-picozed board and
> Linux kernel LTS v5.4.y.

What does 5.4.y have to do with the latest mainline tree?  Is this
tested on our latest tree?

thanks,

greg k-h
Miquel Raynal June 3, 2024, 1:18 p.m. UTC | #2 
Hi,

gregkh@linuxfoundation.org wrote on Mon, 3 Jun 2024 09:58:23 +0200:

> On Mon, Jun 03, 2024 at 03:39:53PM +0800, Cheng Ming Lin wrote:
> > From: Cheng Ming Lin <chengminglin@mxic.com.tw>

The title prefix contains "Documentation: ", but I don't see anything
related in the diff.

> > 
> > MX35UF{1,2,4}GE4AD and MX35UF{1,2}GE4AC have been merge into 
> > Linux kernel mainline.   
> 
> Trailing whitespace :(
> 
> > Commit ID: "c374839f9b4475173e536d1eaddff45cb481dbdf".  
> 
> See the kernel documentation for how to properly reference commits in
> changelog messages.
> 
> > For SPI-NAND flash support on Linux kernel LTS v5.4.y,
> > add SPI-NAND flash MX35UF{1,2,4}GE4AD and MX35UF{1,2}GE4AC in id tables.
> > 
> > Those five flashes have been validate on Xilinx zynq-picozed board and
> > Linux kernel LTS v5.4.y.  
> 
> What does 5.4.y have to do with the latest mainline tree?  Is this
> tested on our latest tree?
> 
> thanks,
> 
> greg k-h


Thanks,
Miquèl
Cheng Ming Lin June 4, 2024, 1:44 a.m. UTC | #3 
Hello,

Greg KH <gregkh@linuxfoundation.org> 於 2024年6月3日 週一 下午3:58寫道：
>
> On Mon, Jun 03, 2024 at 03:39:53PM +0800, Cheng Ming Lin wrote:
> > From: Cheng Ming Lin <chengminglin@mxic.com.tw>
> >
> > MX35UF{1,2,4}GE4AD and MX35UF{1,2}GE4AC have been merge into
> > Linux kernel mainline.
>
> Trailing whitespace :(

Sorry, we will fix it in the next version.

>
> > Commit ID: "c374839f9b4475173e536d1eaddff45cb481dbdf".
>
> See the kernel documentation for how to properly reference commits in
> changelog messages.

Sure, this will also be fixed in the next version.

>
> > For SPI-NAND flash support on Linux kernel LTS v5.4.y,
> > add SPI-NAND flash MX35UF{1,2,4}GE4AD and MX35UF{1,2}GE4AC in id tables.
> >
> > Those five flashes have been validate on Xilinx zynq-picozed board and
> > Linux kernel LTS v5.4.y.
>
> What does 5.4.y have to do with the latest mainline tree?  Is this
> tested on our latest tree?

We have requirements specific to the 5.4.y, and these five flashes
have been adapted for the latest mainline tree.
Additionally, they have been patched on LTS 5.14.y, and we have
tested them on LTS 5.4.y.
Given these circumstances, we are hopeful for approval to backport
these five flash IDs on 5.4.y.

>
> thanks,
>
> greg k-h

Regards,
Cheng Ming
Cheng Ming Lin June 4, 2024, 1:49 a.m. UTC | #4 
Hello,

Miquel Raynal <miquel.raynal@bootlin.com> 於 2024年6月3日 週一 下午9:19寫道：
>
> Hi,
>
> gregkh@linuxfoundation.org wrote on Mon, 3 Jun 2024 09:58:23 +0200:
>
> > On Mon, Jun 03, 2024 at 03:39:53PM +0800, Cheng Ming Lin wrote:
> > > From: Cheng Ming Lin <chengminglin@mxic.com.tw>
>
> The title prefix contains "Documentation: ", but I don't see anything
> related in the diff.
>

It seems there was an oversight with the title prefix
"Documentation: "; we inadvertently included it.
We'll make sure to correct this issue.

> > >
> > > MX35UF{1,2,4}GE4AD and MX35UF{1,2}GE4AC have been merge into
> > > Linux kernel mainline.
> >
> > Trailing whitespace :(
> >
> > > Commit ID: "c374839f9b4475173e536d1eaddff45cb481dbdf".
> >
> > See the kernel documentation for how to properly reference commits in
> > changelog messages.
> >
> > > For SPI-NAND flash support on Linux kernel LTS v5.4.y,
> > > add SPI-NAND flash MX35UF{1,2,4}GE4AD and MX35UF{1,2}GE4AC in id tables.
> > >
> > > Those five flashes have been validate on Xilinx zynq-picozed board and
> > > Linux kernel LTS v5.4.y.
> >
> > What does 5.4.y have to do with the latest mainline tree?  Is this
> > tested on our latest tree?
> >
> > thanks,
> >
> > greg k-h
>
>
> Thanks,
> Miquèl

Regards,
Cheng Ming
Greg Kroah-Hartman June 4, 2024, 4:23 a.m. UTC | #5 
On Tue, Jun 04, 2024 at 09:44:01AM +0800, Cheng Ming Lin wrote:
> Hello,
> 
> Greg KH <gregkh@linuxfoundation.org> 於 2024年6月3日 週一 下午3:58寫道：
> >
> > On Mon, Jun 03, 2024 at 03:39:53PM +0800, Cheng Ming Lin wrote:
> > > From: Cheng Ming Lin <chengminglin@mxic.com.tw>
> > >
> > > MX35UF{1,2,4}GE4AD and MX35UF{1,2}GE4AC have been merge into
> > > Linux kernel mainline.
> >
> > Trailing whitespace :(
> 
> Sorry, we will fix it in the next version.
> 
> >
> > > Commit ID: "c374839f9b4475173e536d1eaddff45cb481dbdf".
> >
> > See the kernel documentation for how to properly reference commits in
> > changelog messages.
> 
> Sure, this will also be fixed in the next version.
> 
> >
> > > For SPI-NAND flash support on Linux kernel LTS v5.4.y,
> > > add SPI-NAND flash MX35UF{1,2,4}GE4AD and MX35UF{1,2}GE4AC in id tables.
> > >
> > > Those five flashes have been validate on Xilinx zynq-picozed board and
> > > Linux kernel LTS v5.4.y.
> >
> > What does 5.4.y have to do with the latest mainline tree?  Is this
> > tested on our latest tree?
> 
> We have requirements specific to the 5.4.y, and these five flashes
> have been adapted for the latest mainline tree.
> Additionally, they have been patched on LTS 5.14.y, and we have
> tested them on LTS 5.4.y.
> Given these circumstances, we are hopeful for approval to backport
> these five flash IDs on 5.4.y.

If this is a backport, please just follow the documentation for the
stable kernel for how to properly get a patch backported.

thanks,

greg k-h
diff mbox series

Patch

diff --git a/drivers/mtd/nand/spi/macronix.c b/drivers/mtd/nand/spi/macronix.c
index f18c6cfe8ff5..e1446798bfb3 100644
--- a/drivers/mtd/nand/spi/macronix.c
+++ b/drivers/mtd/nand/spi/macronix.c
@@ -132,6 +132,51 @@  static const struct spinand_info macronix_spinand_table[] = {
 					      &update_cache_variants),
 		     SPINAND_HAS_QE_BIT,
 		     SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, NULL)),
+	SPINAND_INFO("MX35UF4GE4AD", 0xb7,
+		     NAND_MEMORG(1, 4096, 256, 64, 2048, 40, 1, 1, 1),
+		     NAND_ECCREQ(8, 512),
+		     SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
+					      &write_cache_variants,
+					      &update_cache_variants),
+		     SPINAND_HAS_QE_BIT,
+		     SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
+				     mx35lf1ge4ab_ecc_get_status)),
+	SPINAND_INFO("MX35UF2GE4AD", 0xa6,
+		     NAND_MEMORG(1, 2048, 128, 64, 2048, 40, 1, 1, 1),
+		     NAND_ECCREQ(8, 512),
+		     SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
+					      &write_cache_variants,
+					      &update_cache_variants),
+		     SPINAND_HAS_QE_BIT,
+		     SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
+				     mx35lf1ge4ab_ecc_get_status)),
+	SPINAND_INFO("MX35UF2GE4AC", 0xa2,
+		     NAND_MEMORG(1, 2048, 64, 64, 2048, 40, 1, 1, 1),
+		     NAND_ECCREQ(4, 512),
+		     SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
+					      &write_cache_variants,
+					      &update_cache_variants),
+		     SPINAND_HAS_QE_BIT,
+		     SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
+				     mx35lf1ge4ab_ecc_get_status)),
+	SPINAND_INFO("MX35UF1GE4AD", 0x96,
+		     NAND_MEMORG(1, 2048, 128, 64, 1024, 20, 1, 1, 1),
+		     NAND_ECCREQ(8, 512),
+		     SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
+					      &write_cache_variants,
+					      &update_cache_variants),
+		     SPINAND_HAS_QE_BIT,
+		     SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
+				     mx35lf1ge4ab_ecc_get_status)),
+	SPINAND_INFO("MX35UF1GE4AC", 0x92,
+		     NAND_MEMORG(1, 2048, 64, 64, 1024, 20, 1, 1, 1),
+		     NAND_ECCREQ(4, 512),
+		     SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
+					      &write_cache_variants,
+					      &update_cache_variants),
+		     SPINAND_HAS_QE_BIT,
+		     SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
+				     mx35lf1ge4ab_ecc_get_status)),
 };
 
 static int macronix_spinand_detect(struct spinand_device *spinand)