| Message ID | 20231221090702.103027-8-jaimeliao.tw@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Ambarus Tudor |
| Headers | show |
| Series | Add octal DTR support for Macronix flash | expand |
> + }, { > + .id = SNOR_ID(0xc2, 0x83, 0x39), > + }, { > + .id = SNOR_ID(0xc2, 0x80, 0x39), > + }, { > + .id = SNOR_ID(0xc2, 0x85, 0x39), > + }, { > + .id = SNOR_ID(0xc2, 0x80, 0x3a), > + }, { > + .id = SNOR_ID(0xc2, 0x85, 0x3a), > + }, { > + .id = SNOR_ID(0xc2, 0x80, 0x3b), > + }, { > + .id = SNOR_ID(0xc2, 0x85, 0x3b), Should just be: /* We need the manufacturer fixups. Keep this last. */ { .id = SNOR_ID(0xc2) } -michael
Hi Michael > > > + }, { > > + .id = SNOR_ID(0xc2, 0x83, 0x39), > > + }, { > > + .id = SNOR_ID(0xc2, 0x80, 0x39), > > + }, { > > + .id = SNOR_ID(0xc2, 0x85, 0x39), > > + }, { > > + .id = SNOR_ID(0xc2, 0x80, 0x3a), > > + }, { > > + .id = SNOR_ID(0xc2, 0x85, 0x3a), > > + }, { > > + .id = SNOR_ID(0xc2, 0x80, 0x3b), > > + }, { > > + .id = SNOR_ID(0xc2, 0x85, 0x3b), > > Should just be: > > /* We need the manufacturer fixups. Keep this last. */ > { .id = SNOR_ID(0xc2) } Do you mean I could add this in the last? Or I need to abandon above ID list? Sound good. > > -michael Thanks Jaime
same comments as in previous patch
diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c index 29bd5f0b32ec..04d4ed6c1245 100644 --- a/drivers/mtd/spi-nor/macronix.c +++ b/drivers/mtd/spi-nor/macronix.c @@ -252,6 +252,20 @@ static const struct flash_info macronix_nor_parts[] = { .id = SNOR_ID(0xc2, 0x94, 0x3c), .n_banks = 4, .flags = SPI_NOR_RWW, + }, { + .id = SNOR_ID(0xc2, 0x83, 0x39), + }, { + .id = SNOR_ID(0xc2, 0x80, 0x39), + }, { + .id = SNOR_ID(0xc2, 0x85, 0x39), + }, { + .id = SNOR_ID(0xc2, 0x80, 0x3a), + }, { + .id = SNOR_ID(0xc2, 0x85, 0x3a), + }, { + .id = SNOR_ID(0xc2, 0x80, 0x3b), + }, { + .id = SNOR_ID(0xc2, 0x85, 0x3b), } };