From patchwork Sun Oct 8 20:01:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1844946 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=XAtVfU5F; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4S3Y432yxQz20cr for ; Mon, 9 Oct 2023 07:02:43 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qBv6C73i54TMU8A4hnG1g/ATrjOSPf2nebtOdDVI33w=; b=XAtVfU5FaKliOL yrYnHr5k8+XbMRugn6P+kxqmG9oXMUR768ppP7sBak3iSkmPXzTEdiwCtWG7dQVCnnwa7fjq9ZRiR /V31L3sAceXlmubUs4p7mJ4zZwV1AZFti2+evahZKR0OmSrCcdMI1wd/p01R2AyDvJ+RNpXNfyo3c +oIEsrnuxHnEd5TjUCRBiUMDykc6pMxiZ0yIIZxBui1yaSq+R07W7hfPoway4PJpM/fFExXGUqm/+ 7PoNIeB9Xp8Dwr4R1FTaezLKH1+NUbbRl2XQ1ZswZqtzfdja08TGxeAN/s/U/TBIhjYQvGwWrxtpm zAIe9YiB4lEylXY5LRkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qpZyh-009Dzn-1x; Sun, 08 Oct 2023 20:02:15 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qpZyW-009DrD-1j for linux-mtd@lists.infradead.org; Sun, 08 Oct 2023 20:02:09 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qpZyR-0001i5-Ar; Sun, 08 Oct 2023 22:01:59 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qpZyQ-000F0C-KT; Sun, 08 Oct 2023 22:01:58 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qpZyQ-00Bf1A-BJ; Sun, 08 Oct 2023 22:01:58 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra Cc: linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 18/20] mtd: rawnand: txx9ndfmc: Convert to platform remove callback returning void Date: Sun, 8 Oct 2023 22:01:41 +0200 Message-Id: <20231008200143.196369-19-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231008200143.196369-1-u.kleine-koenig@pengutronix.de> References: <20231008200143.196369-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1919; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=3YydtaRiKRjnB5+u2dYxhI3rACGp6Jp3hUAaOKD2+TA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlIwqbKrMFG1XMpWFGArZ5DC4FWM2T+w1KoiMH2 UQMMNu/zYiJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZSMKmwAKCRCPgPtYfRL+ TmleB/9GoikonMpQzsoue8bY4zkTR2DUMlhr7WgB8GKcA85K6GphUNcrIlGGGAa20Q6D5b72jHH mYzmo0MOL4QlTOGVXNkFOq+9FD0O0w/M115Lew9kxbkU6ZQotm8P1MdKdq+ryK8JUYoQtvfdH5M GX8M+OotZJCDjKn6ywUPdp344uQRGq6E6aXnbKtDh6/Ng8dYersSJC9yq26LATDQNn+JhFrW+yI opOdqMQ0rE9fP24vJ9J0uTOu6PZXyc3SkH/uIN02rz84g1Nibb2CTlFrPhEUq5nF7rM7j5bFdN+ q2ss4BUPeD6LcIhtx/Y3jnHDNsN84k5WTE+jSqo3jtNqb3K1 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231008_130204_573246_3A63A3A6 X-CRM114-Status: GOOD ( 15.82 ) X-Spam-Score: -0.7 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-0.7 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [2a0a:edc0:2:b01:1d:0:0:104 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/txx9ndfmc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/raw/txx9ndfmc.c b/drivers/mtd/nand/raw/txx9ndfmc.c index 83dd092d22ee..e5a94d51c536 100644 --- a/drivers/mtd/nand/raw/txx9ndfmc.c +++ b/drivers/mtd/nand/raw/txx9ndfmc.c @@ -369,7 +369,7 @@ static int __init txx9ndfmc_probe(struct platform_device *dev) return 0; } -static int __exit txx9ndfmc_remove(struct platform_device *dev) +static void __exit txx9ndfmc_remove(struct platform_device *dev) { struct txx9ndfmc_drvdata *drvdata = platform_get_drvdata(dev); int ret, i; @@ -390,7 +390,6 @@ static int __exit txx9ndfmc_remove(struct platform_device *dev) kfree(txx9_priv->mtdname); kfree(txx9_priv); } - return 0; } #ifdef CONFIG_PM @@ -411,7 +410,7 @@ static int txx9ndfmc_resume(struct platform_device *dev) * triggering a section mismatch warning. */ static struct platform_driver txx9ndfmc_driver __refdata = { - .remove = __exit_p(txx9ndfmc_remove), + .remove_new = __exit_p(txx9ndfmc_remove), .resume = txx9ndfmc_resume, .driver = { .name = "txx9ndfmc",