| Message ID | 20230605-ep93xx-v3-6-3d63a5f1103e@maquefel.me |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | ep93xx device tree conversion | expand |
On 20/07/2023 13:29, Nikita Shubin via B4 Relay wrote: > From: Nikita Shubin <nikita.shubin@maquefel.me> > > This adds device tree bindings for the Cirrus Logic EP93xx. > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> > --- > .../bindings/arm/cirrus/ep9301-syscon.yaml | 59 ++++++++++++++++++++++ syscon goes to soc directory. Also, please add vendor prefix to the filenames. > .../devicetree/bindings/arm/cirrus/ep9301.yaml | 39 ++++++++++++++ > 2 files changed, 98 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/cirrus/ep9301-syscon.yaml b/Documentation/devicetree/bindings/arm/cirrus/ep9301-syscon.yaml > new file mode 100644 > index 000000000000..77fbe1f006fd > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/cirrus/ep9301-syscon.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/cirrus/ep9301-syscon.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cirrus Logic EP93xx Platforms System Controller > + > +maintainers: > + - Alexander Sverdlin <alexander.sverdlin@gmail.com> > + - Nikita Shubin <nikita.shubin@maquefel.me> > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - cirrus,ep9302-syscon > + - cirrus,ep9307-syscon > + - cirrus,ep9312-syscon > + - cirrus,ep9315-syscon > + - const: cirrus,ep9301-syscon > + - const: syscon > + - const: simple-mfd > + - items: > + - const: cirrus,ep9301-syscon > + - const: syscon > + - const: simple-mfd > + > + reg: > + maxItems: 1 > + > + reboot: > + type: object > + properties: > + compatible: > + const: cirrus,ep9301-reboot Patch introducing it should be before this one. Also, do not use different styles for your child nodes. Your other nodes use $ref. > + > + clock-controller: > + type: object > + $ref: ../../clock/cirrus,ep9301-clk.yaml Absolute path, so /schemas/clock/cirrus..... > + > + pinctrl: > + type: object > + $ref: ../../pinctrl/cirrus,ep9301-pinctrl.yaml Ditto > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + syscon@80930000 { > + compatible = "cirrus,ep9301-syscon", > + "syscon", "simple-mfd"; > + reg = <0x80930000 0x1000>; Incomplete example. > + }; > diff --git a/Documentation/devicetree/bindings/arm/cirrus/ep9301.yaml b/Documentation/devicetree/bindings/arm/cirrus/ep9301.yaml > new file mode 100644 > index 000000000000..6087784e93fb > --- /dev/null Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/cirrus/ep9301-syscon.yaml b/Documentation/devicetree/bindings/arm/cirrus/ep9301-syscon.yaml new file mode 100644 index 000000000000..77fbe1f006fd --- /dev/null +++ b/Documentation/devicetree/bindings/arm/cirrus/ep9301-syscon.yaml @@ -0,0 +1,59 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/cirrus/ep9301-syscon.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Cirrus Logic EP93xx Platforms System Controller + +maintainers: + - Alexander Sverdlin <alexander.sverdlin@gmail.com> + - Nikita Shubin <nikita.shubin@maquefel.me> + +properties: + compatible: + oneOf: + - items: + - enum: + - cirrus,ep9302-syscon + - cirrus,ep9307-syscon + - cirrus,ep9312-syscon + - cirrus,ep9315-syscon + - const: cirrus,ep9301-syscon + - const: syscon + - const: simple-mfd + - items: + - const: cirrus,ep9301-syscon + - const: syscon + - const: simple-mfd + + reg: + maxItems: 1 + + reboot: + type: object + properties: + compatible: + const: cirrus,ep9301-reboot + + clock-controller: + type: object + $ref: ../../clock/cirrus,ep9301-clk.yaml + + pinctrl: + type: object + $ref: ../../pinctrl/cirrus,ep9301-pinctrl.yaml + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + syscon@80930000 { + compatible = "cirrus,ep9301-syscon", + "syscon", "simple-mfd"; + reg = <0x80930000 0x1000>; + }; diff --git a/Documentation/devicetree/bindings/arm/cirrus/ep9301.yaml b/Documentation/devicetree/bindings/arm/cirrus/ep9301.yaml new file mode 100644 index 000000000000..6087784e93fb --- /dev/null +++ b/Documentation/devicetree/bindings/arm/cirrus/ep9301.yaml @@ -0,0 +1,39 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/cirrus/ep9301.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Cirrus Logic EP93xx platforms + +description: + The EP93xx SoC is a ARMv4T-based with 200 MHz ARM9 CPU. + +maintainers: + - Alexander Sverdlin <alexander.sverdlin@gmail.com> + - Nikita Shubin <nikita.shubin@maquefel.me> + +properties: + $nodename: + const: '/' + compatible: + oneOf: + - description: The TS-7250 is a compact, full-featured Single Board Computer (SBC) + based upon the Cirrus EP9302 ARM9 CPU + items: + - const: technologic,ts7250 + - const: cirrus,ep9301 + + - description: The Liebherr BK3 is a derivate from ts7250 board + items: + - const: liebherr,bk3 + - const: cirrus,ep9301 + + - description: EDB302 is an evaluation board by Cirrus Logic, + based on a Cirrus Logic EP9302 CPU + items: + - const: cirrus,edb9302 + - const: cirrus,ep9301 + +additionalProperties: true +