From patchwork Sat Apr 1 16:19:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764115 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ZfOKfDel; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=b9fAZVcp; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PpjWx1pRRz1yY8 for ; Sun, 2 Apr 2023 02:38:21 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q+8I0Upe8sjGckFjbo9W2+okPR1LjY1RfofyoN2ecdQ=; b=ZfOKfDelqp0Vq8 JJGiMTZ0tTsZwyEITu1Xb/c2tFXlBctzpEr1BdCTDfglde03LoKs3K/fw3La1u+ozuz7sFKxQHdok KT+ABYFeV+J+QB8b4BpSPg9hN0RQJxPlmUIf7Wn2bhUYot2JkK0qhP6tzNBzrtIbbh88YPvbT+Mc2 22MIhOCh5D0iZycpwy7KNZo1c5bF46n27RI1CDal4Yx/zXI9KkbfFyPWVnRYCnzpy1nenwXM17xMx J0AN/h/5eGBYz9yucQ3XhBbwzBQ6G+GX7hIaR6Ajc54Tna5ujQUi4P09qkySIZNox6CwUcDTg9pxR Hj4wDI7Flui5Ec36qqnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieEb-00Awhz-1q; Sat, 01 Apr 2023 16:37:45 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEK-00AwRk-39 for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=iVOSM2Z37bCVGj4weZVcMNa8xT3KmUYLRmfHzRoboII=; b=b9fAZVcpljsH+GQDgL7izXjBVM zLKouvQdNrj/YWc1aM4pMUx3FL4lIB803rhZDR+llIiALIXe3IN0OL8Vqjx5MF4XPIjpIknTDdXbt oJZYQ51Sn8XA1e53kCpV9B8HnP0jw8lNlL4bPRQq4tvHA85oC5TIRejJe/PImAO8t+ZY8bJt5Rtnx ZzGtrFXsZ09cJJKe9PhlL/dhAVjhbhvTw5gUEhJCeohYtcJSY0yjE6WetxYv1GM49xbX3QEmJX2yy Ld/q1PftiIx70xo1SKGQ59ez7LwYhZenH9oCM67MHR84kx81N2xQqdQLanEp/bv/UqSC49T9t0S3R y/As6sIA==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxT-00CYOI-RW for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:10 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxM-000071-Of; Sat, 01 Apr 2023 18:19:56 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxL-008GSe-Ah; Sat, 01 Apr 2023 18:19:55 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxK-009khe-Jg; Sat, 01 Apr 2023 18:19:54 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra , Heiko Stuebner , Phil Edworthy Cc: Richard Weinberger , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 40/49] mtd: rawnand: rockchip: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:29 +0200 Message-Id: <20230401161938.2503204-41-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1838; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=5b0XHAUgin6YhP/t2Zk642ckRtz9ynLH1TjOf9h6WJk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFlLKZ66exyKSWjWWPv7uJwM4AvwSe+dQqGRN rFNljS/ABGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZSwAKCRCPgPtYfRL+ Tqs+B/9BktD5yecoMur2/dGiT9krTJo3UN72YS1ieMgx8g55r7hlTahlQXa1TuHfAYJFUOufoVe au814z3dA45RnUTtHC4jsQ5EY7OuritRayjCfWRzh4lSp8mElLLDJA7qm3ty1+V16kp0iwDDxk6 jSa0tY5yjBAHdhCVVDNo31AEe4ThKEuWQOWWiNl6IbMZ6nRT9ph2zOhiQEfSMfSdcO7i3gvZW++ SCPDaDXLGdYeOlIg+hE1OhAm0tXJ2VsEz3fkO9KNACFRCcRzRc+2m9a0MYDOw/6yFOaZVMYC36l qgpj44JzTogpOXCA7OVjDUqtyvnKc+z0z3FMLUJv7k9suVh1 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172003_974959_939BF35E X-CRM114-Status: GOOD ( 13.63 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Heiko Stuebner --- drivers/mtd/nand/raw/rockchip-nand-controller.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/rockchip-nand-controller.c b/drivers/mtd/nand/raw/rockchip-nand-controller.c index f133985cc053..2312e27362cb 100644 --- a/drivers/mtd/nand/raw/rockchip-nand-controller.c +++ b/drivers/mtd/nand/raw/rockchip-nand-controller.c @@ -1427,7 +1427,7 @@ static int rk_nfc_probe(struct platform_device *pdev) return ret; } -static int rk_nfc_remove(struct platform_device *pdev) +static void rk_nfc_remove(struct platform_device *pdev) { struct rk_nfc *nfc = platform_get_drvdata(pdev); @@ -1435,8 +1435,6 @@ static int rk_nfc_remove(struct platform_device *pdev) kfree(nfc->oob_buf); rk_nfc_chips_cleanup(nfc); rk_nfc_disable_clks(nfc); - - return 0; } static int __maybe_unused rk_nfc_suspend(struct device *dev) @@ -1476,7 +1474,7 @@ static const struct dev_pm_ops rk_nfc_pm_ops = { static struct platform_driver rk_nfc_driver = { .probe = rk_nfc_probe, - .remove = rk_nfc_remove, + .remove_new = rk_nfc_remove, .driver = { .name = "rockchip-nfc", .of_match_table = rk_nfc_id_table,