[v2,10/19] mtd: rawnand: cafe: Get rid of a useless label

Message ID	20200505101353.1776394-11-boris.brezillon@collabora.com
State	Changes Requested
Delegated to:	Miquel Raynal
Headers	show Return-Path: <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id CE9DE2A1B0D; Tue, 5 May 2020 11:14:00 +0100 (BST) From: Boris Brezillon <boris.brezillon@collabora.com> To: Miquel Raynal <miquel.raynal@bootlin.com>, linux-mtd@lists.infradead.org, Lubomir Rintel <lkundrak@v3.sk> Subject: [PATCH v2 10/19] mtd: rawnand: cafe: Get rid of a useless label Date: Tue, 5 May 2020 12:13:44 +0200 Message-Id: <20200505101353.1776394-11-boris.brezillon@collabora.com> In-Reply-To: <20200505101353.1776394-1-boris.brezillon@collabora.com> References: <20200505101353.1776394-1-boris.brezillon@collabora.com> MIME-Version: 1.0 summary: Content analysis details: (-0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [46.235.227.227 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record Precedence: list Cc: Richard Weinberger <richard@nod.at>, Boris Brezillon <boris.brezillon@collabora.com>, Vignesh Raghavendra <vigneshr@ti.com>, Tudor Ambarus <tudor.ambarus@microchip.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" <linux-mtd-bounces@lists.infradead.org> Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org
Series	mtd: rawnand: cafe: Convert to exec_op() (and more) \| expand [v2,00/19] mtd: rawnand: cafe: Convert to exec_op() (and more) [v2,01/19] mtd: rawnand: Propage CS selection to sub operations [v2,02/19] mtd: rawnand: cafe: Get rid of an inaccurate kernel doc header [v2,03/19] mtd: rawnand: cafe: Rename cafe_nand_write_page_lowlevel() [v2,04/19] mtd: rawnand: cafe: Use a correct ECC mode and pass the ECC alg [v2,05/19] mtd: rawnand: cafe: Include linux/io.h instead of asm/io.h [v2,06/19] mtd: rawnand: cafe: Demistify register fields [v2,07/19] mtd: rawnand: cafe: Factor out the controller initialization logic [v2,08/19] mtd: rawnand: cafe: Get rid of the debug module param [v2,09/19] mtd: rawnand: cafe: Use devm_kzalloc and devm_request_irq() [v2,10/19] mtd: rawnand: cafe: Get rid of a useless label [v2,11/19] mtd: rawnand: cafe: Explicitly inherit from nand_controller [v2,12/19] mtd: rawnand: cafe: Don't leave ECC enabled in the write path [v2,13/19] mtd: rawnand: cafe: Don't split things when reading/writing a page [v2,14/19] mtd: rawnand: cafe: Add exec_op() support [v2,15/19] mtd: rawnand: cafe: Get rid of the legacy interface implementation [v2,16/19] mtd: rawnand: cafe: Adjust the cafe_{read, write}_buf() prototypes [v2,17/19] mtd: rawnand: cafe: s/uint{8,16,32}_t/u{8,16,32}/ [v2,18/19] mtd: rawnand: cafe: Drop the cafe_{readl, writel}() wrappers [v2,19/19] mtd: rawnand: cafe: Get rid of the last printk()

Message ID

20200505101353.1776394-11-boris.brezillon@collabora.com

State

Changes Requested

Delegated to:

Miquel Raynal

Headers

From: Boris Brezillon <boris.brezillon@collabora.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>, linux-mtd@lists.infradead.org,
 Lubomir Rintel <lkundrak@v3.sk>
Subject: [PATCH v2 10/19] mtd: rawnand: cafe: Get rid of a useless label
Date: Tue,  5 May 2020 12:13:44 +0200
Message-Id: <20200505101353.1776394-11-boris.brezillon@collabora.com>
In-Reply-To: <20200505101353.1776394-1-boris.brezillon@collabora.com>
References: <20200505101353.1776394-1-boris.brezillon@collabora.com>
MIME-Version: 1.0
Precedence: list
Cc: Richard Weinberger <richard@nod.at>,
 Boris Brezillon <boris.brezillon@collabora.com>,
 Vignesh Raghavendra <vigneshr@ti.com>,
 Tudor Ambarus <tudor.ambarus@microchip.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "linux-mtd" <linux-mtd-bounces@lists.infradead.org>
Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org

Series

mtd: rawnand: cafe: Convert to exec_op() (and more) | expand

Commit Message

Boris Brezillon May 5, 2020, 10:13 a.m. UTC

We can return 0 directly instead of branching to the out label.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Tested-by: Lubomir Rintel <lkundrak@v3.sk>
---
Changes in v2:
* Add R-b/T-b
---
 drivers/mtd/nand/raw/cafe_nand.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/raw/cafe_nand.c b/drivers/mtd/nand/raw/cafe_nand.c
index 93e8e124df45..84b8d50c7f08 100644
--- a/drivers/mtd/nand/raw/cafe_nand.c
+++ b/drivers/mtd/nand/raw/cafe_nand.c
@@ -930,7 +930,7 @@  static int cafe_nand_probe(struct pci_dev *pdev,
 	if (err)
 		goto out_cleanup_nand;
 
-	goto out;
+	return 0;
 
  out_cleanup_nand:
 	nand_cleanup(&cafe->nand);
@@ -941,7 +941,6 @@  static int cafe_nand_probe(struct pci_dev *pdev,
 		    GLOBAL_IRQ_MASK);
  out_ior:
 	pci_iounmap(pdev, cafe->mmio);
- out:
 	return err;
 }

[v2,10/19] mtd: rawnand: cafe: Get rid of a useless label

Commit Message

Patch