Message ID | 20200429132046.583658-3-boris.brezillon@collabora.com |
---|---|
State | Changes Requested |
Delegated to: | Miquel Raynal |
Headers | show |
Series | mtd: rawnand: atmel: Convert the driver to exec_op() | expand |
Hi Boris, Boris Brezillon <boris.brezillon@collabora.com> wrote on Wed, 29 Apr 2020 15:20:42 +0200: > The legacy page read path in atmel_hsmc_nand_pmecc_read_pg() issues > a nand_read_page_op() that's already issued by > atmel_nand_pmecc_read_pg(). Let's get rid of the unneeded one. > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> > --- > Changes in v2: > * New patch Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
On Wednesday, April 29, 2020 4:20:42 PM EEST Boris Brezillon wrote: > The legacy page read path in atmel_hsmc_nand_pmecc_read_pg() issues > a nand_read_page_op() that's already issued by > atmel_nand_pmecc_read_pg(). Let's get rid of the unneeded one. > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> > --- > Changes in v2: > * New patch > --- > drivers/mtd/nand/raw/atmel/nand-controller.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c index 1ba60b61dedc..8e5cfb5cf70b 100644 --- a/drivers/mtd/nand/raw/atmel/nand-controller.c +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c @@ -983,12 +983,9 @@ static int atmel_hsmc_nand_pmecc_read_pg(struct nand_chip *chip, u8 *buf, * connected to a native SoC R/B pin. If that's not the case, fallback * to the non-optimized one. */ - if (nand->activecs->rb.type != ATMEL_NAND_NATIVE_RB) { - nand_read_page_op(chip, page, 0, NULL, 0); - + if (nand->activecs->rb.type != ATMEL_NAND_NATIVE_RB) return atmel_nand_pmecc_read_pg(chip, buf, oob_required, page, raw); - } nc->op.cmds[nc->op.ncmds++] = NAND_CMD_READ0;
The legacy page read path in atmel_hsmc_nand_pmecc_read_pg() issues a nand_read_page_op() that's already issued by atmel_nand_pmecc_read_pg(). Let's get rid of the unneeded one. Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> --- Changes in v2: * New patch --- drivers/mtd/nand/raw/atmel/nand-controller.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)