| Message ID | 20200102130826.170647-2-esben@geanix.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | None | expand |
On Thu, Jan 2, 2020 at 7:08 AM Esben Haabendal <esben@geanix.com> wrote: > > As we reset the GPMI block at resume, the timing parameters setup by a > previous exec_op is lost. Rewriting GPMI timing registers on first exec_op > after resume fixes the problem. > > Signed-off-by: Esben Haabendal <esben@geanix.com> > --- > drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > index 7ac8c8b95afc..fcc7325f2a10 100644 > --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > @@ -2728,6 +2728,10 @@ static int gpmi_pm_resume(struct device *dev) > return ret; > } > > + /* Set flag to get timing setup restored for next exec_op */ > + if (this->hw.clk_rate) > + this->hw.must_apply_timings = true; > + Acked-by: Han Xu <han.xu@nxp.com> > /* re-init the BCH registers */ > ret = bch_set_geometry(this); > if (ret) { > -- > 2.24.1 > > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/
On Thu, 2020-01-02 at 13:08:26 UTC, Esben Haabendal wrote: > As we reset the GPMI block at resume, the timing parameters setup by a > previous exec_op is lost. Rewriting GPMI timing registers on first exec_op > after resume fixes the problem. > > Signed-off-by: Esben Haabendal <esben@geanix.com> > Acked-by: Han Xu <han.xu@nxp.com> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel
diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c index 7ac8c8b95afc..fcc7325f2a10 100644 --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c @@ -2728,6 +2728,10 @@ static int gpmi_pm_resume(struct device *dev) return ret; } + /* Set flag to get timing setup restored for next exec_op */ + if (this->hw.clk_rate) + this->hw.must_apply_timings = true; + /* re-init the BCH registers */ ret = bch_set_geometry(this); if (ret) {
As we reset the GPMI block at resume, the timing parameters setup by a previous exec_op is lost. Rewriting GPMI timing registers on first exec_op after resume fixes the problem. Signed-off-by: Esben Haabendal <esben@geanix.com> --- drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 4 ++++ 1 file changed, 4 insertions(+)