| Message ID | 20191110144442.26680-3-david.oberhollenzer@sigma-star.at |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mkfs.ubifs: some error handling fixes | expand |
diff --git a/ubifs-utils/mkfs.ubifs/mkfs.ubifs.c b/ubifs-utils/mkfs.ubifs/mkfs.ubifs.c index 5748aaa..72ae1b4 100644 --- a/ubifs-utils/mkfs.ubifs/mkfs.ubifs.c +++ b/ubifs-utils/mkfs.ubifs/mkfs.ubifs.c @@ -2043,8 +2043,7 @@ static int add_directory(const char *dir_name, ino_t dir_inum, struct stat *st, if (errno == 0) break; sys_err_msg("error reading directory '%s'", dir_name); - err = -1; - break; + goto out_free; } if (strcmp(".", entry->d_name) == 0)
The existing code sets 'err' to -1 and breaks the readdir loop, but the error state is never read. This patch modifies the readdir loop to actualy jump to the error handling branch if readdir fails. Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at> --- ubifs-utils/mkfs.ubifs/mkfs.ubifs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)