diff mbox series

[2/2] ubihealthd: Add option -h/--help

Message ID 20191003063501.18421-3-post@lespocky.de
State Accepted
Delegated to: Richard Weinberger
Headers show
Series ubihealthd: Fix options | expand

Commit Message

Alexander Dahl Oct. 3, 2019, 6:35 a.m. UTC 
Using '?' as option did not work, and would be strange to pass anyway,
because it's a glob char for the shell and you would have to escape it
like ./ubihealthd -\? … use the more common -h/--help instead.

Note: this does not touch the output, just changes the options itself.

Signed-off-by: Alexander Dahl <post@lespocky.de>
---
 ubi-utils/ubihealthd.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/ubi-utils/ubihealthd.c b/ubi-utils/ubihealthd.c
index f38235b..27799f7 100644
--- a/ubi-utils/ubihealthd.c
+++ b/ubi-utils/ubihealthd.c
@@ -42,7 +42,7 @@  static int ubi_fd;
 static int interval_secs = 120;
 static int nodaemon;
 
-static const char opt_string[] = "d:i:f";
+static const char opt_string[] = "d:i:fh";
 static const struct option options[] = {
         {
                 .name = "device",
@@ -56,6 +56,12 @@  static const struct option options[] = {
                 .flag = NULL,
                 .val = 'i'
         },
+	{
+		.name = "help",
+		.has_arg = no_argument,
+		.flag = NULL,
+		.val = 'h'
+	},
 	{ /* sentinel */ }
 };
 
@@ -238,7 +244,7 @@  int main (int argc, char *argv[])
 			nodaemon = 1;
 			break;
 		}
-		case '?':
+		case 'h':
 		default:
 			fprintf(stderr, "Usage: %s [ -d UBI_DEVICE ] [-i INTERVAL_SEC ] [ -f ]\n", argv[0]);
 			exit(1);