From patchwork Thu Dec 20 12:46:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Lenngren X-Patchwork-Id: 1016758 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nDuc/mmD"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="aFbkh/x4"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43LBNr2GSDz9s7W for ; Thu, 20 Dec 2018 23:47:24 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=5xYwLtmBPKpLel3UnGgokhmn/lkhFP1sA8uYyN+vL1g=; b=nDu c/mmDDE+wKpMqb0YXS+a2PQv19nl50rqrW+COZflXS5nmovGnhayBxeCr7faKOWqoYiyvrmJqyF6+ cdJIUMVc5bj1g86HEtLpDFN1JuAE65Dc87uQNtaID/WeiCvG6RcwOZBfNY1HcDdL1K57GqXbH/7gA wazlmBEJnC0c+taSlkHBiOD7y8JLg5elS8bc0J6zKtpg+RG4yT9+UoBmj1QQQ7hwUMI1dfvM48o/G 2K8YbT/V7E9RkmBpxig0jtwUN6qmz4+DFQfC1QlaRC55UMV8DPZ0rKwzahhLDm53pZJf7W0R3MavA kwuOKIyukggB9zj4SJC0Qd4SwHAmu0g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gZxjT-0000GJ-NE; Thu, 20 Dec 2018 12:47:19 +0000 Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gZxjQ-0000F4-F0 for linux-mtd@lists.infradead.org; Thu, 20 Dec 2018 12:47:18 +0000 Received: by mail-lj1-x244.google.com with SMTP id s5-v6so1415175ljd.12 for ; Thu, 20 Dec 2018 04:47:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=w1nne5ZB2Dkm6mqfOpWuGMU8bK+kYZ8QvHPjcpbK5fU=; b=aFbkh/x4LUPJe0+kTqLypnPqN5n/FWW2ScJJMk7af3Mp+YJ6C9Cb8xTGkM0JjVs/D4 3y5J5V9G0m3bCqaVUVV4U+CYyW5soKvZxB9ON9laxBomvsz3m8OBzCX0w0gq0IF2VT/g fFi+VBB/kmmaNTEukPpw3sLDb3tz8nfzsZrHelZlPe7EIxzi7kCDbsQNx5zQKrbQNwEC 0mpf+gat0082mwA/CIbe19yS+ICh6h8wQRZdhFFJOUohTUzFj1T9omx8iCKzA+agpcor CFxYyJtB/JnnpZQhuPrrCF99PtJVwm55vz8w56MZkmolliEI9OwPoe0fb4jZ2lRa9BS5 NcoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=w1nne5ZB2Dkm6mqfOpWuGMU8bK+kYZ8QvHPjcpbK5fU=; b=LDsona8QcCKoVvO+nevb7xYbiKOPJdZBda/ejYIgNe9DofeegG40CR8mvFXidMTFot cgaOc2a1zZf5EkDKzLEqzgLINwGmPBupoN2PDFseVupBc8PAI7uk+jdboSyehFwtG1LS RwCNi/5QH1Do4lsQFn+2Bvj/HUfx/od007ql/tRg1412FqR6lZZKpPESRJ0i1xYaDPop 26APVLJb6wsnnEA1Zdba5X9mFBAc+RhbFiIuyovgLxfE9VgBviYPW6HWizKnUZpfwaso GGKFs/z1J55vLMLqiHirgYJQmDRibeNiadfpxgqvA2L7yH2aPsnCOFAkenyQ+9TBXyYs ngOg== X-Gm-Message-State: AA+aEWYbszq4HjcESMe9vGbsj5yg0RsVbLh/QfSC8c/84eNqRXr+3C1a OZnTyqpHgrfBmvQLpgz18waFRDIV X-Google-Smtp-Source: AFSGD/W5CLWhb50EhRt1SSD3nlEYn5wq9468tOB6dUGFFEF86JdjStt65w+Qc1U7dATXZeT/j5gdvw== X-Received: by 2002:a2e:93d7:: with SMTP id p23-v6mr14702956ljh.22.1545310024054; Thu, 20 Dec 2018 04:47:04 -0800 (PST) Received: from localhost.localdomain ([195.178.184.66]) by smtp.gmail.com with ESMTPSA id e5-v6sm4033615ljj.91.2018.12.20.04.47.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Dec 2018 04:47:03 -0800 (PST) From: Emil Lenngren To: linux-mtd@lists.infradead.org Subject: [PATCH] mtd: spinand: Fix Macronix ECC Status Read Date: Thu, 20 Dec 2018 13:46:58 +0100 Message-Id: <20181220124658.11565-1-emil.lenngren@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181220_044716_522740_D6E5F55E X-CRM114-Status: GOOD ( 10.90 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:244 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (emil.lenngren[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emil Lenngren MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The datasheet specifies the upper four bits are reserved. Testing on real hardware shows that these bits can indeed be nonzero. Signed-off-by: Emil Lenngren Reviewed-by: Boris Brezillon --- drivers/mtd/nand/spi/macronix.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/spi/macronix.c b/drivers/mtd/nand/spi/macronix.c index 98f6b9c4b6..d16b57081c 100644 --- a/drivers/mtd/nand/spi/macronix.c +++ b/drivers/mtd/nand/spi/macronix.c @@ -10,6 +10,7 @@ #include #define SPINAND_MFR_MACRONIX 0xC2 +#define MACRONIX_ECCSR_MASK 0x0F static SPINAND_OP_VARIANTS(read_cache_variants, SPINAND_PAGE_READ_FROM_CACHE_X4_OP(0, 1, NULL, 0), @@ -55,7 +56,12 @@ static int mx35lf1ge4ab_get_eccsr(struct spinand_device *spinand, u8 *eccsr) SPI_MEM_OP_DUMMY(1, 1), SPI_MEM_OP_DATA_IN(1, eccsr, 1)); - return spi_mem_exec_op(spinand->spimem, &op); + int ret = spi_mem_exec_op(spinand->spimem, &op); + if (ret) + return ret; + + *eccsr &= MACRONIX_ECCSR_MASK; + return 0; } static int mx35lf1ge4ab_ecc_get_status(struct spinand_device *spinand,