| Message ID | 20171029131426.6205-1-colin.king@canonical.com |
|---|---|
| State | Accepted |
| Delegated to: | Richard Weinberger |
| Headers | show |
| Series | ubi: fastmap: clean up the initialization of pointer p | expand |
On Sun, 29 Oct 2017 13:14:26 +0000 Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > The pointer p is being initialized with one value and a few lines > later being set to a newer replacement value. Clean up the code by > using the latter assignment to p as the initial value. Cleans up > clang warning: > > drivers/mtd/ubi/fastmap.c:217:19: warning: Value stored to 'p' > during its initialization is never read > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com> > --- > drivers/mtd/ubi/fastmap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c > index 5a832bc79b1b..9be4b94e83ad 100644 > --- a/drivers/mtd/ubi/fastmap.c > +++ b/drivers/mtd/ubi/fastmap.c > @@ -214,9 +214,8 @@ static void assign_aeb_to_av(struct ubi_attach_info *ai, > struct ubi_ainf_volume *av) > { > struct ubi_ainf_peb *tmp_aeb; > - struct rb_node **p = &ai->volumes.rb_node, *parent = NULL; > + struct rb_node **p = &av->root.rb_node, *parent = NULL; > > - p = &av->root.rb_node; > while (*p) { > parent = *p; >
diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c index 5a832bc79b1b..9be4b94e83ad 100644 --- a/drivers/mtd/ubi/fastmap.c +++ b/drivers/mtd/ubi/fastmap.c @@ -214,9 +214,8 @@ static void assign_aeb_to_av(struct ubi_attach_info *ai, struct ubi_ainf_volume *av) { struct ubi_ainf_peb *tmp_aeb; - struct rb_node **p = &ai->volumes.rb_node, *parent = NULL; + struct rb_node **p = &av->root.rb_node, *parent = NULL; - p = &av->root.rb_node; while (*p) { parent = *p;