| Message ID | 20170504121100.2709-1-colin.king@canonical.com |
|---|---|
| State | Accepted |
| Commit | d4ed3b9015b5eebc90d629579d9e7944607cbae5 |
| Delegated to: | Boris Brezillon |
| Headers | show |
On Thu, 4 May 2017 13:11:00 +0100 Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > nand_ooblayout_lp_hamming_ops can be made static as it does not need to be > in global scope. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com> Brian, feel free to apply this patch directly if you want, otherwise, I'll queue it for 4.13. > --- > drivers/mtd/nand/nand_base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c > index d474378ed810..d3a735012b81 100644 > --- a/drivers/mtd/nand/nand_base.c > +++ b/drivers/mtd/nand/nand_base.c > @@ -202,7 +202,7 @@ static int nand_ooblayout_free_lp_hamming(struct mtd_info *mtd, int section, > return 0; > } > > -const struct mtd_ooblayout_ops nand_ooblayout_lp_hamming_ops = { > +static const struct mtd_ooblayout_ops nand_ooblayout_lp_hamming_ops = { > .ecc = nand_ooblayout_ecc_lp_hamming, > .free = nand_ooblayout_free_lp_hamming, > };
On Thu, May 04, 2017 at 04:08:13PM +0200, Boris Brezillon wrote: > On Thu, 4 May 2017 13:11:00 +0100 > Colin King <colin.king@canonical.com> wrote: > > > From: Colin Ian King <colin.king@canonical.com> > > > > nand_ooblayout_lp_hamming_ops can be made static as it does not need to be > > in global scope. > > > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com> > > Brian, feel free to apply this patch directly if you want, otherwise, > I'll queue it for 4.13. Eh, queue it for 4.13, or in a fixes branch if you want.
On Thu, 4 May 2017 13:11:00 +0100 Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > nand_ooblayout_lp_hamming_ops can be made static as it does not need to be > in global scope. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Applied to nand/fixes. Thanks, Boris > --- > drivers/mtd/nand/nand_base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c > index d474378ed810..d3a735012b81 100644 > --- a/drivers/mtd/nand/nand_base.c > +++ b/drivers/mtd/nand/nand_base.c > @@ -202,7 +202,7 @@ static int nand_ooblayout_free_lp_hamming(struct mtd_info *mtd, int section, > return 0; > } > > -const struct mtd_ooblayout_ops nand_ooblayout_lp_hamming_ops = { > +static const struct mtd_ooblayout_ops nand_ooblayout_lp_hamming_ops = { > .ecc = nand_ooblayout_ecc_lp_hamming, > .free = nand_ooblayout_free_lp_hamming, > };
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c index d474378ed810..d3a735012b81 100644 --- a/drivers/mtd/nand/nand_base.c +++ b/drivers/mtd/nand/nand_base.c @@ -202,7 +202,7 @@ static int nand_ooblayout_free_lp_hamming(struct mtd_info *mtd, int section, return 0; } -const struct mtd_ooblayout_ops nand_ooblayout_lp_hamming_ops = { +static const struct mtd_ooblayout_ops nand_ooblayout_lp_hamming_ops = { .ecc = nand_ooblayout_ecc_lp_hamming, .free = nand_ooblayout_free_lp_hamming, };