From patchwork Mon Apr 19 11:39:53 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=C3=B6rn_Engel?= X-Patchwork-Id: 50458 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 9C08DB7D0F for ; Mon, 19 Apr 2010 21:42:10 +1000 (EST) Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1O3pKi-0005dg-M1; Mon, 19 Apr 2010 11:40:08 +0000 Received: from lazybastard.de ([212.112.238.170] helo=longford.logfs.org) by bombadil.infradead.org with esmtps (Exim 4.69 #1 (Red Hat Linux)) id 1O3pKe-0005JZ-6D for linux-mtd@lists.infradead.org; Mon, 19 Apr 2010 11:40:05 +0000 Received: from joern by longford.logfs.org with local (Exim 4.63) (envelope-from ) id 1O3pKW-00035O-Au; Mon, 19 Apr 2010 13:39:56 +0200 Date: Mon, 19 Apr 2010 13:39:53 +0200 From: =?utf-8?B?SsO2cm4=?= Engel To: David Woodhouse Subject: Re: [PATCH] [MTD] Fix JFFS2 sync silent failure Message-ID: <20100419113952.GB4145@logfs.org> References: <20100417184016.GA17345@logfs.org> <20100419073843.GN27497@kernel.dk> <20100419101559.GA4145@logfs.org> <20100419102056.GS27497@kernel.dk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20100419102056.GS27497@kernel.dk> User-Agent: Mutt/1.5.13 (2006-08-11) X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20100419_074004_352781_B3621F88 X-CRM114-Status: UNSURE ( 9.58 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.3.1 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- Cc: Christoph Hellwig , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Jens Axboe X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org On Mon, 19 April 2010 12:20:56 +0200, Jens Axboe wrote: > > Care to send your jffs2 patch separately to David? Then I'll commit a > modified variant for complaining about missing ->s_bdi on mount. Sure. David, this patch is untested. It looks trivially correct and fixes a nasty bug, but I don't test jffs2 and only noticed the problem in passing. Jörn diff --git a/drivers/mtd/mtdsuper.c b/drivers/mtd/mtdsuper.c index af8b42e..7c00319 100644 --- a/drivers/mtd/mtdsuper.c +++ b/drivers/mtd/mtdsuper.c @@ -44,6 +45,7 @@ static int get_sb_mtd_set(struct super_block *sb, void *_mtd) sb->s_mtd = mtd; sb->s_dev = MKDEV(MTD_BLOCK_MAJOR, mtd->index); + sb->s_bdi = mtd->backing_dev_info; return 0; }