Message ID | 1566849476-41546-1-git-send-email-kdasu.kdev@gmail.com |
---|---|
State | Accepted |
Headers | show |
Series | mtd: rawnand: brcmnand: Fix ecc chunk calculation for erased page bitfips | expand |
On Mon, 2019-08-26 at 19:57:56 UTC, Kamal Dasu wrote: > From: Claire Lin <claire.lin@broadcom.com> > > In brcmstb_nand_verify_erased_page(), fix ecc chunk pointer calculation > while correcting erased page bitflip. > > Fixes: 02b88eea9f9c ("mtd: brcmnand: Add check for erased page bitflips") > Signed-off-by: Claire Lin <claire.lin@broadcom.com> > Reviewed-by: Ray Jui <ray.jui@broadcom.com> > Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel
diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c index 33310b8..15ef30b 100644 --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c @@ -1792,6 +1792,7 @@ static int brcmstb_nand_verify_erased_page(struct mtd_info *mtd, int bitflips = 0; int page = addr >> chip->page_shift; int ret; + void *ecc_chunk; if (!buf) buf = nand_get_data_buf(chip); @@ -1804,7 +1805,9 @@ static int brcmstb_nand_verify_erased_page(struct mtd_info *mtd, return ret; for (i = 0; i < chip->ecc.steps; i++, oob += sas) { - ret = nand_check_erased_ecc_chunk(buf, chip->ecc.size, + ecc_chunk = buf + chip->ecc.size * i; + ret = nand_check_erased_ecc_chunk(ecc_chunk, + chip->ecc.size, oob, sas, NULL, 0, chip->ecc.strength); if (ret < 0)