From patchwork Tue Jan 2 20:14:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Dasu X-Patchwork-Id: 854746 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vBffKeOl"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="FJfQ2oe7"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zB51F2WzVz9s7n for ; Wed, 3 Jan 2018 07:16:17 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=Z17QgDZKC7JcLcn5VI51CFKLccqYeJncdzVZQmPt7YU=; b=vBf fKeOlDuzmK1SImhqVLI9/FIdI693LVHU5ppBkWKd6HenAyaEfG8YmCQos5xZFc9jQnMiGWCbLt0Hp f0dD5uPHNEaM2lj9G+6X9BK6NyEowWJJmCQw2bnn81xPPcNc3gNRDfzkEEEQvRvZ3lxWfuKdsWByM lS9+BQVYKXBxYvnr2rLu0oYkP7WO3RImEN+ke/sApWaUG9eP0eKdDdS7IGPZv3d/9/i7jDFWkAfFD C/aNTwz7fpKyWgs9Sz5H3dwLn2s2NcAe86DTPgOkytRMi+XGexn4TzuxckiszYq2gfJt6nRZ22gHm V/d2kIi+tZ782Nazs6MvmLFA6ZLCTpQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eWSyk-0004Bn-9O; Tue, 02 Jan 2018 20:16:06 +0000 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eWSy3-0002kV-JZ for linux-mtd@lists.infradead.org; Tue, 02 Jan 2018 20:15:51 +0000 Received: by mail-qt0-x241.google.com with SMTP id g9so64209823qth.9 for ; Tue, 02 Jan 2018 12:15:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=WQ7KCNC3OJd6qxr40GmMTQSYTS4vB4VUyAC8Eu7U+wE=; b=FJfQ2oe7wgqRuBwG9SbVihb7PvnUsbEvmr0WkbyvHecexXmuAN9FhX/SKScxR3Z4lo y3lEwkV8z5qgQNgIspJ1Tmu0KadX01DmCO08AKov5rjj0FzAspWckL8ZL8G89CUCvh34 2ziqKGL9LIxeLEoE1F17JEyUKpqvaBns03aMT77pzWn89ZvPn3VJZfZzovZljtK5GxWR SXmjBfEg3sE1iX3fTMBSXj/7FmxHKEbEgVL4pSssYcalGakbfKIQOxzMG1S145iF/K9y FqV/mvCCeWA3umbSalDWKiq3DChTJaXqf6ZgKWimsPajoLItWkeQew6aS3g0QRhbKGa7 nNQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=WQ7KCNC3OJd6qxr40GmMTQSYTS4vB4VUyAC8Eu7U+wE=; b=AZX9QTuEZmj3j0JCs63xd347XSzrzXrEaNMxVxE84GNT12maboFuC+iY8tEfO+ffYI fKlw8hjk4SRm1YOlxVC+KmRGYzyPjS+a9ZnV5LPpMmdAGefDnQSvKw5hrbXMHyZrILbY rq6QYQ6t1D4bJSPaHx18sb30MGr4Gi36/x7QYtvrZ2Wa458i/K21KalXvdSxs+kRPW5Z aalJU19ZG09sashsfJq4ERbLerjCuEdtQHnjPGVsBmSb1hcdtRuWEXqEgnm8YeE0Ztgm ih+Ivy8H4jdzrmEWuWaOSkJkAsxWORu63U/hqWIRIh6XjgV0AG2+qDgOdkIdl5NNQX9I nmPw== X-Gm-Message-State: AKGB3mLj7JSFOEr+3HlKt0SOHeaM06b5asqXqs9n8O3Q8MJZRfLCAvUK 4qQO2xaCY1SlEgaqCgmWCOo= X-Google-Smtp-Source: ACJfBouIhdCTNXFAizv/viTwyLHOHC61sRlcMZPiQsUCsvo6bQTqCsmj5HjFeeYn4OY/q9fNz5SK/A== X-Received: by 10.55.183.67 with SMTP id h64mr19287754qkf.67.1514924111822; Tue, 02 Jan 2018 12:15:11 -0800 (PST) Received: from mail.broadcom.com ([192.19.231.250]) by smtp.gmail.com with ESMTPSA id f38sm29559819qtc.73.2018.01.02.12.15.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 02 Jan 2018 12:15:11 -0800 (PST) From: Kamal Dasu To: boris.brezillon@free-electrons.com, linux-mtd@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com Subject: [PATCH] mtd: brcmnand: Disable prefetch by default Date: Tue, 2 Jan 2018 15:14:57 -0500 Message-Id: <1514924097-1630-1-git-send-email-kdasu.kdev@gmail.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180102_121523_847687_835F733D X-CRM114-Status: UNSURE ( 7.91 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:400d:c0d:0:0:0:241 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (kdasu.kdev[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kamal Dasu , richard@nod.at, marek.vasut@gmail.com, cyrille.pitchen@wedev4u.fr, computersforpeace@gmail.com, dwmw2@infradead.org MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Brcm nand controller prefetch feature needs to be disabled by default. Enabling effects performance on random reads as well as dma reads. Signed-off-by: Kamal Dasu --- drivers/mtd/nand/brcmnand/brcmnand.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c b/drivers/mtd/nand/brcmnand/brcmnand.c index dd56a67..2a978d9 100644 --- a/drivers/mtd/nand/brcmnand/brcmnand.c +++ b/drivers/mtd/nand/brcmnand/brcmnand.c @@ -2193,16 +2193,9 @@ static int brcmnand_setup_dev(struct brcmnand_host *host) if (ctrl->nand_version >= 0x0702) tmp |= ACC_CONTROL_RD_ERASED; tmp &= ~ACC_CONTROL_FAST_PGM_RDIN; - if (ctrl->features & BRCMNAND_HAS_PREFETCH) { - /* - * FIXME: Flash DMA + prefetch may see spurious erased-page ECC - * errors - */ - if (has_flash_dma(ctrl)) - tmp &= ~ACC_CONTROL_PREFETCH; - else - tmp |= ACC_CONTROL_PREFETCH; - } + if (ctrl->features & BRCMNAND_HAS_PREFETCH) + tmp &= ~ACC_CONTROL_PREFETCH; + nand_writereg(ctrl, offs, tmp); return 0;