From patchwork Fri Jul 8 17:36:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 646534 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rmMF95Hcsz9s8d for ; Sat, 9 Jul 2016 03:39:41 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=oQYbYQyL; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bLZi8-0002tk-1K; Fri, 08 Jul 2016 17:37:08 +0000 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bLZi3-0002gI-B4 for linux-mtd@lists.infradead.org; Fri, 08 Jul 2016 17:37:03 +0000 Received: by mail-pf0-x243.google.com with SMTP id i123so8889902pfg.3 for ; Fri, 08 Jul 2016 10:36:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=i+pnZbPdy8vzNQ/TZH1d4p2W3cZJGFZcTzslaRJ2hrM=; b=oQYbYQyLHo76Uv6fcJDpi9Pf48sjytMCCMzdwN4lDwEV/6BDbJCJcIRXkcNVZ61y65 OF4XTM5MDeT/nbyq5eV0S+/bseMZLd4Ve8VrGtcQ2Q6/yJyXhjIg0TljR6CysfRs3vI0 wPRNfv/R+i9uCXDh6yGVm0yqaSmDYAmn+9DRO2my3LLm14RXq6A/IeRYrAp2yxeB3/Xb OLf9y+3YlDKBPI2MlLYH3LSyLoyXqBBVqiC6T4IAz1XXie9GISoXnASphHsDfQJ6tSzZ GtEaJ9bJKEZiyIKxka99+1ozwhgExxWGoYwaCtgMeOzP0oCFMss/sCCUo9OB20pVIrbf x4Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=i+pnZbPdy8vzNQ/TZH1d4p2W3cZJGFZcTzslaRJ2hrM=; b=H4VZS2XK0n0EFYsP3x7ikMpx06KAGvcZx/WdIdzmsHMb5432aEv4++GBXHFvWVZcnP mSqm2CT6j1EZ26daJUUKdrt1QU1rOEvBS+8LnhsM5oiYAbDulCIxlNRkb43Ub3xLIGqF AGnfNF1SPr5TxxdaUpfbIYsLnCeasY2opBRmC1RPScHk+ecAajTbyFk+frP7HdCPgEVf mR8bPlJCQEhgcRBM1A/Z0BrRowVr+oU+GhAzqQt+XVKrVIihqoWSQ10jzvShvnHZrtqQ VW1MKTRbA36izHrytm1AA/X/gVpyv7C4lLx7wmM+SA+gFJthYoJJOiXaSeqYC4e5LtDu vB3A== X-Gm-Message-State: ALyK8tK++Bu7vUlq8r+aVUO842iShiYiY1VW3jy84SJvd6xTNhXs/0oFQLo2dYQKKq6Xpg== X-Received: by 10.98.196.203 with SMTP id h72mr11819513pfk.54.1467999402800; Fri, 08 Jul 2016 10:36:42 -0700 (PDT) Received: from fainelli-desktop.broadcom.com (5520-maca-inet1-outside.broadcom.com. [216.31.211.11]) by smtp.gmail.com with ESMTPSA id d2sm6046486pfk.36.2016.07.08.10.36.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 08 Jul 2016 10:36:41 -0700 (PDT) From: Florian Fainelli To: linux-mtd@lists.infradead.org Subject: [PATCH] mtd: nand: brcmnand: Change BUG_ON in brcmnand_send_cmd Date: Fri, 8 Jul 2016 10:36:39 -0700 Message-Id: <1467999399-22288-1-git-send-email-f.fainelli@gmail.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160708_103703_431595_3DB42B95 X-CRM114-Status: GOOD ( 11.11 ) X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2607:f8b0:400e:c00:0:0:0:243 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (f.fainelli[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , Florian Fainelli , Kamal Dasu , Richard Weinberger , open list , "open list:BROADCOM STB NAND FLASH DRIVER" , Brian Norris , David Woodhouse MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Change the BUG_ON() condition in brcmnand_send_cmd() which checks for the interrupt status "controller ready" bit to a WARN_ON. There is no good reason to kill the system when this condition occur because we could have systems which listed the NAND controller as available (e.g: from Device Tree), but the NAND chip could be malfunctioning and not responding. Signed-off-by: Florian Fainelli Acked-by: Brian Norris Reviewed-by: Kamal Dasu --- Note that I even hesitated to remove that completely, but there is some value in knowing about this condition since it helps figuring out what could be wrong. drivers/mtd/nand/brcmnand/brcmnand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c b/drivers/mtd/nand/brcmnand/brcmnand.c index b6062a2f3dfd..72bdc283778d 100644 --- a/drivers/mtd/nand/brcmnand/brcmnand.c +++ b/drivers/mtd/nand/brcmnand/brcmnand.c @@ -1165,7 +1165,7 @@ static void brcmnand_send_cmd(struct brcmnand_host *host, int cmd) ctrl->cmd_pending = cmd; intfc = brcmnand_read_reg(ctrl, BRCMNAND_INTFC_STATUS); - BUG_ON(!(intfc & INTFC_CTLR_READY)); + WARN_ON(!(intfc & INTFC_CTLR_READY)); mb(); /* flush previous writes */ brcmnand_write_reg(ctrl, BRCMNAND_CMD_START,