From patchwork Mon Apr 4 17:25:10 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Han Xu X-Patchwork-Id: 605949 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3qdzrv2j0Wz9s9x for ; Tue, 5 Apr 2016 03:44:47 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=GV7u3OR8; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1an8WR-0004ZZ-L8; Mon, 04 Apr 2016 17:42:43 +0000 Received: from mail-db5eur01on0088.outbound.protection.outlook.com ([104.47.2.88] helo=EUR01-DB5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1an8WN-0004Uf-6N for linux-mtd@lists.infradead.org; Mon, 04 Apr 2016 17:42:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-nxp-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=MpardLy02PYg2LsRF32dW+P/SH0Z2ZyPXn3xkdxmRqk=; b=GV7u3OR849esU2wClgHzjT7W7p+6E5aTKc0h0L6kfoVRwIp1yjnNB9jTGxj8R7saPhj61D3xj4SDAm8OkKb75dnrmV0uNfHtMxIkuErBVJx9szU40zlOvdoUoB3p1DFUH0EJDd+8yEZ5J2G8EKnxFv7X68KgNpI2m0wnNujsaRo= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; Received: from chopperman.am.freescale.net (192.88.168.49) by DB5PR0401MB1798.eurprd04.prod.outlook.com (10.165.5.152) with Microsoft SMTP Server (TLS) id 15.1.447.15; Mon, 4 Apr 2016 17:42:14 +0000 From: Han Xu To: , , , , Subject: [PATCH] mtd: gpmi: fix raw_buffer pointer double free issue Date: Mon, 4 Apr 2016 12:25:10 -0500 Message-ID: <1459790710-25747-1-git-send-email-han.xu@nxp.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 X-Originating-IP: [192.88.168.49] X-ClientProxiedBy: BLUPR01CA049.prod.exchangelabs.com (10.160.23.39) To DB5PR0401MB1798.eurprd04.prod.outlook.com (10.165.5.152) X-MS-Office365-Filtering-Correlation-Id: e19d0088-9cb9-458a-01c3-08d35cb0761f X-Microsoft-Exchange-Diagnostics: 1; DB5PR0401MB1798; 2:pF9TjBgpOWwIolINW8/aOKm8W0UgrHMj2Rlc6NiRuwluinA0y6qbby3f3Y+FE+2YAt4ZARpUy3+b7Gpn8YhxRrvK/oaJxi/LTtHDxXw07rwvu2dEaoWKW6OIf/teA8t2fT/tSh3sdIWYW+pSMUTtH09vqZloioIASQc4BVUnNC/BMd4+ayDOovVqov7Bttzh; 3:Uz2ZikcNxxWBHFQwCP6we+Jp7yaddNXwsJ926L9Bhm7CPYzemZ3HcviwPswUd55cV2I6jBNx1aw07r2b4sOby6/IVOTX7/vE44tRvKVNLITn6L3MI6HjH9xPJy2RJJjR; 25:HkgNXQ7mSBh3JFILOtBuow9pfu4CmIQ52goghLdmJ5SaFCu46TqIVf5cjukn0kBqknV4t8qDMMsy5LD8vim1o0ymjFutOk2A3pXtpViK79c4VX7OfN3+k5qLGi51x0XH2wEv4Qz4HWh1crp9T4BUFgxx1yfwcDVZ5YD2ws2XA3fmnikFlzE9A/AG4AVhYfGJfxu9JR9gg5szaGjKj1A0mfFDqUp9xiE+LqEfwv8UaPffNDGrnQr3YVI8xI7G3kxIQHdX2IhBHKOPo3jIrZPDXSOcCZPDzPty50WctTUZPAO90rp6eImjOVk+xb1gLTvg95KExgWnWzNLRM6FCVuhnKdtX6xzJZME9kIoCKKC10gUK9F3PHPzRu31Hx/kpWgxOlUt++4uMt58YLV8+V5aWCsV7S0nmXXvPTJ6TexIM2PfH8e4KtKPbYmMtrbWtOj75X7UkwKC+5xaq8QgmHWidFHFWpk7u0tc+DB7rTF1H0t/jv0cWBD3pmRAsVqeBUUnAlb10gNx87Ibs/nRoUp4bBXqBi1gxX2Cbgk7IouLuGdLpSunhl0lyCBGA+EZUnKD2w/bdoXr/gYIWnwJdB+5lSEsljev13NfwLwrI6hBeSA= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR0401MB1798; X-Microsoft-Exchange-Diagnostics: 1; DB5PR0401MB1798; 20:g2oJo4SOnhde3bF+54Jg47iSUbo+VPT7DLOTSsKhcpt3ZQDMF3uRgsj7h5V+bXYtNSmo1BemaVNatrDqOvZg23AmZoKPwr42vliaLF/2/CYL7qwqvv8lv00ko/z4TzG+DvuLCH6fYdH2DG0VeqAbyXqv/mtvKKORRHmCeWHWk6BMcrB5voyB0gdC8Mtbrtj8ajBaB+auma0gmraDamHabCW570HQIDn06NDPJ+RGrIDz6RBQ1Vysh+9VvCVQZ+17LMoMAtq5bPq35O4ALRqi3IUY8oI1dxpwi7zK50JrBN24Dg3q1JO1HIo14EsXdVdSa7NdgyODwB2gPDHgHBVRVWO1ERe1Zmoj9L+E65Z2GAhM0nPzfI8BR82fd099RhI3SaWbnKKvyOGa+01VrThKp+3poSE9rHW9ZE0XkCK2otVR5ZuGQ6F8dfk1IZhaU56krW9OAlEdTSVeMNSQKvpvZuPBHLD82qT3nlfCH22YpQWN+dMKl+TAfX/9E/rC8uTK; 4:rw2S22cWjafIIKww1hw0G2/QQdnurhkJnRkDKdFLWdRIjEudWtO98427hTzAOf/mXCyzIpfhDvW9ryskeysrqrAJMrvsd9ccRaxMs7T5gEDxfH0Kttx0FuWWOAXsFruqLORneBsYo6jNOg6b0joFFNqljSXPuuk8htWckCS/PwXrFxm4mBzAk5eCXGTzsnGxs0VppRLmC4ZPvsbtIVunmdt21vhCaeSWLUoBpJbHuREF0y4zAMG3hRtSxH4gGRH53yoHzog4BSPiJiSdBtd2AvdGCl48UO/3ZDafYRwzIPC6O29Fgt8OVtewlsKteqsAjiKiIqbbrFGsGtfUJoucZAzewRlPey3rdExAtb6UuA+/NwjzZsf9zTbLc3WM56rG X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046); SRVR:DB5PR0401MB1798; BCL:0; PCL:0; RULEID:; SRVR:DB5PR0401MB1798; X-Forefront-PRVS: 0902222726 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(81166005)(5003940100001)(5004730100002)(86362001)(5008740100001)(92566002)(2201001)(50226001)(229853001)(3846002)(586003)(33646002)(42186005)(6116002)(77096005)(2906002)(189998001)(50986999)(48376002)(4326007)(1096002)(50466002)(66066001)(36756003)(47776003)(19580395003)(19580405001)(5001770100001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR0401MB1798; H:chopperman.am.freescale.net; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; DB5PR0401MB1798; 23:X4egsEWZfD1NyvrP6HsDWUIuG83kzROQdQ5B3yT0PlVY0Ib2fXBlYoeAjjv5dDomaOJTHUV8U2sUlJOMp4cLabdHPDcz/U2lQUJixxNicQwZ7xPGrVW7sKgy/7UM/Aoj6jrvScdiZbnxHCte0bzTGIs39OhgUb9EhLQo3bjWTx6mkn9wmpBaoWZIStw/8KXi/HogWD/CTNff79Wp76nHozPJBaQ4R8pZ7L6LbYJOiPZWvFd2J/ky+y86WbB6Sl21B2pJqF6GETX4wUxiKR5gQBBJx3hd+dghypmBcPbsXmbytrMjMPT9WEl26XVO1MB3ZVtXnDS1wRgJZMoyl5SRZpgyvA+r7Nb3ewtVsjbNkiWqgUwHR0Tysp18b6gXiB37/2Icklu5GB7y5i/kPra8d8ImkQQUip4Br663QyxX3q7obVGGB4g2WE947RLL9BAR73ckLCRRy0EnuXJJe7GKo69+F3CFMIjv9QIMUKMoPJu6iUSSo9rc+RmizfLhWtY+9nRtIu2+3fSoGylHm56c9hPV2qDsf712F18B+U7TJRrizWpoLAJ7/0Y1SwovI23h4u4GvohKOG83GDyk6e4hewv4ZbqrUQAcXAUDYhNbXVVv65pGEk+tjn70pWs8OlhTmmhm6N4HMQFQizHrTlfXqdo69+DHYr0irXnHyThWR1+Vcd6EVP2F3zDpHLAoZt0LH8v063YDCnsVie6YW/uw3mKoXOC6wd6nWeY1KaOkAVruzVEJ9nukzfRPsn7AexIxXSom2/Av9EeM7l1p02Jc4fELzGIVbzkKTfuYNUfOb+haPJXzUe2ELpRJJ8NVJdClVY5TFevyN+ZYydh/aT/dFX+YshQC0tdA5C1O1KLeZbk= X-Microsoft-Exchange-Diagnostics: 1; DB5PR0401MB1798; 5:KJyBAdX+npYc6a2fDqIyGR9xJD9ryM+JCnBKUEuOImPOulkR5mAjUJc2r3o1oL0kkRmOKON1nlR5jJhcZC/lmRo561RjS9ppYcrrLS8USzv7Qi6Rz/NNCail/kLVgaXgIhmd66+3NoLsHw1J6w9iwg==; 24:xD3Sidf77CRZYRIgi2IksMI7G6PM6B8hCEfI/pWooTZ0YNJuiCsBt06tfK8O6zJjY4lm4X6Jny/2GxAkuC2JcNPsfEeAJiuK5NrA1QoKsWg= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2016 17:42:14.3238 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0401MB1798 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160404_104239_561058_AB82A0EE X-CRM114-Status: UNSURE ( 7.26 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [104.47.2.88 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [104.47.2.88 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org fix the raw_buffer pointer double free issue found by coverify. Signed-off-by: Han Xu --- drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c index 8122c69..dcb60b0 100644 --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c @@ -797,6 +797,7 @@ static void gpmi_free_dma_buffer(struct gpmi_nand_data *this) this->cmd_buffer = NULL; this->data_buffer_dma = NULL; + this->raw_buffer = NULL; this->page_buffer_virt = NULL; this->page_buffer_size = 0; }