From patchwork Fri Jan 29 19:25:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 575811 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 444551402D2 for ; Sat, 30 Jan 2016 06:28:06 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=dSy7qORP; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aPEgx-0005w8-5H; Fri, 29 Jan 2016 19:26:47 +0000 Received: from mail-pa0-x244.google.com ([2607:f8b0:400e:c03::244]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aPEgg-0005b0-HA for linux-mtd@lists.infradead.org; Fri, 29 Jan 2016 19:26:32 +0000 Received: by mail-pa0-x244.google.com with SMTP id gi1so4003190pac.2 for ; Fri, 29 Jan 2016 11:26:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=bD6AaBI05OMK50nC/jAetXbaquwqYhzvmO3wdBjbHn0=; b=dSy7qORPwCsFYWJTSr88V+lS8sV+zqTGZk2lZu2grB1GHWX7piIytTWO4QSjFBGl0s uxI0jssiy23RppeoRaWP7aRU/ZHwYUINEFA7pTAoHk8Y32QgNR4aLcOpWbmDfTiRIc24 eY8UmAxgdTpOi1yIsYR/Xqr5YYLLW+f4eqF06aKTDKiUNw2EXkAn0jClKscOpVgAmsUK z9Q9rPSAKOYOMUIGk7w9GC7r5Y5IugghQ0M6Eh+i5E2pTx51/VvPyXAKND79XuMNkWWO 9dPoCpGDFdM7FHgUrJres5PEsjNL0uK+zY5eEU5s8Qyen91Guyv7/2BRTp4qxf4dXIri 6GtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=bD6AaBI05OMK50nC/jAetXbaquwqYhzvmO3wdBjbHn0=; b=iqW02m/TW5krVbil63pvaLLAW3b/qzbo56gxf+yWLTZ26xr2ZIe33mffOkYKZIHNLI 8h7gOMVjbmD50YEP0FVDu6TxuqnvDw75On9COTyz4kxcQBeR7Hf7E2JouEw+AxGQjPt8 VvX+tWTiPTCSffvcGzTaM8+OPH+gGCAM0I1CaVDAdqw9KhmQE5OKMRtTNxPPLYGQ4xjX O/yGsLxoQvw8MCV72vuLLgDaN5xovnzx67SUSA0/YzBSn61CjNFaSBivpaBFT65FXdJq FNj5wi5djbjc7T95xQsIOLQt1EPLmdUsGbMBfJtZQJmJfJxUi7gc1b9swpkfMECV8pPf jSoQ== X-Gm-Message-State: AG10YORIAjioSMbce2MFfsXWGe+wAgL7QJ4y5zo1NuE2xyy2M1hDtFDAKl3R1Nyi9EytDQ== X-Received: by 10.67.24.3 with SMTP id ie3mr15971237pad.23.1454095569934; Fri, 29 Jan 2016 11:26:09 -0800 (PST) Received: from ban.mtv.corp.google.com ([172.22.64.120]) by smtp.gmail.com with ESMTPSA id dg12sm25264001pac.47.2016.01.29.11.26.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 29 Jan 2016 11:26:09 -0800 (PST) From: Brian Norris To: Subject: [PATCH v2 1/8] mtd: spi-nor: wait for SR_WIP to clear on initial unlock Date: Fri, 29 Jan 2016 11:25:30 -0800 Message-Id: <1454095537-130536-2-git-send-email-computersforpeace@gmail.com> X-Mailer: git-send-email 2.7.0.rc3.207.g0ac5344 In-Reply-To: <1454095537-130536-1-git-send-email-computersforpeace@gmail.com> References: <1454095537-130536-1-git-send-email-computersforpeace@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160129_112630_781154_696E0678 X-CRM114-Status: UNSURE ( 9.29 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2607:f8b0:400e:c03:0:0:0:244 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (computersforpeace[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Boris Brezillon , djkurtz@chromium.org, =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , linux-kernel@vger.kernel.org, Bayi Cheng , Stas Sergeev , Ezequiel Garcia , Brian Norris MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Fixup a piece leftover by commit 32321e950d8a ("mtd: spi-nor: wait until lock/unlock operations are ready"). That commit made us wait for the WIP bit to settle after lock/unlock operations, but it missed the open-coded "unlock" that happens at probe() time. We should probably have this code utilize the unlock() routines in the future, to avoid duplication, but unfortunately, flash which need to be unlocked don't all have a proper ->flash_unlock() callback. Signed-off-by: Brian Norris Cc: Stas Sergeev Reviewed-by: Ezequiel Garcia --- v2: no change drivers/mtd/spi-nor/spi-nor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index ed0c19c558b5..ef89bed1e5ea 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -1236,6 +1236,7 @@ int spi_nor_scan(struct spi_nor *nor, const char *name, enum read_mode mode) JEDEC_MFR(info) == SNOR_MFR_SST) { write_enable(nor); write_sr(nor, 0); + spi_nor_wait_till_ready(nor); } if (!mtd->name)