From patchwork Fri Jan 15 10:34:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Romain Izard X-Patchwork-Id: 568019 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id E571F140BFF for ; Fri, 15 Jan 2016 21:37:48 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=InmOdzO9; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aK1jh-0004Kc-2O; Fri, 15 Jan 2016 10:36:05 +0000 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aK1jT-000490-FG for linux-mtd@lists.infradead.org; Fri, 15 Jan 2016 10:35:52 +0000 Received: by mail-wm0-x242.google.com with SMTP id b14so2141721wmb.1 for ; Fri, 15 Jan 2016 02:35:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=AOW1ZNC3tS/SceQ+TtSoSaGsCeMG1WitOChorNdo3Tk=; b=InmOdzO9uvXQMmn5QmldGG2+dAlurUZ0DKBBjLdiOebfRjO3C4jJd9VBk123DQFecq yULqW0/uNTlySi//KvZOJN5E7LheMPumQmdHdYZpKz2NAaRei+fjPNYzWuJgHxktJq+0 WPXx/6/zuVyZm14G9rfA+KB1ZpiWm45hvS+2ZfRcGAdnrpWC6xMDa7FQt1PylMOtpM86 2j/oH2ToQAjRf8PdbWDltMOo97QYk/axudrUQixsSb7nqlKmUre5EGzEWEEA4rczpG09 /3mSRNR6IWPHuEs4IJQ/WGbGNIUv6qQiifqEUiesz18B6jgtd1eBkxMQQtiCGkApmSvR UAVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AOW1ZNC3tS/SceQ+TtSoSaGsCeMG1WitOChorNdo3Tk=; b=iZ3Ch5YiDnY2r7GcieWIqaVidPFvNKFJUTlkj47Ne6ldfDhlguyDX7SyBEptoORlPv 2HUByqNZBv1AR5JfKtf3wgK0r2mb9HGGJSMde/dcISDn4MehWVxmQC6VptBKBYTWK4Ld rpGcrgZEA8M3zU5uywD94tNrt2DdKN1PqdNpn+UTvwNbhG8m6nz1XFcSLLk0UGogtier ATfu4oEyaLxlbuiifDPwmFvoStBCB8QaX38rM+Cn+EOC/v9mXkMowgN0Q858ADImCn0i AekntB6OSAsptf/f18VVS3tZUSjb3HDo6IrYafydj+eLKpEpIwKQsnShPW07mgKW7uqB btCg== X-Gm-Message-State: AG10YOSKIqpnWnwQIBMbNp4R3/C5kZAe2+0pji0VFH+03/JsNHteTa6As5JV0GLHu4594Q== X-Received: by 10.28.230.74 with SMTP id d71mr2392625wmh.97.1452854129896; Fri, 15 Jan 2016 02:35:29 -0800 (PST) Received: from localhost.localdomain (ram94-11-88-187-113-157.fbx.proxad.net. [88.187.113.157]) by smtp.gmail.com with ESMTPSA id w1sm1945189wmd.2.2016.01.15.02.35.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 15 Jan 2016 02:35:28 -0800 (PST) From: Romain Izard To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Subject: [PATCH v2 2/8] mtd: atmel_nand: Simplify error messages Date: Fri, 15 Jan 2016 11:34:56 +0100 Message-Id: <1452854102-6125-3-git-send-email-romain.izard.pro@gmail.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1452854102-6125-1-git-send-email-romain.izard.pro@gmail.com> References: <1452854102-6125-1-git-send-email-romain.izard.pro@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160115_023551_720029_973B6344 X-CRM114-Status: GOOD ( 12.76 ) X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2a00:1450:400c:c09:0:0:0:242 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (romain.izard.pro[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Josh Wu , Romain Izard , Nicolas Ferre , Yang Wenyou MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The error messages when the ECC controller is misconfigured through the device tree are very precise. As a result they can (and will) get obsolete when new revisions of the controller appear. Simplify them before adding the support for the new revision. Signed-off-by: Romain Izard --- v2: split from the 32-bit ECC enabling patch drivers/mtd/nand/atmel_nand.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c index b8abf14e1298..6e548fc3ab7b 100644 --- a/drivers/mtd/nand/atmel_nand.c +++ b/drivers/mtd/nand/atmel_nand.c @@ -1549,7 +1549,7 @@ static int atmel_of_init_port(struct atmel_nand_host *host, if ((val != 2) && (val != 4) && (val != 8) && (val != 12) && (val != 24)) { dev_err(host->dev, - "Unsupported PMECC correction capability: %d; should be 2, 4, 8, 12 or 24\n", + "Required ECC strength not supported: %u\n", val); return -EINVAL; } @@ -1559,7 +1559,7 @@ static int atmel_of_init_port(struct atmel_nand_host *host, if (of_property_read_u32(np, "atmel,pmecc-sector-size", &val) == 0) { if ((val != 512) && (val != 1024)) { dev_err(host->dev, - "Unsupported PMECC sector size: %d; should be 512 or 1024 bytes\n", + "Required ECC sector size not supported: %u\n", val); return -EINVAL; }