| Message ID | 1447289272-131828-1-git-send-email-computersforpeace@gmail.com |
|---|---|
| State | Accepted |
| Commit | 938672338991ac8bef5cb025b187ab8d6230ac6c |
| Headers | show |
On Wed, 11 Nov 2015 16:47:52 -0800 Brian Norris <computersforpeace@gmail.com> wrote: > It's easier to guarantee we've cleared out all unused fields with > memset() than by manually initializing each field. > > Signed-off-by: Brian Norris <computersforpeace@gmail.com> Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com> > --- > I hit this while testing out the added 'of_node' field: > > http://patchwork.ozlabs.org/patch/538838/ > > drivers/mtd/mtdpart.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c > index c2b6e967a160..3ace53342fd2 100644 > --- a/drivers/mtd/mtdpart.c > +++ b/drivers/mtd/mtdpart.c > @@ -597,11 +597,10 @@ int mtd_add_partition(struct mtd_info *master, const char *name, > if (length <= 0) > return -EINVAL; > > + memset(&part, 0, sizeof(part)); > part.name = name; > part.size = length; > part.offset = offset; > - part.mask_flags = 0; > - part.ecclayout = NULL; > > new = allocate_partition(master, &part, -1, offset); > if (IS_ERR(new))
On Thu, Nov 12, 2015 at 09:52:19AM +0100, Boris Brezillon wrote: > On Wed, 11 Nov 2015 16:47:52 -0800 > Brian Norris <computersforpeace@gmail.com> wrote: > > > It's easier to guarantee we've cleared out all unused fields with > > memset() than by manually initializing each field. > > > > Signed-off-by: Brian Norris <computersforpeace@gmail.com> > > Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com> Pushed to l2-mtd.git/next
diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c index c2b6e967a160..3ace53342fd2 100644 --- a/drivers/mtd/mtdpart.c +++ b/drivers/mtd/mtdpart.c @@ -597,11 +597,10 @@ int mtd_add_partition(struct mtd_info *master, const char *name, if (length <= 0) return -EINVAL; + memset(&part, 0, sizeof(part)); part.name = name; part.size = length; part.offset = offset; - part.mask_flags = 0; - part.ecclayout = NULL; new = allocate_partition(master, &part, -1, offset); if (IS_ERR(new))
It's easier to guarantee we've cleared out all unused fields with memset() than by manually initializing each field. Signed-off-by: Brian Norris <computersforpeace@gmail.com> --- I hit this while testing out the added 'of_node' field: http://patchwork.ozlabs.org/patch/538838/ drivers/mtd/mtdpart.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)