From patchwork Sun Oct 28 07:19:01 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 194652 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 7CF622C008B for ; Sun, 28 Oct 2012 18:21:26 +1100 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TSN9x-0001K5-SP; Sun, 28 Oct 2012 07:19:49 +0000 Received: from mail-da0-f49.google.com ([209.85.210.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TSN9p-0001JB-O1 for linux-mtd@lists.infradead.org; Sun, 28 Oct 2012 07:19:43 +0000 Received: by mail-da0-f49.google.com with SMTP id q27so1746305daj.36 for ; Sun, 28 Oct 2012 00:19:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=FruuzVK96IyleOp5IuFex0zlw+i5lMkul+RbkbwFsCY=; b=kQBGeVLzX2IToJZIz1wPdio4X0vrt0VJw+ej91fslu2p6aA6sqP2pLu2rsW2y+K3ug 1NPD8ZKPwEGyEDpM04ig0C+X7ENWEvmA4iHChRlDqTfyAOXR3BWSwh8d+y+MxwzbY1L4 wkEqGhO77jYunvM8L7pW2JgeJ9YSYa0Rcs5Tu57hemiP757ER993kAhR0yyo9K2jwd4Y B/WVGGRErdx8fFee9BAl+Ox5UbV9Oywo2dqIgXh7GnkJ69pnSedOOkKO2nXyQOx3raCe haj6ojCv6Cxtqmvmv6eUH4MiHxJK/rGsNTv8a5crD+8OPtViwSzAUaxOJupGua0qccNQ /GiQ== Received: by 10.68.201.6 with SMTP id jw6mr82730785pbc.149.1351408780898; Sun, 28 Oct 2012 00:19:40 -0700 (PDT) Received: from localhost.localdomain (p1120-ipbf2201hodogaya.kanagawa.ocn.ne.jp. [123.220.186.120]) by mx.google.com with ESMTPS id lb4sm3961166pbc.6.2012.10.28.00.19.39 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 28 Oct 2012 00:19:40 -0700 (PDT) From: Akinobu Mita To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: [PATCH 4/9] mtd: nandsim: use random32_get_bytes Date: Sun, 28 Oct 2012 16:19:01 +0900 Message-Id: <1351408746-8623-4-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1351408746-8623-1-git-send-email-akinobu.mita@gmail.com> References: <1351408746-8623-1-git-send-email-akinobu.mita@gmail.com> X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (akinobu.mita[at]gmail.com) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.210.49 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: linux-mtd@lists.infradead.org, David Woodhouse , Akinobu Mita , Artem Bityutskiy X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org This also removes unnecessary memset call which is immediately overwritten with random bytes. Signed-off-by: Akinobu Mita Cc: Artem Bityutskiy Cc: David Woodhouse Cc: linux-mtd@lists.infradead.org --- drivers/mtd/nand/nandsim.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c index a932c48..d074b4c 100644 --- a/drivers/mtd/nand/nandsim.c +++ b/drivers/mtd/nand/nandsim.c @@ -1397,10 +1397,7 @@ int do_read_error(struct nandsim *ns, int num) unsigned int page_no = ns->regs.row; if (read_error(page_no)) { - int i; - memset(ns->buf.byte, 0xFF, num); - for (i = 0; i < num; ++i) - ns->buf.byte[i] = random32(); + random32_get_bytes(ns->buf.byte, num); NS_WARN("simulating read error in page %u\n", page_no); return 1; }