From patchwork Sun Aug 26 12:06:44 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 180045 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (unknown [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 9AED22C00FD for ; Sun, 26 Aug 2012 22:08:32 +1000 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T5bcp-0007zD-TP; Sun, 26 Aug 2012 12:07:31 +0000 Received: from mail-pb0-f49.google.com ([209.85.160.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1T5bcm-0007yC-IK for linux-mtd@lists.infradead.org; Sun, 26 Aug 2012 12:07:29 +0000 Received: by pbbrq8 with SMTP id rq8so6170345pbb.36 for ; Sun, 26 Aug 2012 05:07:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=Fexfbi1V91D53DzDi0PhZga4ADsbpqQi9RTEufW0LII=; b=siA9O+NLnJHAb4NcL0HBM5znWf5uYd/4qP6U582OEvaxx7Bv3pLThswCV4zJmptAqu F+OIsGvZFOD58lfPyEibcQEYprFlqNpZsUR0ZMnPFTaw+ce1GaNnS+a4Hdw23AdNmE94 NQDm2euwIa6FdH8Wajj15rXEDxWfmsA3YiGsJTkYcHd17H2XzkrGduO2w12zshkSvkzh NYa3uA44DjSdduvZqAsMvrHvn8eo3fMP2gJpx08EKN3zfeIYtnGBVsPxQQrIrd965uPU MkxZYDV7yEnEP7cezcB0aonkZnE/BsDA8LiAvAIu/t7EXoZrz/LlCsmT9/h1EMLXuoyd /LAw== Received: by 10.66.78.73 with SMTP id z9mr23402266paw.9.1345982847696; Sun, 26 Aug 2012 05:07:27 -0700 (PDT) Received: from localhost.localdomain (p4038-ipngn701hodogaya.kanagawa.ocn.ne.jp. [114.158.195.38]) by mx.google.com with ESMTPS id uj3sm12422743pbc.39.2012.08.26.05.07.26 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 26 Aug 2012 05:07:27 -0700 (PDT) From: Akinobu Mita To: linux-mtd@lists.infradead.org Subject: [PATCH v2 2/6] mtd: mtd_nandecctest: make module_init() return an error code if test fails Date: Sun, 26 Aug 2012 21:06:44 +0900 Message-Id: <1345982808-11440-3-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 1.7.11.4 In-Reply-To: <1345982808-11440-1-git-send-email-akinobu.mita@gmail.com> References: <1345982808-11440-1-git-send-email-akinobu.mita@gmail.com> X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.160.49 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (akinobu.mita[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Artem Bityutskiy , David Woodhouse , Akinobu Mita X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Return an error code if test fails in order to detect a test case failure by invoking tests repeatedly like this: while sudo modprobe mtd_nandecctest; do sudo modprobe -r mtd_nandecctest done Signed-off-by: Akinobu Mita Cc: David Woodhouse Cc: linux-mtd@lists.infradead.org Cc: Artem Bityutskiy --- drivers/mtd/tests/mtd_nandecctest.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/tests/mtd_nandecctest.c b/drivers/mtd/tests/mtd_nandecctest.c index 4d7b171..f71ed92 100644 --- a/drivers/mtd/tests/mtd_nandecctest.c +++ b/drivers/mtd/tests/mtd_nandecctest.c @@ -66,10 +66,13 @@ static int nand_ecc_test(const size_t size) static int __init ecc_test_init(void) { - nand_ecc_test(256); - nand_ecc_test(512); + int err; - return 0; + err = nand_ecc_test(256); + if (err) + return err; + + return nand_ecc_test(512); } static void __exit ecc_test_exit(void)