From patchwork Mon May 14 12:14:40 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bastian Hecht X-Patchwork-Id: 158981 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 15FCAB703C for ; Mon, 14 May 2012 22:16:29 +1000 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1STuAj-0004iB-Od; Mon, 14 May 2012 12:14:41 +0000 Received: from mail-wi0-f169.google.com ([209.85.212.169]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1STuAe-0004h9-NU for linux-mtd@lists.infradead.org; Mon, 14 May 2012 12:14:37 +0000 Received: by wibhn14 with SMTP id hn14so3179401wib.0 for ; Mon, 14 May 2012 05:14:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=prC6Vyk5y7Zq2G883WQOVthQV9afGP7jr1aiGaoM1zg=; b=zbR1yPMVDUYG0FNFbl2pwyvzfPIPoFMb+C0bfJ6XBClGLAJmR/ouDt2WmgoywGnx/R EhRE/M82XZUUEq7cmw8x/6UulbcxFGWx178ZVnDdK6a6Nw65Ye89uYOzqfMMTU92hbEf Ifir0yh1QIkzciKNYi+Y3urRDmoEUZ+ZLwuv19apBqOvnD0q8qkqv0jG2mAGpvTa+XPq +uBVuoxZ4xsIJvwXEuu9nO5Icg5MSZOH0jUu4YGIzPGU/swXmDiZm22ezXz22ky7jVfN 5Nx7RuI0GFIPvNSZf1aXUUl7X+PcsC0EQJgfo/fG8CumdSEpT+1iMBYVCG7hxqiyIDUJ eaKQ== Received: by 10.216.145.153 with SMTP id p25mr5039712wej.112.1336997674733; Mon, 14 May 2012 05:14:34 -0700 (PDT) Received: from localhost.localdomain ([89.204.155.140]) by mx.google.com with ESMTPS id j4sm54510747wix.5.2012.05.14.05.14.33 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 14 May 2012 05:14:34 -0700 (PDT) From: Bastian Hecht To: linux-mtd@lists.infradead.org Subject: [PATCH v4 1/8] mtd: sh_flctl: Add missing iounmap() Date: Mon, 14 May 2012 14:14:40 +0200 Message-Id: <1336997687-6868-2-git-send-email-hechtb@gmail.com> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1336997687-6868-1-git-send-email-hechtb@gmail.com> References: <1336997687-6868-1-git-send-email-hechtb@gmail.com> X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.212.169 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (hechtb[at]googlemail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Bastian Hecht , magnus.damm@gmail.com, laurent.pinchart@ideasonboard.com, linux-sh@vger.kernel.org X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Add the unmapping for the error case and for the driver removal. Signed-off-by: Bastian Hecht Acked-by: Laurent Pinchart --- drivers/mtd/nand/sh_flctl.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c index aa9b8a5..a5a60ca 100644 --- a/drivers/mtd/nand/sh_flctl.c +++ b/drivers/mtd/nand/sh_flctl.c @@ -918,6 +918,7 @@ static int __devinit flctl_probe(struct platform_device *pdev) err_chip: pm_runtime_disable(&pdev->dev); + iounmap(flctl->reg); err_iomap: kfree(flctl); return ret; @@ -929,6 +930,7 @@ static int __devexit flctl_remove(struct platform_device *pdev) nand_release(&flctl->mtd); pm_runtime_disable(&pdev->dev); + iounmap(flctl->reg); kfree(flctl); return 0;