From patchwork Wed Apr 25 14:03:29 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bastian Hecht X-Patchwork-Id: 154933 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4C6CBB6FBB for ; Thu, 26 Apr 2012 00:04:53 +1000 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SN2p5-00008l-VF; Wed, 25 Apr 2012 14:03:59 +0000 Received: from mail-wg0-f49.google.com ([74.125.82.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SN2ou-000051-F0 for linux-mtd@lists.infradead.org; Wed, 25 Apr 2012 14:03:51 +0000 Received: by wgbds1 with SMTP id ds1so79461wgb.18 for ; Wed, 25 Apr 2012 07:03:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=YBW5OteNjIf+o6dlk3TRgIEeXxfD8XtliQMo9Cm70gw=; b=K9VKbwfNSbO3RELfVzt/I179BTpCNnRkKxh94HNXWpOewpirEqePi3wC360VsmN4He /OCinDjHh7UljvJsXDi085n+yXiFxNwDE383dl4jq8ucNlGXhmYcladF48wX95Rsa6lJ NIEEtpJKydbf8PFKsHgyd+A2aQ/vwySoiUvzEnV+lUBLg7xbHDzoBmQ33aXlCvqTT3IW +l4QTh6wcIBZMTT8eUyPNOhqWtFdL7WxgUWl8FyfYRXZ9++K6tpzJE5NHykscdk0AjcR D9cPLHRF1XWYO6/CfZtyRMPubYi/jTt5Aw6j74kh1juMTSAsSKriXejqekDrmxw/Zwk6 wvug== Received: by 10.180.86.132 with SMTP id p4mr6971702wiz.15.1335362625234; Wed, 25 Apr 2012 07:03:45 -0700 (PDT) Received: from localhost.localdomain ([176.74.57.22]) by mx.google.com with ESMTPS id e6sm37468234wix.8.2012.04.25.07.03.43 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 25 Apr 2012 07:03:44 -0700 (PDT) From: Bastian Hecht To: linux-mtd@lists.infradead.org, linux-sh@vger.kernel.org Subject: [PATCH v2 01/10] mtd: sh_flctl: Add missing iounmap() Date: Wed, 25 Apr 2012 16:03:29 +0200 Message-Id: <1335362618-4559-2-git-send-email-hechtb@gmail.com> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1335362618-4559-1-git-send-email-hechtb@gmail.com> References: <1335362618-4559-1-git-send-email-hechtb@gmail.com> X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [74.125.82.49 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (hechtb[at]googlemail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Brian Norris , Magnus Damm , Laurent Pichart X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Add the unmapping for the error case and for the driver removal. Signed-off-by: Bastian Hecht Acked-by: Laurent Pinchart --- drivers/mtd/nand/sh_flctl.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c index 2ee9a1b..ed86a64 100644 --- a/drivers/mtd/nand/sh_flctl.c +++ b/drivers/mtd/nand/sh_flctl.c @@ -919,6 +919,7 @@ static int __devinit flctl_probe(struct platform_device *pdev) err_chip: pm_runtime_disable(&pdev->dev); + iounmap(flctl->reg); err_iomap: kfree(flctl); return ret; @@ -930,6 +931,7 @@ static int __devexit flctl_remove(struct platform_device *pdev) nand_release(&flctl->mtd); pm_runtime_disable(&pdev->dev); + iounmap(flctl->reg); kfree(flctl); return 0;