From patchwork Fri Mar 9 11:35:47 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artem Bityutskiy X-Patchwork-Id: 146297 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2F073B6FB6 for ; Tue, 13 Mar 2012 11:09:33 +1100 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1S7FHh-0006bI-GG; Tue, 13 Mar 2012 00:08:14 +0000 Received: from casper.infradead.org ([2001:770:15f::2]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1S7Cqh-0001iH-TC for linux-mtd@merlin.infradead.org; Mon, 12 Mar 2012 21:32:13 +0000 Received: from mga14.intel.com ([143.182.124.37]) by casper.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1S5y6x-00011R-Vq for linux-mtd@lists.infradead.org; Fri, 09 Mar 2012 11:35:53 +0000 Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga102.ch.intel.com with ESMTP; 09 Mar 2012 03:35:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="116788455" Received: from blue.fi.intel.com ([10.237.72.50]) by azsmga001.ch.intel.com with ESMTP; 09 Mar 2012 03:35:30 -0800 From: Artem Bityutskiy To: Ralf Baechle Subject: [PATCH] MIPS: Kbuild: remove -Werror Date: Fri, 9 Mar 2012 13:35:47 +0200 Message-Id: <1331292947-14913-1-git-send-email-dedekind1@gmail.com> X-Mailer: git-send-email 1.7.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20120309_113552_378610_1B494C44 X-CRM114-Status: GOOD ( 16.10 ) X-Spam-Score: -5.0 (-----) X-Spam-Report: SpamAssassin version 3.3.2 on casper.infradead.org summary: Content analysis details: (-5.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dedekind1[at]gmail.com) -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [143.182.124.37 listed in list.dnswl.org] 0.0 DKIM_ADSP_CUSTOM_MED No valid author signature, adsp_override is CUSTOM_MED 0.8 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (dedekind1[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.9 NML_ADSP_CUSTOM_MED ADSP custom_med hit, and not from a mailing list Cc: linux-mips@linux-mips.org, MTD Maling List , John Crispin X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Artem Bityutskiy MIPS does not build with the standard W=1 Kbuild switch with - tested with gcc-4.6 by me and gcc-4.5 by John Crispin. The reason is that MIPS adds -Werror build option. This patch removes the option to make W=1 work. I do compile-tests for various architecture before accepting MTD patches and I have scripts which build before applying the patch, then after, and then compare 2 build logs and report about new warnings. I use W=1 to see more warnings in the logs diff. And from my perspective all platforms should build with W=1. The other way would be to fix all warnings, but there are false positives, and it is too difficult to maintain the code warning-free, so it is easier to just remove -Werror. Signed-off-by: Artem Bityutskiy --- arch/mips/Kbuild | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/arch/mips/Kbuild b/arch/mips/Kbuild index 7dd65cf..0d37730 100644 --- a/arch/mips/Kbuild +++ b/arch/mips/Kbuild @@ -1,8 +1,3 @@ -# Fail on warnings - also for files referenced in subdirs -# -Werror can be disabled for specific files using: -# CFLAGS_ := -Wno-error -subdir-ccflags-y := -Werror - # platform specific definitions include arch/mips/Kbuild.platforms obj-y := $(platform-y)