From patchwork Thu Aug 4 22:53:53 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grant Likely X-Patchwork-Id: 108583 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E19EFB6F7C for ; Fri, 5 Aug 2011 08:54:37 +1000 (EST) Received: from canuck.infradead.org ([2001:4978:20e::1]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Qp6nr-0007hk-9D; Thu, 04 Aug 2011 22:54:11 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Qp6nq-0005ug-Q0; Thu, 04 Aug 2011 22:54:10 +0000 Received: from mail-wy0-f177.google.com ([74.125.82.177]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Qp6no-0005u7-2E for linux-mtd@lists.infradead.org; Thu, 04 Aug 2011 22:54:08 +0000 Received: by wyh11 with SMTP id 11so68315wyh.36 for ; Thu, 04 Aug 2011 15:54:02 -0700 (PDT) Received: by 10.227.202.209 with SMTP id ff17mr1152391wbb.78.1312498442097; Thu, 04 Aug 2011 15:54:02 -0700 (PDT) Received: from localhost ([109.234.204.184]) by mx.google.com with ESMTPS id ew4sm1012418wbb.25.2011.08.04.15.54.00 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 04 Aug 2011 15:54:01 -0700 (PDT) Received: by localhost (Postfix, from userid 1000) id 3A575183B74; Thu, 4 Aug 2011 23:54:00 +0100 (BST) From: Grant Likely To: David Woodhouse , Artem Bityutskiy , Russell King , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] mtd/physmap: Fix set_vpp signature in physmap_configure Date: Thu, 4 Aug 2011 23:53:53 +0100 Message-Id: <1312498433-17950-1-git-send-email-grant.likely@secretlab.ca> X-Mailer: git-send-email 1.7.4.1 X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110804_185408_263369_9A77CC64 X-CRM114-Status: GOOD ( 17.90 ) X-Spam-Score: -0.7 (/) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (-0.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [74.125.82.177 listed in list.dnswl.org] Cc: Grant Likely X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org physmap_configure() has the wrong signature for the set_vpp callback. struct physmap_flash_data expects it to accpet a platform_device pointer. However, I can't find any users of physmap_configure(), so maybe the hook should simply be removed. Signed-off-by: Grant Likely --- drivers/mtd/maps/physmap.c | 2 +- include/linux/mtd/physmap.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c index f64cee4..f2b9f5e 100644 --- a/drivers/mtd/maps/physmap.c +++ b/drivers/mtd/maps/physmap.c @@ -247,7 +247,7 @@ static struct platform_device physmap_flash = { }; void physmap_configure(unsigned long addr, unsigned long size, - int bankwidth, void (*set_vpp)(struct map_info *, int)) + int bankwidth, void (*set_vpp)(struct platform_device *, int)) { physmap_flash_resource.start = addr; physmap_flash_resource.end = addr + size - 1; diff --git a/include/linux/mtd/physmap.h b/include/linux/mtd/physmap.h index e5f21d2..25ef3ed 100644 --- a/include/linux/mtd/physmap.h +++ b/include/linux/mtd/physmap.h @@ -36,7 +36,7 @@ struct physmap_flash_data { * Board needs to specify the exact mapping during their setup time. */ void physmap_configure(unsigned long addr, unsigned long size, - int bankwidth, void (*set_vpp)(struct map_info *, int) ); + int bankwidth, void (*set_vpp)(struct platform_device *, int) ); /* * Machines that wish to do flash partition may want to call this function in