| Message ID | 20240925074903.1983601-1-erezgeva@nwtime.org |
|---|---|
| Headers | show |
| Series | mtd: spi-nor: macronix: reading SFDP by all Macronix chips | expand |
Erez Geva <erezgeva@nwtime.org> writes: > From: Erez Geva <ErezGeva2@gmail.com> > > Add reading SFDP to all Macronix chips. > All chips in the Macronix competabilites table > have a replacement chip that support SFDP. > Macronix stop producing any chip without SFDP 15 years ago. > The benefit of reading SFDP is by supporting > fater op-codes for newer chips. > > This patch do not add an all flashes support. > This patch extend the already support of SFDP to all Macronix chips. > The new chips that reuse JEDEC IDs and chips that > are absend from the Macronix competabilites table. > The patch just remove the restriction! Hi Erez Did you see the response I got to the last revision of my patch series that tries to resolve the same problem that you are adressing? https://lore.kernel.org/all/D2NGXHZ2VTK0.M0AOB4CM7MHM@kernel.org/ I think we should try go go in that direction. It sounds like it would be a simple solution that would improve the overall situation, not just for Macronix. /Esben
On Thu, 26 Sept 2024 at 09:22, Esben Haabendal <esben@geanix.com> wrote: > > Erez Geva <erezgeva@nwtime.org> writes: > > > From: Erez Geva <ErezGeva2@gmail.com> > > > > Add reading SFDP to all Macronix chips. > > All chips in the Macronix competabilites table > > have a replacement chip that support SFDP. > > Macronix stop producing any chip without SFDP 15 years ago. > > The benefit of reading SFDP is by supporting > > fater op-codes for newer chips. > > > > This patch do not add an all flashes support. > > This patch extend the already support of SFDP to all Macronix chips. > > The new chips that reuse JEDEC IDs and chips that > > are absend from the Macronix competabilites table. > > The patch just remove the restriction! > > Hi Erez > > Did you see the response I got to the last revision of my patch series > that tries to resolve the same problem that you are adressing? > > https://lore.kernel.org/all/D2NGXHZ2VTK0.M0AOB4CM7MHM@kernel.org/ As for . I agree that doing SFDP first is a better approach than mine. If Tudor Ambarus. Pratyush Yadav. Michael Walle agrees on that. Than let's do that > > I think we should try go go in that direction. It sounds like it would > be a simple solution that would improve the overall situation, not just > for Macronix. Again I agree. Doing SFDP first seems a better approach. Tudor expressed concern on sending RDSFDP as no-op to chips that do not support SFDP. I did a search on the Macronix chips that appear on the table and all of them have a new chip or a new version that uses the same JEDEC ID, that does support SFDP. If other Vendors reused all their JEDEC IDs with new chips, then sure. I did not check other Vendors, so I can not state the same on them. Erez > > > /Esben
From: Erez Geva <ErezGeva2@gmail.com> Add reading SFDP to all Macronix chips. All chips in the Macronix competabilites table have a replacement chip that support SFDP. Macronix stop producing any chip without SFDP 15 years ago. The benefit of reading SFDP is by supporting fater op-codes for newer chips. This patch do not add an all flashes support. This patch extend the already support of SFDP to all Macronix chips. The new chips that reuse JEDEC IDs and chips that are absend from the Macronix competabilites table. The patch just remove the restriction! Erez Geva (2): mtd: spi-nor: core: add manufacturer flags mtd: spi-nor: macronix: add manufacturer flags drivers/mtd/spi-nor/core.c | 9 +++++---- drivers/mtd/spi-nor/core.h | 4 ++++ drivers/mtd/spi-nor/macronix.c | 1 + 3 files changed, 10 insertions(+), 4 deletions(-)