| Message ID | 20240826094328.2991664-1-ruanjinjie@huawei.com |
|---|---|
| Headers | show |
| Series | mtd: Use for_each_child_of_node_scoped() | expand |
Hi Jinjie, ruanjinjie@huawei.com wrote on Mon, 26 Aug 2024 17:43:18 +0800: > Use scoped for_each_available_child_of_node_scoped() when iterating over > device nodes to make code a bit simpler. Why is this a resend ? Did I miss a previous iteration? Thanks, Miquèl
On 26/08/2024 11:52, Miquel Raynal wrote: > Hi Jinjie, > > ruanjinjie@huawei.com wrote on Mon, 26 Aug 2024 17:43:18 +0800: > >> Use scoped for_each_available_child_of_node_scoped() when iterating over >> device nodes to make code a bit simpler. > > Why is this a resend ? Did I miss a previous iteration? You were not cc-ed on previous iteration. I asked for proper split between subsystems and sending to maintainers, thus this resend. Although for such big patchset, I would expect some waiting time, not sending immediately. Best regards, Krzysztof
On 2024/8/26 17:52, Miquel Raynal wrote: > Hi Jinjie, > > ruanjinjie@huawei.com wrote on Mon, 26 Aug 2024 17:43:18 +0800: > >> Use scoped for_each_available_child_of_node_scoped() when iterating over >> device nodes to make code a bit simpler. > > Why is this a resend ? Did I miss a previous iteration? Hi Miquel, The previous cc list has missing some entries. > > Thanks, > Miquèl
On 2024/8/26 18:19, Krzysztof Kozlowski wrote: > On 26/08/2024 11:52, Miquel Raynal wrote: >> Hi Jinjie, >> >> ruanjinjie@huawei.com wrote on Mon, 26 Aug 2024 17:43:18 +0800: >> >>> Use scoped for_each_available_child_of_node_scoped() when iterating over >>> device nodes to make code a bit simpler. >> >> Why is this a resend ? Did I miss a previous iteration? > > You were not cc-ed on previous iteration. I asked for proper split > between subsystems and sending to maintainers, thus this resend. > > Although for such big patchset, I would expect some waiting time, not > sending immediately. Sorry, I will pay attention to it later. > > Best regards, > Krzysztof >
Hi Krzysztof, krzk@kernel.org wrote on Mon, 26 Aug 2024 12:19:07 +0200: > On 26/08/2024 11:52, Miquel Raynal wrote: > > Hi Jinjie, > > > > ruanjinjie@huawei.com wrote on Mon, 26 Aug 2024 17:43:18 +0800: > > > >> Use scoped for_each_available_child_of_node_scoped() when iterating over > >> device nodes to make code a bit simpler. > > > > Why is this a resend ? Did I miss a previous iteration? > > You were not cc-ed on previous iteration. I asked for proper split > between subsystems and sending to maintainers, thus this resend. Ok. Makes sense, and the patchset looks fine. Jinjie, please always include a changelog when you send new versions, and explanations for a RESEND. Thanks, Miquèl
On 2024/8/26 20:49, Miquel Raynal wrote: > Hi Krzysztof, > > krzk@kernel.org wrote on Mon, 26 Aug 2024 12:19:07 +0200: > >> On 26/08/2024 11:52, Miquel Raynal wrote: >>> Hi Jinjie, >>> >>> ruanjinjie@huawei.com wrote on Mon, 26 Aug 2024 17:43:18 +0800: >>> >>>> Use scoped for_each_available_child_of_node_scoped() when iterating over >>>> device nodes to make code a bit simpler. >>> >>> Why is this a resend ? Did I miss a previous iteration? >> >> You were not cc-ed on previous iteration. I asked for proper split >> between subsystems and sending to maintainers, thus this resend. > > Ok. Makes sense, and the patchset looks fine. > > Jinjie, please always include a changelog when you send new versions, > and explanations for a RESEND. Ok, thanks for the advice. > > Thanks, > Miquèl
On 2024/8/26 20:49, Miquel Raynal wrote: > Hi Krzysztof, > > krzk@kernel.org wrote on Mon, 26 Aug 2024 12:19:07 +0200: > >> On 26/08/2024 11:52, Miquel Raynal wrote: >>> Hi Jinjie, >>> >>> ruanjinjie@huawei.com wrote on Mon, 26 Aug 2024 17:43:18 +0800: >>> >>>> Use scoped for_each_available_child_of_node_scoped() when iterating over >>>> device nodes to make code a bit simpler. >>> >>> Why is this a resend ? Did I miss a previous iteration? >> >> You were not cc-ed on previous iteration. I asked for proper split >> between subsystems and sending to maintainers, thus this resend. > > Ok. Makes sense, and the patchset looks fine. Hi, Miquel, Could this series be merged, thank you! > > Jinjie, please always include a changelog when you send new versions, > and explanations for a RESEND. > > Thanks, > Miquèl
Jinjie, ruanjinjie@huawei.com wrote on Fri, 30 Aug 2024 14:34:38 +0800: > On 2024/8/26 20:49, Miquel Raynal wrote: > > Hi Krzysztof, > > > > krzk@kernel.org wrote on Mon, 26 Aug 2024 12:19:07 +0200: > > > >> On 26/08/2024 11:52, Miquel Raynal wrote: > >>> Hi Jinjie, > >>> > >>> ruanjinjie@huawei.com wrote on Mon, 26 Aug 2024 17:43:18 +0800: > >>> > >>>> Use scoped for_each_available_child_of_node_scoped() when iterating over > >>>> device nodes to make code a bit simpler. > >>> > >>> Why is this a resend ? Did I miss a previous iteration? > >> > >> You were not cc-ed on previous iteration. I asked for proper split > >> between subsystems and sending to maintainers, thus this resend. > > > > Ok. Makes sense, and the patchset looks fine. > > Hi, Miquel, > > Could this series be merged, thank you! You've sent this series on Monday, we are Friday. I answered a first time within 5h and reviewed it within 8h. So that means I will take the patchset: - when I have the time to do so - after several days to give a chance to other to review it as well - unless someone speaks up against it in a "reasonable time frame" - unless a robot that parses the patches on the mailing lists complains about it (usually within few days, up to a week). In general, a good rule of thumb is to refrain yourself from pinging within 2 weeks for non-urgent matters like this series. Thanks, Miquèl
Use scoped for_each_available_child_of_node_scoped() when iterating over device nodes to make code a bit simpler. Jinjie Ruan (10): mtd: rawnand: arasan: Use for_each_child_of_node_scoped() mtd: rawnand: cadence: Use for_each_child_of_node_scoped() mtd: rawnand: pl353: Use for_each_child_of_node_scoped() mtd: rawnand: marvell: drm/rockchip: Use for_each_child_of_node_scoped() mtd: rawnand: rockchip: Use for_each_child_of_node_scoped() mtd: rawnand: meson: Use for_each_child_of_node_scoped() mtd: rawnand: mtk: Use for_each_child_of_node_scoped() mtd: rawnand: renesas: Use for_each_child_of_node_scoped() mtd: rawnand: stm32_fmc2: Use for_each_child_of_node_scoped() mtd: rawnand: sunxi: Use for_each_child_of_node_scoped() drivers/mtd/nand/raw/arasan-nand-controller.c | 5 ++--- drivers/mtd/nand/raw/cadence-nand-controller.c | 4 +--- drivers/mtd/nand/raw/marvell_nand.c | 12 +++--------- drivers/mtd/nand/raw/meson_nand.c | 4 +--- drivers/mtd/nand/raw/mtk_nand.c | 7 ++----- drivers/mtd/nand/raw/pl35x-nand-controller.c | 5 ++--- drivers/mtd/nand/raw/renesas-nand-controller.c | 12 +++--------- drivers/mtd/nand/raw/rockchip-nand-controller.c | 5 ++--- drivers/mtd/nand/raw/stm32_fmc2_nand.c | 7 ++----- drivers/mtd/nand/raw/sunxi_nand.c | 4 +--- 10 files changed, 19 insertions(+), 46 deletions(-)