mbox series

[v2,0/6] mtd: spi-nor: spring cleaning

Message ID 20240419141249.609534-1-mwalle@kernel.org
Headers show
Series mtd: spi-nor: spring cleaning | expand

Message

Michael Walle April 19, 2024, 2:12 p.m. UTC 
It's time for some spring cleaning. Remove the oddball xilinx
flashes with non-power-of-2 page sizes.
Remove the .setup() callback, only the default callback is ever
used and it is unlikely there is need for a custom setup.

Finally, the last patch is a proposal how to deprecate flashes,
which are just detected by their id. We cannot really find out if
there are boards out there which are using a particular flash. Thus,
as a first step, we can print a warning during kernel startup. As a
second step we might introduce a kernel config option to actually
disable the flashes which has the deprecated flag.

v2:
 - remove convert_addr, I've left page_size in the info, that might
   still come in handy for future flashes as they are getting
   bigger, although let's hope they have SFDP support..
 - simplify the fast read flag handling
 - reword the commit message of the .setup() callback removal patch
 - introduce .deprecation_version and simplify the checking

Michael Walle (6):
  mtd: spi-nor: Remove support for Xilinx S3AN flashes
  mtd: spi-nor: get rid of non-power-of-2 page size handling
  mtd: spi-nor: remove .setup() callback
  mtd: spi-nor: get rid of SPI_NOR_NO_FR
  mtd: spi-nor: simplify spi_nor_get_flash_info()
  mtd: spi-nor: introduce support for displaying deprecation message

 drivers/mtd/spi-nor/Makefile   |   1 -
 drivers/mtd/spi-nor/core.c     | 208 ++++++++++++++-------------------
 drivers/mtd/spi-nor/core.h     |  15 +--
 drivers/mtd/spi-nor/everspin.c |  19 ++-
 drivers/mtd/spi-nor/xilinx.c   | 169 ---------------------------
 5 files changed, 105 insertions(+), 307 deletions(-)
 delete mode 100644 drivers/mtd/spi-nor/xilinx.c

Comments

Pratyush Yadav May 27, 2024, 3:10 p.m. UTC | #1 
Hi Michael,

On Fri, Apr 19 2024, Michael Walle wrote:

[...]

Applied the below 4 patches with minor fixups mentioned below. Since
v6.10-rc1 just came out yesterday, this should let the S3AN flash
removal get plenty of time to cook in linux-next, and give people chance
to notice any breakages.

>   mtd: spi-nor: Remove support for Xilinx S3AN flashes
>   mtd: spi-nor: get rid of non-power-of-2 page size handling

Touched up commit message a bit.

>   mtd: spi-nor: remove .setup() callback
>   mtd: spi-nor: get rid of SPI_NOR_NO_FR

s/evervision/everspin/g both in code and commit message.

These 2 patches need rework:

>   mtd: spi-nor: simplify spi_nor_get_flash_info()

This one has some comments from Tudor. I don't think those are big
blockers, but at the same time I don't think this patch needs too much
time to cook in linux-next anyway. So I will wait for a respin.

>   mtd: spi-nor: introduce support for displaying deprecation message

Same for this one. I will wait for a respin with some actual
deprecations.

Thanks for working on this!

[...]