From patchwork Wed Aug 19 18:17:27 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 508789 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 90E84140772 for ; Thu, 20 Aug 2015 04:20:37 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=zwt0t0uk; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZS7vt-0005Gb-2D; Wed, 19 Aug 2015 18:17:53 +0000 Received: from mail-oi0-x22f.google.com ([2607:f8b0:4003:c06::22f]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZS7vp-0005FL-I2 for linux-arm-kernel@lists.infradead.org; Wed, 19 Aug 2015 18:17:50 +0000 Received: by oiev193 with SMTP id v193so8216681oie.3 for ; Wed, 19 Aug 2015 11:17:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=XgTQMaCK12BxMWJe0iYUq3jXPM51yR1wCSkpDUjudqw=; b=zwt0t0ukFGw//q8rph3ydVr0g6ecDKs8kguMVgA01EQsCYwZOp5Q1Et73paF5kOIVA VceXaQPv1nsGeKAHS0jDRa0mRF11nWunzLdNzSWLBvftZPmHlzFLHHSb4WB0DynisRs3 r4AFgHQLKBpWygT+dka5QO1QzbCrO5lbrkwLVeun5RYbdw8mIjoeoW/SyPuHJdfmUMWl 7/g9PwuNbhU9f0VfId+LFoVklqzC7XtfqqGnBhprGHyvAjqEtyAlIu51HXliwQMEZD0A 9ErtvkCpHIK0Z57YlsM5XpbG36vRAH6BzP8WamDBLzs6iNn2KBMiq1/YhLwV55Vdmmtz E4hQ== MIME-Version: 1.0 X-Received: by 10.202.219.67 with SMTP id s64mr10565232oig.25.1440008247560; Wed, 19 Aug 2015 11:17:27 -0700 (PDT) Received: by 10.202.197.13 with HTTP; Wed, 19 Aug 2015 11:17:27 -0700 (PDT) In-Reply-To: References: <1439311351-5268-1-git-send-email-shawnguo@kernel.org> <20150818201416.GA4732@localhost> Date: Wed, 19 Aug 2015 15:17:27 -0300 Message-ID: Subject: Re: [GIT PULL 1/3] ARM: imx: soc updates for 4.3 From: Fabio Estevam To: Olof Johansson X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150819_111749_644379_648DFD16 X-CRM114-Status: GOOD ( 14.11 ) X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (festevam[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2607:f8b0:4003:c06:0:0:0:22f listed in] [list.dnswl.org] X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "arm@kernel.org" , Shawn Guo , Sascha Hauer , "linux-arm-kernel@lists.infradead.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org Hi Olof, On Wed, Aug 19, 2015 at 2:55 PM, Olof Johansson wrote: > It looks like these changes broke ARM allmodconfig: > > arch/arm/mach-imx/built-in.o: In function `ksz8081_phy_fixup': > :(.text+0x8bcc): undefined reference to `mdiobus_write' > :(.text+0x8bf0): undefined reference to `mdiobus_write' > :(.text+0x8c28): undefined reference to `mdiobus_write' > :(.text+0x8c4c): undefined reference to `mdiobus_write' > arch/arm/mach-imx/built-in.o: In function `imx6ul_init_machine': > :(.init.text+0xa714): undefined reference to `phy_register_fixup_for_uid' > > Whole output is at: > > http://arm-soc.lixom.net/buildlogs/arm-soc/v4.2-rc2-861-gdb5c5fd/buildall.arm.allmodconfig.log.failed > > Please send an incremental fix (or I can drop this branch if you need > more time). Does this fix it? --- a/arch/arm/mach-imx/mach-imx6ul.c +++ b/arch/arm/mach-imx/mach-imx6ul.c @@ -45,7 +45,9 @@ static int ksz8081_phy_fixup(struct phy_device *dev) static void __init imx6ul_enet_phy_init(void) { - phy_register_fixup_for_uid(PHY_ID_KSZ8081, 0xffffffff, ksz8081_phy_fixup); + if (IS_BUILTIN(CONFIG_PHYLIB)) + phy_register_fixup_for_uid(PHY_ID_KSZ8081, 0xffffffff, + ksz8081_phy_fixup); }