From patchwork Tue Dec 6 11:00:12 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 129615 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 5B17B1007D4 for ; Tue, 6 Dec 2011 22:03:11 +1100 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1RXsl1-0002y1-Iy; Tue, 06 Dec 2011 11:00:19 +0000 Received: from mail-fx0-f49.google.com ([209.85.161.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1RXskx-0002xT-D2 for linux-arm-kernel@lists.infradead.org; Tue, 06 Dec 2011 11:00:16 +0000 Received: by fabs1 with SMTP id s1so2379305fab.36 for ; Tue, 06 Dec 2011 03:00:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=xEfOTDcQkhJM/Uc+leAKqhP1g+vyoVPJPSoc9OuD0+8=; b=st/2SLyilGk7fm8Nyn/ed5ObxYmbvov+x0co/geJfoW3AL/NhtEv5BFTVdPLHxsPqa ZlGniN3Ei+zoNf0e4qYocdWctj6RDUMbfyaFZTc+fPTXqPIE4II0JOEVPHs9lQHA1RbG vxxDSNo/Ep42W3Ua7rwqS+I3A6pQi0tf+nI9k= MIME-Version: 1.0 Received: by 10.227.59.205 with SMTP id m13mr10690370wbh.28.1323169212500; Tue, 06 Dec 2011 03:00:12 -0800 (PST) Received: by 10.223.74.2 with HTTP; Tue, 6 Dec 2011 03:00:12 -0800 (PST) In-Reply-To: <20111206104654.GN14542@n2100.arm.linux.org.uk> References: <20111202192618.GC3037@localhost.localdomain> <1322867573.11728.22.camel@pasglop> <20111205161157.GA27550@localhost.localdomain> <20111205180253.GB29812@localhost.localdomain> <20111205192605.GD29812@localhost.localdomain> <20111206093709.GB2274@linaro.org> <20111206104654.GN14542@n2100.arm.linux.org.uk> Date: Tue, 6 Dec 2011 12:00:12 +0100 X-Google-Sender-Auth: NRkNOgXUSxJgiVfPyYJJ9LwuDhM Message-ID: Subject: Re: [PATCH] ata: Don't use NO_IRQ in pata_of_platform driver From: Geert Uytterhoeven To: Russell King - ARM Linux X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (geert.uytterhoeven[at]gmail.com) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.161.49 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Nicolas Pitre , Stephen Rothwell , Dave Martin , Pawel Moll , Benjamin Herrenschmidt , devicetree-discuss@lists.ozlabs.org, LKML , Jeff Garzik , linux-ide@vger.kernel.org, Randy Dunlap , linux-next@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Anton Vorontsov , Andrew Morton , Linus Torvalds , Ingo Molnar , Alan Cox X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org On Tue, Dec 6, 2011 at 11:46, Russell King - ARM Linux wrote: > But.. let's make one thing clear: Alan Cox and Linus have been going on > about how IRQ0 should not be used.  Let's be crystal clear: even x86 > uses IRQ0.  It happens to be the PIC timer, and that gets claimed early > on during the x86 boot.  So please don't tell me that x86 avoids IRQ0. > It doesn't.  It just happens that x86 never shows IRQ0 to anything but > the i8253 PIC driver. It's shown in /proc/interrupts due to a "bug" in show_interrupts(). The (gmail damaged) patch below fixes this bug. From 46f51a2d42548358868a34df00c2a4e47bbdf691 Mon Sep 17 00:00:00 2001 From: Geert Uytterhoeven Date: Tue, 6 Dec 2011 11:55:05 +0100 Subject: [PATCH] /proc/interrupts: irq zero is invalid As zero is an invalid irq number, show_interrupts() should not try to print it. Just return after printing the header for i == 0. Signed-off-by: Geert Uytterhoeven --- kernel/irq/proc.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c index 4bd4faa..5b8bbf0 100644 --- a/kernel/irq/proc.c +++ b/kernel/irq/proc.c @@ -439,6 +439,7 @@ int show_interrupts(struct seq_file *p, void *v) for_each_online_cpu(j) seq_printf(p, "CPU%-8d", j); seq_putc(p, '\n'); + return 0; } desc = irq_to_desc(i);