From patchwork Mon Nov 14 04:21:28 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eric Miao X-Patchwork-Id: 125467 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C65B1B71FB for ; Mon, 14 Nov 2011 15:24:24 +1100 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1RPo3O-0006Gr-15; Mon, 14 Nov 2011 04:21:54 +0000 Received: from mail-vx0-f177.google.com ([209.85.220.177]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1RPo3K-0006Gl-Mu for linux-arm-kernel@lists.infradead.org; Mon, 14 Nov 2011 04:21:51 +0000 Received: by vcge1 with SMTP id e1so6137441vcg.36 for ; Sun, 13 Nov 2011 20:21:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=iKjpOe92J0FZ6db1Aba8NJabgJVNKU9m22k0tXtww7M=; b=QjN7HiAcgpLyWz/aOSEepbAFGfN4PY1l0u861GzPVz0ZwM3nl24Po0RpiTzPBytSxF UfU2m+W8LXIO14qC8SKnWUlrN+VpciliAc3Mdo89+gaKLykHzQxs3NBOXd3ZUTtCsH5W 36h2bqUsNx8OOc1gRfcj69CwcFBr8C4SSPM9g= Received: by 10.52.37.165 with SMTP id z5mr32083585vdj.117.1321244509081; Sun, 13 Nov 2011 20:21:49 -0800 (PST) MIME-Version: 1.0 Received: by 10.52.112.131 with HTTP; Sun, 13 Nov 2011 20:21:28 -0800 (PST) In-Reply-To: <4EBD4733.4010801@einfochips.com> References: <1321013994-6443-1-git-send-email-eric.y.miao@gmail.com> <4EBD4733.4010801@einfochips.com> From: Eric Miao Date: Mon, 14 Nov 2011 12:21:28 +0800 Message-ID: Subject: Re: [PATCH] ARM: pxa168/gplugd: add the correct SSP device To: Tanmay Upadhyay X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (eric.y.miao[at]gmail.com) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.177 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: linux-arm-kernel X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org On Sat, Nov 12, 2011 at 12:02 AM, Tanmay Upadhyay wrote: > > > On Friday 11 November 2011 05:49 PM, Eric Miao wrote: >> >> There is no SSP0, but SSP2 is used on gplugd. >> >> Cc: Tanmay Upadhyay >> Signed-off-by: Eric Miao >> --- >>  arch/arm/mach-mmp/gplugd.c |    2 +- >>  1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/arch/arm/mach-mmp/gplugd.c b/arch/arm/mach-mmp/gplugd.c >> index 6915656..0469c74 100644 >> --- a/arch/arm/mach-mmp/gplugd.c >> +++ b/arch/arm/mach-mmp/gplugd.c >> @@ -182,7 +182,7 @@ static void __init gplugd_init(void) >> >>        /* on-chip devices */ >>        pxa168_add_uart(3); >> -       pxa168_add_ssp(0); >> +       pxa168_add_ssp(2); >>        pxa168_add_twsi(0, NULL, ARRAY_AND_SIZE(gplugd_i2c_board_info)); >> >>        pxa168_add_eth(&gplugd_eth_platform_data); > > Hi Eric, > > HDMI chip (TDA9981A) on gplugD gets audio data from SSP0 - used as I2S. Page > # 7 of [1] & page # 1 & 3 of [2] indicates this. Shouldn't this be SSP1 instead, if following the public PXA168 software manual (there is no SSP0, and the existing code doesn't suppport it) > SSP2 is also used on gplugD > as SPI to talk to the NOR flash. If ignoring this port at this moment, how about the patch below? ARM: pxa168/gplugd: add the correct SSP device There is no SSP0, but SSP1 is used on gplugd as an I2S port. Cc: Tanmay Upadhyay Signed-off-by: Eric Miao diff --git a/arch/arm/mach-mmp/gplugd.c b/arch/arm/mach-mmp/gplugd.c index 6915656..4665767 100644 --- a/arch/arm/mach-mmp/gplugd.c +++ b/arch/arm/mach-mmp/gplugd.c @@ -182,7 +182,7 @@ static void __init gplugd_init(void) /* on-chip devices */ pxa168_add_uart(3); - pxa168_add_ssp(0); + pxa168_add_ssp(1); pxa168_add_twsi(0, NULL, ARRAY_AND_SIZE(gplugd_i2c_board_info)); pxa168_add_eth(&gplugd_eth_platform_data);