From patchwork Wed Sep 28 15:21:05 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Linus Torvalds X-Patchwork-Id: 116820 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4C19D1007D1 for ; Thu, 29 Sep 2011 01:21:40 +1000 (EST) Received: from canuck.infradead.org ([2001:4978:20e::1]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1R8vwx-0004h9-Li; Wed, 28 Sep 2011 15:21:31 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1R8vwx-0003ba-A1; Wed, 28 Sep 2011 15:21:31 +0000 Received: from mail-ww0-f49.google.com ([74.125.82.49]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1R8vwt-0003bD-M9 for linux-arm-kernel@lists.infradead.org; Wed, 28 Sep 2011 15:21:29 +0000 Received: by wwp14 with SMTP id 14so5870810wwp.18 for ; Wed, 28 Sep 2011 08:21:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=gV/YNLKlktbGb+E6uRhBf/YMJzmMgh6d53IcqXHBMdQ=; b=JM3ofsn/gu9vErYS3M5JxhzQja5ae231vOGE3tTv9VCJjFofL1WotZrtNAGfLC9lF3 5srHw5YVQOf5pUETeeJ4otGpySk9JSk9vviUg7L8FLDbrxMxK5OMRGSK0JFI6EmusUxO PgsF/1DvDKhBB8KOeIepTMd02gFfEEbZ3ZaSM= Received: by 10.216.176.212 with SMTP id b62mr2520575wem.63.1317223285375; Wed, 28 Sep 2011 08:21:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.11.12 with HTTP; Wed, 28 Sep 2011 08:21:05 -0700 (PDT) In-Reply-To: <20110928120630.GB9456@netboy.at.omicron.at> References: <20110928120630.GB9456@netboy.at.omicron.at> From: Linus Torvalds Date: Wed, 28 Sep 2011 08:21:05 -0700 X-Google-Sender-Auth: ZjBIxjxAJPLj_IAkI05iTPa76GI Message-ID: Subject: Re: MAC firmware does not load due to (commit 288d5abe usermodehelper) To: Richard Cochran X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110928_112127_916316_211F9B9C X-CRM114-Status: GOOD ( 19.70 ) X-Spam-Score: -0.6 (/) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (-0.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [74.125.82.49 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (linus971[at]gmail.com) 0.1 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (linus971[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Russell King , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Krzysztof Halasa X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org On Wed, Sep 28, 2011 at 5:06 AM, Richard Cochran wrote: > > A warning appears on the console, shown below.  I don't know what > commit 288d5abe was trying to fix, but it sure made a regression for > me. It probably would also spoil using NFS boot, too. > > Any ideas what to do about this? Something seems to be calling ioctl() befor rest_init() has even completed. Which sounds odd, but I wonder if the schedule() there before it might have let 'init' get going. Does something like the attached (UNTESTED) fix it? Linus init/main.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/init/main.c b/init/main.c index 2a9b88aa5e76..23702bbdbc1d 100644 --- a/init/main.c +++ b/init/main.c @@ -381,9 +381,6 @@ static noinline void __init_refok rest_init(void) preempt_enable_no_resched(); schedule(); - /* At this point, we can enable user mode helper functionality */ - usermodehelper_enable(); - /* Call into cpu_idle with preempt disabled */ preempt_disable(); cpu_idle(); @@ -734,6 +731,7 @@ static void __init do_basic_setup(void) init_irq_proc(); do_ctors(); do_initcalls(); + usermodehelper_enable(); } static void __init do_pre_smp_initcalls(void)