From patchwork Tue Apr 29 10:37:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 343782 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 1F04E14007A for ; Tue, 29 Apr 2014 20:40:39 +1000 (EST) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wf5QU-0008Kt-Cd; Tue, 29 Apr 2014 10:38:14 +0000 Received: from mout.kundenserver.de ([212.227.126.131]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wf5QR-0008Fm-RU for linux-arm-kernel@lists.infradead.org; Tue, 29 Apr 2014 10:38:12 +0000 Received: from wuerfel.localnet (HSI-KBW-134-3-133-35.hsi14.kabel-badenwuerttemberg.de [134.3.133.35]) by mrelayeu.kundenserver.de (node=mreue004) with ESMTP (Nemesis) id 0Ls5Pv-1X1LBl1mDH-013tY3; Tue, 29 Apr 2014 12:37:46 +0200 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org, Alexander Shiyan Subject: Re: [PATCH] ASoC: fsl: select SND_SOC_IMX_PCM_DMA where needed Date: Tue, 29 Apr 2014 12:37:45 +0200 Message-ID: <4270904.84oGcCXL4B@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.11.0-18-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1398740853.880576398@f238.i.mail.ru> References: <6606961.lAGLvkNsEj@wuerfel> <6285923.UQqcZVikjI@wuerfel> <1398740853.880576398@f238.i.mail.ru> MIME-Version: 1.0 X-Provags-ID: V02:K0:E87A0898kj2OnmvwfBgO/QOqeOsTtpj34t0YLF92B5y 8fkHfa3A/lDcK/+xryk2zbwgKL4NLAAH/44+sr9fCqUI+RhWx1 pPQmqdQgiDexZ2spLyHHkoARA1aqrXO+MDTM8fltaw1Nyx6SO7 loKksP0A3d518l7TFix3D+U/I5Lw8XtOK3yHhUDFfVKwA0v/wU xpC+6gCgn2hzTgF8ILzxhOq5UYgtltCKtHmwQ/hkuYABTwqaMg ErVOg6IziYbNqjyD36n6EhMqn3NcSNbXYzJ1N64lUOiSEY4GM2 BbPSTgSmqt5fWaJtr4E+CuQm7yrndH33HnciWoW2K8jLgWAKdz gO0jlC1So04GhJwV9IDM= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140429_033812_202250_BCFC5944 X-CRM114-Status: GOOD ( 12.98 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.3.2 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.126.131 listed in list.dnswl.org] Cc: alsa-devel@alsa-project.org, Mark Brown X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org On Tuesday 29 April 2014 07:07:33 Alexander Shiyan wrote: > Mon, 28 Apr 2014 23:12:14 +0200 от Arnd Bergmann : > > On Tuesday 29 April 2014 00:35:41 Alexander Shiyan wrote: > > > > > > So, I don't understand why this error happen, as well as I can not > > > reproduce this... > > > > It's probably CONFIG_SND_SOC_IMX_PCM_DMA=m and CONFIG_SND_SOC_FSL_SSI=y then. > > What is the intended behavior in this case? Should CONFIG_SND_SOC_FSL_SSI > > be forced to be a module as well? > > Hmm, yes... > I thought that I had already solved a similar problem for the earlier > version of the patch ... How about this? Signed-off-by: Arnd Bergmann diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig index fb26345..af0bb92 100644 --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -9,6 +9,7 @@ config SND_SOC_FSL_SAI config SND_SOC_FSL_SSI tristate "Synchronous Serial Interface module support" + depends on m || SND_SOC_IMX_PCM_DMA != m help Say Y if you want to add Synchronous Serial Interface (SSI) support for the Freescale CPUs. @@ -18,6 +19,7 @@ config SND_SOC_FSL_SSI config SND_SOC_FSL_SPDIF tristate "Sony/Philips Digital Interface module support" select REGMAP_MMIO + depends on m || SND_SOC_IMX_PCM_DMA != m help Say Y if you want to add Sony/Philips Digital Interface (SPDIF) support for the Freescale CPUs.