From patchwork Tue Dec 6 17:10:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 1712903 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=paXt+Vej; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.a=rsa-sha256 header.s=google header.b=MkbkbT4e; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NRRm641d5z23yq for ; Wed, 7 Dec 2022 04:11:50 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/v4OQBrMBXqUUTtoxZvpP9II6wqjSrAyWbdrfn30tqc=; b=paXt+Vej6L21HD QiRr1qyUjuRv9zzuRkKGyCSQ11Yh31wO1NNGnXpBUu9P3LvUw1fY/iED8HtePkX3eEOv/ma92ZB7S s0COpO/WBlw+HJRB/+37B9GRA5hbFHH6fPThYlARKlMXBpMQhrbfY+o91sHNDHzP0qs7cep9wkYH0 bIq79qlcJDilsNSqyIcwrIgYPlUkSyU5HXPE937KV/H1xDcycDLDQayZiLn/MKk2pD6rubgFPa47H ERtI/ZDrysa30d/ciSEaNRH/7tXcsE/ZtC1BKvm0O4qEJ1nTlRFHPpQeZPgcxWazgJksmEuNZwDiT CG8e/qBunHhKilWvETnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2bTZ-00FhOi-7A; Tue, 06 Dec 2022 17:11:25 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2bTK-00FhCQ-IR for linux-arm-kernel@lists.infradead.org; Tue, 06 Dec 2022 17:11:11 +0000 Received: by mail-wr1-x435.google.com with SMTP id h7so18423092wrs.6 for ; Tue, 06 Dec 2022 09:11:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YmzucAOYeRO1Za2FBpNv+O/C9sORhwUJDwZR4toHbGw=; b=MkbkbT4elwmyTpFZMWHeouGW8MXnzkaicMClIaoEPhafVK6G/gOdEqkoCthjepgvjI zEqKhpIuaBMlQNFJh2elQbq49ozfBehJl8b7swZPkU8nDYLb2edrIvRhKfoRaWLFoI2I CjpxHQ0b/PEP/AKvsDPjtQ21In0cGNlRH6rBs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YmzucAOYeRO1Za2FBpNv+O/C9sORhwUJDwZR4toHbGw=; b=xUnbF049tYWDWDnf+pT5HD6tGJp/yxJ4JO6x4Hn//4zvdGT+kcZ1aVgV91OTJ2CLBU mDxMd9/7JG7tWnxUVwl+bZcT1hz36qqPVvXDdMR6OFLCP6GiFidzU6sb+pwFvDhiJvNW z/2eA6oHjseHmUaBFxKrD3QxEgCH3D6iqhWnmjMGTkm152ctzBRYXL1wuLDGQ8IFqCNm 4CBDQeCbGp8Ge3QMKB7G8ZGFwRjElJyMtgjYcdDkuiLaDihnHkUFX5a8ErzhnNUEgDEz txfG+WcJZjzZr+o0RbWJf0i8lK055WxCip7f96NoEzmoX2k2bS31FysCe/A/R1PcuV2v 8H2w== X-Gm-Message-State: ANoB5plemdF+j6IT9R02svu3nfWeLEbKBvVLdgR+VGX3+iZwiPlQk0By vMpbXEoxPlO/clqPdM2jzy6ccQ== X-Google-Smtp-Source: AA0mqf4Wm8rkIFD1VSowgEiyUmqd7dnA3qkC4S1F8gLh99B7TegLePQHEbez1bAclFIrsmYtMKkLtA== X-Received: by 2002:adf:ff90:0:b0:242:46f1:1de0 with SMTP id j16-20020adfff90000000b0024246f11de0mr10925436wrr.640.1670346669143; Tue, 06 Dec 2022 09:11:09 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.pdxnet.pdxeng.ch (host-82-54-95-136.retail.telecomitalia.it. [82.54.95.136]) by smtp.gmail.com with ESMTPSA id k10-20020a056000004a00b002365730eae8sm17298534wrx.55.2022.12.06.09.11.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 09:11:08 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , Dario Binacchi , Arnd Bergmann , Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team , Russell King , Sascha Hauer , Shawn Guo , linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/5] ARM: imx27: add missing of_node_put() Date: Tue, 6 Dec 2022 18:10:46 +0100 Message-Id: <20221206171049.3316611-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20221206171049.3316611-1-dario.binacchi@amarulasolutions.com> References: <20221206171049.3316611-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221206_091110_634870_40204CB3 X-CRM114-Status: UNSURE ( 9.76 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: In mx27_read_cpu_rev(), of_find_compatible_node() returns a node pointer with refcount incremented. Use of_node_put() on it when done. Fixes: 94b2bec1b0e05 ("ARM: imx27: Retrieve the SYSCTRL base address from devicetree") Signed-off-by: Dario Binacchi --- Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:435 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org In mx27_read_cpu_rev(), of_find_compatible_node() returns a node pointer with refcount incremented. Use of_node_put() on it when done. Fixes: 94b2bec1b0e05 ("ARM: imx27: Retrieve the SYSCTRL base address from devicetree") Signed-off-by: Dario Binacchi --- arch/arm/mach-imx/cpu-imx27.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-imx/cpu-imx27.c b/arch/arm/mach-imx/cpu-imx27.c index bf70e13bbe9e..1d2893908368 100644 --- a/arch/arm/mach-imx/cpu-imx27.c +++ b/arch/arm/mach-imx/cpu-imx27.c @@ -28,6 +28,7 @@ static int mx27_read_cpu_rev(void) np = of_find_compatible_node(NULL, NULL, "fsl,imx27-ccm"); ccm_base = of_iomap(np, 0); + of_node_put(np); BUG_ON(!ccm_base); /* * now we have access to the IO registers. As we need