Message ID | 20221206171049.3316611-2-dario.binacchi@amarulasolutions.com |
---|---|
State | New |
Headers | show
Return-Path: <linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org; receiver=<UNKNOWN>) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=X5b3vKE1; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.a=rsa-sha256 header.s=google header.b=dyXoW4R5; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NRRm854xDz23yq for <incoming-imx@patchwork.ozlabs.org>; Wed, 7 Dec 2022 04:11:52 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C9pTe3gCZWgkVzPILLHrl3i2jZgFyKIxW9YEqBNFxrc=; b=X5b3vKE1ynirs/ TGMqMT8CvY9EDR5yE7sYp5tKlDt0fX1hrAKAqNzqJWxn5yfGRJTNsOfP9FHl7RwfED8nxTBzfVNpq fFj2YOewI18lAn3SW/vZWW3VN5T6miOt6kyKmcPl5svSsSI02ucep2Wvx1kL2MXUNsVzJr01d1P4O p1lLVUA/LnVeLBulqSXPRvsQrwIwWP3OdDF3rdBf64isKV2TBihgTVqFfp78fkGmEiUj91RIPD1lG r63d4tKPs4vLgyUteOmhyM1wTq2qBADRUKd9uOe8jhUeqMjJ1t4FKY1JQrVycq1HsF6HqiTftpv4q Voc1gxYMfgtUnq5Yo8xQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2bTj-00FhVA-NZ; Tue, 06 Dec 2022 17:11:35 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2bTL-00FhAH-BB for linux-arm-kernel@lists.infradead.org; Tue, 06 Dec 2022 17:11:12 +0000 Received: by mail-wr1-x433.google.com with SMTP id h7so18422997wrs.6 for <linux-arm-kernel@lists.infradead.org>; Tue, 06 Dec 2022 09:11:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+0eEedGwGTs0kfi7RPmjpdf2WkKmieSTXamBFgfWsLQ=; b=dyXoW4R5nzvhrF2ArwJVeg/RNvPFTxGysEkFtaM0+/WmSby6JpBEEzAuzb6dm/IUrO loetYRVTWv84boZgega8by8OHA894AB3cBdImVYzS/zG45qSdtvD+P+IrHwFWTQ9kaNQ dbXYFqDbgEchx56LERT2IZVmK/P54IfFI/v7k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+0eEedGwGTs0kfi7RPmjpdf2WkKmieSTXamBFgfWsLQ=; b=pvmu7wMrJI8U/hMsGyTNjyQ6x3qc3xUR7MzZ81wn+X17rqBr6ossj7UIqUJZoTdL/1 bIczBBTImd2KGJGe6Qv+Ko/+EX/d/zWxpenoD1SKArcPHos2/T7JpWEche+QGPaQhJHH BQ5vx9JJ2lmSjl7jHU9pKs4SZB7Keo/xlT2Ud+SvPrVCMftLyeDljDMgnt1qwtSrPtrq QoCPdfuxmoOrqF/O7PYvAAm2yApnj+IwgeNJp1XULvfQTAZgB6ua/cYSH+Blhufyl472 V/qiKwQYhgYyQa7aV3fglpwLAIGZUxkifngfAT4xGgvGv3geVEnUFRPmxTiaiMV4bAS9 evtg== X-Gm-Message-State: ANoB5pna0dCufA5j4iWn9tIiuB8j0/vBAzVDwQ15D1+c9/uEYDyquA2U 6t/sIYTpSq904fS3tl+CCdvXkA== X-Google-Smtp-Source: AA0mqf5VYzXR0eKaEheU+DSuzIPtiiZXxadgFHz/ASXvN/BUlPG5unQLLOG06Nxd5Dcsf4wUCuWsVA== X-Received: by 2002:a05:6000:18c1:b0:236:5d8c:97fd with SMTP id w1-20020a05600018c100b002365d8c97fdmr54257190wrq.473.1670346667896; Tue, 06 Dec 2022 09:11:07 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.pdxnet.pdxeng.ch (host-82-54-95-136.retail.telecomitalia.it. [82.54.95.136]) by smtp.gmail.com with ESMTPSA id k10-20020a056000004a00b002365730eae8sm17298534wrx.55.2022.12.06.09.11.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 09:11:07 -0800 (PST) From: Dario Binacchi <dario.binacchi@amarulasolutions.com> To: linux-kernel@vger.kernel.org Cc: Amarula patchwork <linux-amarula@amarulasolutions.com>, Dario Binacchi <dario.binacchi@amarulasolutions.com>, Fabio Estevam <festevam@gmail.com>, Martin Kaiser <martin@kaiser.cx>, NXP Linux Team <linux-imx@nxp.com>, Pengutronix Kernel Team <kernel@pengutronix.de>, Russell King <linux@armlinux.org.uk>, Sascha Hauer <s.hauer@pengutronix.de>, Shawn Guo <shawnguo@kernel.org>, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/5] ARM: imx25: add missing of_node_put() Date: Tue, 6 Dec 2022 18:10:45 +0100 Message-Id: <20221206171049.3316611-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20221206171049.3316611-1-dario.binacchi@amarulasolutions.com> References: <20221206171049.3316611-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221206_091111_409854_EC0C2C05 X-CRM114-Status: UNSURE ( 9.29 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: In mx25_read_cpu_rev(), of_find_compatible_node() returns a node pointer with refcount incremented. Use of_node_put() on it when done. Fixes: 8b88f7ef31dde ("ARM: mx25: Retrieve IIM base from dt") Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> --- Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:433 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org |
Series | ARM: imx: add missing of_node_put() | expand |
diff --git a/arch/arm/mach-imx/cpu-imx25.c b/arch/arm/mach-imx/cpu-imx25.c index 3e63445cde06..cc86977d0a34 100644 --- a/arch/arm/mach-imx/cpu-imx25.c +++ b/arch/arm/mach-imx/cpu-imx25.c @@ -23,6 +23,7 @@ static int mx25_read_cpu_rev(void) np = of_find_compatible_node(NULL, NULL, "fsl,imx25-iim"); iim_base = of_iomap(np, 0); + of_node_put(np); BUG_ON(!iim_base); rev = readl(iim_base + MXC_IIMSREV); iounmap(iim_base);
In mx25_read_cpu_rev(), of_find_compatible_node() returns a node pointer with refcount incremented. Use of_node_put() on it when done. Fixes: 8b88f7ef31dde ("ARM: mx25: Retrieve IIM base from dt") Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> --- arch/arm/mach-imx/cpu-imx25.c | 1 + 1 file changed, 1 insertion(+)