mbox series

[GIT,PULL,2/6] soc/tegra: cbb: Changes for v6.1-rc1

Message ID 20220916101957.1635854-2-thierry.reding@gmail.com
State New
Headers show
Series [GIT,PULL,1/6] soc/tegra: Changes for v6.1-rc1 | expand

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git tags/tegra-for-6.1-cbb

Message

Thierry Reding Sept. 16, 2022, 10:19 a.m. UTC
Hi ARM SoC maintainers,

The following changes since commit 568035b01cfb107af8d2e4bd2fb9aea22cf5b868:

  Linux 6.0-rc1 (2022-08-14 15:50:18 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git tags/tegra-for-6.1-cbb

for you to fetch changes up to 53283105cab6f408968b7546826303ad329e9983:

  soc/tegra: cbb: Add support for Tegra241 (Grace) (2022-09-15 12:41:36 +0200)

I've split this out separately for now because after the discussion
last release cycle there wasn't quite consensus about where this should
go. The EDAC maintainers said that they didn't think it'd be a good fit
so I'm including it again for ARM SoC here, but it being on a separate
branch it won't block any of the other patches from going in if this is
still a contentious topic.

Thanks,
Thierry

----------------------------------------------------------------
soc/tegra: cbb: Changes for v6.1-rc1

This introduces the CBB driver that is used to provide (a lot of)
information about SErrors when things go wrong, instead of the kernel
just crashing or hanging.

----------------------------------------------------------------
Sumit Gupta (4):
      soc/tegra: Set ERD bit to mask inband errors
      soc/tegra: cbb: Add CBB 1.0 driver for Tegra194
      soc/tegra: cbb: Add driver for Tegra234 CBB 2.0
      soc/tegra: cbb: Add support for Tegra241 (Grace)

 drivers/soc/tegra/Kconfig              |    9 +
 drivers/soc/tegra/Makefile             |    1 +
 drivers/soc/tegra/cbb/Makefile         |    9 +
 drivers/soc/tegra/cbb/tegra-cbb.c      |  190 +++
 drivers/soc/tegra/cbb/tegra194-cbb.c   | 2364 ++++++++++++++++++++++++++++++++
 drivers/soc/tegra/cbb/tegra234-cbb.c   | 1113 +++++++++++++++
 drivers/soc/tegra/fuse/tegra-apbmisc.c |   29 +-
 include/soc/tegra/fuse.h               |    6 +
 include/soc/tegra/tegra-cbb.h          |   47 +
 9 files changed, 3766 insertions(+), 2 deletions(-)
 create mode 100644 drivers/soc/tegra/cbb/Makefile
 create mode 100644 drivers/soc/tegra/cbb/tegra-cbb.c
 create mode 100644 drivers/soc/tegra/cbb/tegra194-cbb.c
 create mode 100644 drivers/soc/tegra/cbb/tegra234-cbb.c
 create mode 100644 include/soc/tegra/tegra-cbb.h

Comments

Arnd Bergmann Sept. 23, 2022, 4:13 p.m. UTC | #1
On Fri, Sep 16, 2022, at 12:19 PM, Thierry Reding wrote:
> Hi ARM SoC maintainers,
>
> The following changes since commit 568035b01cfb107af8d2e4bd2fb9aea22cf5b868:
>
>   Linux 6.0-rc1 (2022-08-14 15:50:18 -0700)
>
> are available in the Git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git 
> tags/tegra-for-6.1-cbb
>
> for you to fetch changes up to 53283105cab6f408968b7546826303ad329e9983:
>
>   soc/tegra: cbb: Add support for Tegra241 (Grace) (2022-09-15 12:41:36 +0200)
>
> I've split this out separately for now because after the discussion
> last release cycle there wasn't quite consensus about where this should
> go. The EDAC maintainers said that they didn't think it'd be a good fit
> so I'm including it again for ARM SoC here, but it being on a separate
> branch it won't block any of the other patches from going in if this is
> still a contentious topic.
>

Thank you for splitting it out. I'm not too happy about having
this driver in drivers/soc, as I still think it deserves to be in
a real subsystem with a generalized user interface.

I had hoped it would fit into EDAC, but I can understand that
this is not a great fit in the end. Since the driver has no
stable (ioctl or sysfs) interface but only a debugfs one that
can change at any time, my hope is that we can come up with
something better in the long run, e.g. when another SoC family
has a similar requirement and we create a more generic and
stable interface.

In the meantime, we can keep it in drivers/soc, so it's now
merged into the arm/drivers branch.

     Arnd