Message ID | 20220615145743.3969705-1-windhl@126.com |
---|---|
State | New |
Headers | show
Return-Path: <linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=hd6sgXRb; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=126.com header.i=@126.com header.a=rsa-sha256 header.s=s110527 header.b=jo77HEeM; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org; receiver=<UNKNOWN>) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LNT2c3gz6z9sVb for <incoming-imx@patchwork.ozlabs.org>; Thu, 16 Jun 2022 00:58:31 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=kTiqRNaPyS9xTv63T9xe5mlqP+okjbw08upAEOe+zbA=; b=hd6sgXRbuo6oTM QO+HvsU+HgR1AIJK2Pvh75ZK8oCxGClmIZU3s29xAoH6GO8Tu7BBymzkDyA7fCass5HgQGmz+RBFG B42PgbMv5vsLdlF9l/WjjAf/LO7/Z6dT91G/JWnnkoOTfPx0ghEDcemDOmZj+oXZMC9CWMWKDZWM2 Eaf6ZxRJTWFh44iKUQ0jzK/abqk9m6yU+LE+0QV33BdxoDsdI/tLhDwNnmlnA18DIumorKItATY9m AD2EoHeCW7p4z6419CzZsdmdEv6Pbu4OcVwQon9OZsSQY2zlvGEQiOev5G2Tz8t/GH2Y62N+4s4t6 P7uPT+l0KyYGLjjRkLwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1UTB-00F5fn-KV; Wed, 15 Jun 2022 14:58:09 +0000 Received: from m15112.mail.126.com ([220.181.15.112]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1UT8-00F5ej-5c for linux-arm-kernel@lists.infradead.org; Wed, 15 Jun 2022 14:58:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=0jHX1 o4T3dntA4QQGKBVqsC0i9BdSq13vyJ3pRtuELc=; b=jo77HEeM5iwfk8mkwfhif aiqq26y6WzJjk4uwj2CPx9ecJiJqBaj0jvzwd1LhTbBogRGsimK2Fo7DMT8EvghO rV1N98RNCAdtiv5AChaUgilxPwZHGATPj/SE3O1NUbDMdV4tJzh/PaN3OEqEgRqN Y0Uycx8sLVmWlTpLM5+iIA= Received: from localhost.localdomain (unknown [124.16.139.61]) by smtp2 (Coremail) with SMTP id DMmowAD3IQVo86liwUE+DQ--.47882S2; Wed, 15 Jun 2022 22:57:44 +0800 (CST) From: Liang He <windhl@126.com> To: linux@armlinux.org.uk, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, windhl@126.com Subject: [PATCH] arm: mach-imx: Add missing of_node_put() in cpu-imx5.c Date: Wed, 15 Jun 2022 22:57:43 +0800 Message-Id: <20220615145743.3969705-1-windhl@126.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: DMmowAD3IQVo86liwUE+DQ--.47882S2 X-Coremail-Antispam: 1Uf129KBjvdXoWruF4rJryfZr43Cw45XryxXwb_yoWxKrX_t3 WfW3srJFWrJF4FvryUua1rWF4Fqws3Wr1rXFyIya1Yk3yqvrnxCrnFv3WIqry7Zr1agFW5 WF9rCr4Ykw1YkjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRMpnQ3UUUUU== X-Originating-IP: [124.16.139.61] X-CM-SenderInfo: hzlqvxbo6rjloofrz/xtbBGgMhF1-HZTdFJwACsF X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220615_075807_001638_1B6904A5 X-CRM114-Status: UNSURE ( 7.07 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: In imx5_read_srev_reg(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore. Signed-off-by: Liang He --- arch/arm/mach-imx/cpu-imx5.c | 2 ++ 1 file changed, 2 insertions(+) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [220.181.15.112 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [windhl[at]126.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org |
Series |
arm: mach-imx: Add missing of_node_put() in cpu-imx5.c
|
expand
|
diff --git a/arch/arm/mach-imx/cpu-imx5.c b/arch/arm/mach-imx/cpu-imx5.c index ad56263778f9..103bf5be9b1b 100644 --- a/arch/arm/mach-imx/cpu-imx5.c +++ b/arch/arm/mach-imx/cpu-imx5.c @@ -30,6 +30,8 @@ static u32 imx5_read_srev_reg(const char *compat) iim_base = of_iomap(np, 0); WARN_ON(!iim_base); + of_node_put(np); + srev = readl(iim_base + IIM_SREV) & 0xff; iounmap(iim_base);
In imx5_read_srev_reg(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore. Signed-off-by: Liang He <windhl@126.com> --- arch/arm/mach-imx/cpu-imx5.c | 2 ++ 1 file changed, 2 insertions(+)