From patchwork Mon May 16 03:52:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 1631280 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=U4703835; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=Uwt0u5+L; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4L1lhg6XLfz9s2R for ; Mon, 16 May 2022 13:53:07 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=WXd4NEgXQix9HFjOS3BgDw6K5yn9vEgV6KRUi0PYT8Q=; b=U47038358BhKT8 lLbBDf1QjLYq571MTbiqTxFPtqS05/dQkyofIqv5NVp+gKFnhrddHvXiF/VjyR8TzL9R5+sj/T7dl hd88r3eGNEatAbZHZLNNJkYi6MTr+W3rWsacfswYaqBiNrKJLo6xatGNgCkp4dOZ4WvTXRQ93h/T8 F1ESDfT9gIjRcuEJtTiDT3ZbdSJsfgy6WDjXpNTRaW8pSkBOxScDmOV0eX7Rk39uH18XjOJtNvdQc +ZNqM0y6wVis1R37/vONZHaUkq/u4soJWs43nUvau64/o4vEA+TxxuKgMwhaDALLk3+nGfvZb+61s OOpBaBnzX15bsK2xW/zA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqRmt-005py3-Au; Mon, 16 May 2022 03:52:51 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqRmq-005pwz-3V for linux-arm-kernel@lists.infradead.org; Mon, 16 May 2022 03:52:49 +0000 Received: by mail-pl1-x62e.google.com with SMTP id bh5so1479536plb.6 for ; Sun, 15 May 2022 20:52:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=mMPTt/Of+OgWknmwr3MDPDoNNiu/QtIgBOYrO8XaQBE=; b=Uwt0u5+LUvgNI6yu6phy6yswi1r5YnZ2KRdIP75+c0oZarBqPui6oKVTls4jsFAGRw sjXUbX0nFgNwmwpXLllnxpKK1cv4FXnqPk6KKKZfWlfRmmdVvLtndMPo3g5vxlX8HOZ/ MEg1D2rDTlvEHs+DLOOh2Xd4z+lXfP2uqCRadu6dDZ23+pjDlVD43lRSeSlMCXYAvowR SYWWGrWGsGqIRtk7KXzApD/NFeg76YHzyigyxCHNmevSEnFRTx5p5+st+blaBy1Zt82e d+wBl35rSFJv6EObxiIUX9JognI5OGHXvC0ixL6EvsQ8uhJJTXcQ+MG+2kHkrbpEhqQF u43A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=mMPTt/Of+OgWknmwr3MDPDoNNiu/QtIgBOYrO8XaQBE=; b=Mhg/NzxprtCZYLt6Pw1HqydcLzi/SBpZA8ozp+ZdN4mHwidFceLNCBE6fGPJgi8TQ5 rjkB9W99otzcj+uBKHYFIYFbFrydc/xlOhvN6TjWZN3wncSKSzHdTk3i8q3QjyDZq+GQ ASeh1KpPSCozphbUbKTRykU6Db4oBGlKQKaM494f1otoZmmwZ94BEot6QmgzqpoElK9p Ln0qEMrYIBQFsc5MXK1C2cvNKmq4P+FlTv4Yc1sFuW2P15LD4Xo5aMZh8EcWfsXJ/Xzh Nq+DQmp73eS6UZVQxzHa2OIxuoYpUwwGHUiz/agQod8Lbu6taB2AStdTWCKLqdC0AXjC xnbQ== X-Gm-Message-State: AOAM531NPyRwA0lEp1WUCQERRIhToRwcxYAuwVjKwmmO+FcEypxKsTTG LAs37onLY6br6sZ53WnSoM4= X-Google-Smtp-Source: ABdhPJyhicCI2IanoagT3mondvYF4JvReoWk6NJpNAjgUzh7q77RDUI4S1j0elpnuhZj4xtX7/hmIA== X-Received: by 2002:a17:902:ce82:b0:15e:982e:a815 with SMTP id f2-20020a170902ce8200b0015e982ea815mr15154896plg.167.1652673166361; Sun, 15 May 2022 20:52:46 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id im9-20020a170902bb0900b0015e8d4eb1b7sm5815772plb.1.2022.05.15.20.52.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 May 2022 20:52:45 -0700 (PDT) From: Miaoqian Lin To: Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Miaoqian Lin , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: imx27: Fix refcount leak in mx27_suspend_enter Date: Mon, 16 May 2022 07:52:28 +0400 Message-Id: <20220516035231.5362-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220515_205248_210699_4D47CA20 X-CRM114-Status: GOOD ( 11.68 ) X-Spam-Score: 0.1 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: of_find_compatible_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak. Fixes: d54debc72f5f ("ARM: imx27: Retrieve the CCM base address from devicetree") Signed-off-by: Miaoqian Lin --- arch/arm/mach-imx/pm-imx27.c | 1 + 1 file changed, 1 insertion(+) Content analysis details: (0.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:62e listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [linmq006[at]gmail.com] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit [linmq006[at]gmail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org of_find_compatible_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak. Fixes: d54debc72f5f ("ARM: imx27: Retrieve the CCM base address from devicetree") Signed-off-by: Miaoqian Lin --- arch/arm/mach-imx/pm-imx27.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-imx/pm-imx27.c b/arch/arm/mach-imx/pm-imx27.c index 237e8aa9fe83..179506196f8e 100644 --- a/arch/arm/mach-imx/pm-imx27.c +++ b/arch/arm/mach-imx/pm-imx27.c @@ -24,6 +24,7 @@ static int mx27_suspend_enter(suspend_state_t state) np = of_find_compatible_node(NULL, NULL, "fsl,imx27-ccm"); ccm_base = of_iomap(np, 0); BUG_ON(!ccm_base); + of_node_put(np); switch (state) { case PM_SUSPEND_MEM: