From patchwork Wed Mar 9 10:29:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 1603325 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=e9xqEzz0; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=UwnTNzCC; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KD7k53MYwz9sG9 for ; Wed, 9 Mar 2022 21:30:05 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=v3oOWrMrIm4IHNG1oLxtovzFYezC2OrrYvECWYvz6Gc=; b=e9xqEzz0esuR8+ t2w6UURz9NEYDy625nHDIEzUDR8iIkilIU7haQumyYZgJ5CnQBxbiH0Ev7ZnhF6G0BWhnurZVSaw0 BxMhb2jJTbWYyFZUbUWUVOALJEUgvLMe2+E4uib5mtp9KMH0FFzJhrE/sYm/1dB64UHUFkirGuLUR wRu3px9MBlY339sc+T0sJVhDe6TjNhhk72xMATtK/hsla9RdrZKu0hG0S0lf49t+6lUI0VVWahauH NP+v/8LvDGCT62e9FclPO0JH+mdh4yCd/HKfcsZZa0HGxkWdArZcrCGFsg2aHUsMBGcDOlhsTGCz2 1Zv5YIMm3TbSjkNC/ARA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRtZm-0089L2-A4; Wed, 09 Mar 2022 10:29:50 +0000 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRtZY-0089J6-Kk for linux-arm-kernel@lists.infradead.org; Wed, 09 Mar 2022 10:29:37 +0000 Received: by mail-pg1-x534.google.com with SMTP id bc27so1610674pgb.4 for ; Wed, 09 Mar 2022 02:29:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id; bh=Rw/pp7CFH5EhW2LRIhOwhzyCXvO4+HLXzhoa8fZG4Vg=; b=UwnTNzCC2qThAdKUXhj8GC9fig6H+HILqjgvDTyireA20u+TrUP/ufwZSuSLsflHhi iQK1bA5v3FJdCZBN6hy7pI8wpFI0+lSDw9VblSXI3olRzMjbFZ6ymjAd2Url3XGCZEvw 8VSmTlPP0XpIYelWPpm6II1PbAGeJxVJzcuISXUhIQqHaAgY2JyI19TzE1saEZYP2AWE xLTqRfP7kKa3QmiXzUZcXCEquP8qE+miojh2HwQsi0mlxj+WoSq3+XzWrVB8sa8i2jll SS5odbQP/RnYBh6fySO+ZZYTmh0v8Q6ymn50Ct3v5rHIWPLcRbS4vlcDPQh9ki8cfsGw YHGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id; bh=Rw/pp7CFH5EhW2LRIhOwhzyCXvO4+HLXzhoa8fZG4Vg=; b=Qn+pv1hB2W6+MWSoFOLpxPYAGR1Kiq49zESMUo+wEEkDZndOvDnCdaZUm4E6JEhl7F CV+tsSrUqB2ch2vr1wwShqifK8b/QoOXUG7Hy6a3QTNaKlbosQTllljKxZKk4xKg1bf0 jxKVWJf9lr1q6ghYpzKptVXYWZBeOJDClafm5kALeIxO0upNicqd8dEQF1B/dy9M1YpR AOh+vkHs3Wj4oWJ4u1LJcicuCdDc548RbsK9qPPCnxu8DK/UQzEi6MI84UK9RPeEZgMJ dHU1Jj3Nf0Jt+9wkfdxh0m0bWEg9K/3UxD0lXoyVsTnV5uL8iE5Pt6WqKmMHCwO7avxT 3T6Q== X-Gm-Message-State: AOAM531y/EceLPT/57fyigZPxtblBlKqt+U46qqEwjTwu1YMQMdTF+Qo F54MzTWVXOmAZwP5gy+QSaOS/6KN0Ep6gFmJ8Sf2eQ== X-Google-Smtp-Source: ABdhPJxuPa44GvUtEMbeoDN2OwzhuAS4wgG/9yy0L5AfmcufRLo1H5gTmU+219QVi6s2KIxiCtoe7g== X-Received: by 2002:a05:6a00:1251:b0:4f1:2a1:3073 with SMTP id u17-20020a056a00125100b004f102a13073mr22846915pfi.72.1646821775542; Wed, 09 Mar 2022 02:29:35 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id p27-20020a056a000a1b00b004f3f63e3cf2sm2604986pfh.58.2022.03.09.02.29.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 02:29:35 -0800 (PST) From: Miaoqian Lin To: Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Leonard Crestez , Anson Huang , Philipp Zabel , Miaoqian Lin , Ranjani Vaidyanathan , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: imx: Fix refcount leak in imx_src_init Date: Wed, 9 Mar 2022 10:29:25 +0000 Message-Id: <20220309102929.16306-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220309_022936_701173_3FCFCF96 X-CRM114-Status: GOOD ( 11.39 ) X-Spam-Score: 0.1 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The of_find_compatible_node() function returns a node pointer with refcount incremented, We should use of_node_put() on it when done Add the missing of_node_put() to release the refcount. Fixes: 9fbbe6890c88 ("arm/imx6q: add core drivers clock, gpc, mmdc and src") Signed-off-by: Miaoqian Lin --- arch/arm/mach-imx/src.c | 1 + 1 file changed, 1 insertion(+) Content analysis details: (0.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:534 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [linmq006[at]gmail.com] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit [linmq006[at]gmail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org The of_find_compatible_node() function returns a node pointer with refcount incremented, We should use of_node_put() on it when done Add the missing of_node_put() to release the refcount. Fixes: 9fbbe6890c88 ("arm/imx6q: add core drivers clock, gpc, mmdc and src") Signed-off-by: Miaoqian Lin --- arch/arm/mach-imx/src.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-imx/src.c b/arch/arm/mach-imx/src.c index 59a8e8cc4469..f28bfb653a88 100644 --- a/arch/arm/mach-imx/src.c +++ b/arch/arm/mach-imx/src.c @@ -171,6 +171,7 @@ void __init imx_src_init(void) if (!np) return; src_base = of_iomap(np, 0); + of_node_put(np); WARN_ON(!src_base); /*