From patchwork Fri Apr 12 22:22:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Heiko_St=C3=BCbner?= X-Patchwork-Id: 236230 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:770:15f::2]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C22BE2C009F for ; Sat, 13 Apr 2013 08:23:25 +1000 (EST) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UQmNE-0001tc-Av; Fri, 12 Apr 2013 22:23:12 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UQmNB-0004yh-SM; Fri, 12 Apr 2013 22:23:09 +0000 Received: from gloria.sntech.de ([95.129.55.99]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UQmN2-0004yN-Q0 for linux-arm-kernel@lists.infradead.org; Fri, 12 Apr 2013 22:23:03 +0000 Received: from 146-52-52-35-dynip.superkabel.de ([146.52.52.35] helo=marty.localnet) by gloria.sntech.de with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1UQmMt-0005Rn-Mc; Sat, 13 Apr 2013 00:22:51 +0200 From: Heiko =?utf-8?q?St=C3=BCbner?= To: Tomasz Figa Subject: Re: [PATCH v5 00/14] ARM: samsung-time: Prepare for multiplatform support Date: Sat, 13 Apr 2013 00:22:48 +0200 User-Agent: KMail/1.13.7 (Linux/3.2.0-3-686-pae; KDE/4.8.4; i686; ; ) References: <1365794250-14436-1-git-send-email-t.figa@samsung.com> In-Reply-To: <1365794250-14436-1-git-send-email-t.figa@samsung.com> MIME-Version: 1.0 Message-Id: <201304130022.49987.heiko@sntech.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130412_182300_938420_55863A68 X-CRM114-Status: GOOD ( 16.10 ) X-Spam-Score: -2.5 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- 1.7 KHOP_BIG_TO_CC Sent to 10+ recipients instaed of Bcc or a list -2.4 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: mark.rutland@arm.com, tomasz.figa@gmail.com, buserror@gmail.com, jacmet@sunsite.dk, augulis.darius@gmail.com, christer@weinigel.se, sylvester.nawrocki@gmail.com, m.szyprowski@samsung.com, kgene.kim@samsung.com, linux@arm.linux.org.uk, kwangwoo.lee@gmail.com, mcuelenaere@gmail.com, arnd@arndb.de, devicetree-discuss@lists.ozlabs.org, linux-samsung-soc@vger.kernel.org, john.stultz@linaro.org, ghcstop@gmail.com, linux@simtec.co.uk, linux-arm-kernel@lists.infradead.org, broonie@opensource.wolfsonmicro.com, jekhor@gmail.com, kyungmin.park@samsung.com, tglx@linutronix.de X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org Hi Tomasz, Am Freitag, 12. April 2013, 21:17:16 schrieb Tomasz Figa: > This series is an attempt to make the samsung-time clocksource driver ready > for multiplatform kernels. It moves the driver to drivers/clocksource, > cleans it up from uses of static platform-specific definitions, simplifies > timer interrupt handling and adds Device Tree support. > > The samsung_pwm clocksource driver is made the master driver, which > exposes a single function to the PWM driver to get required data. Only > samsung-time driver is reworked to use the master driver at this time, > since the PWM driver can be already considered broken at the moment and > needs separate series of several patches to fix and clean it up, which > I am already working on. > > Tested on Universal C210 board with Device Tree. Not tested without > Device Tree, since it has been already broken before this series. > Compile tested for other related SoCs. On a s3c2416 based board with both non-dt and preliminary-dt support Tested-by: Heiko Stuebner One nitpick: Without dt support, you get this: CC drivers/clocksource/samsung_pwm.o drivers/clocksource/samsung_pwm.c:620: warning: ‘samsung_pwm_clocksource_init_of’ defined but not used So, something like the following might be necessary -------------- 8< ------------------- -------------- 8< ------------------- Heiko diff --git a/drivers/clocksource/samsung_pwm.c b/drivers/clocksource/samsung_pwm.c index a12ee08..2bf8303 100644 --- a/drivers/clocksource/samsung_pwm.c +++ b/drivers/clocksource/samsung_pwm.c @@ -617,6 +617,7 @@ static void __init __samsung_pwm_clocksource_init( samsung_clocksource_init(); } +#ifdef CONFIG_CLKSRC_OF static void __init samsung_pwm_clocksource_init_of(struct device_node *np) { __samsung_pwm_clocksource_init(NULL, np); @@ -629,6 +630,7 @@ CLOCKSOURCE_OF_DECLARE(s5p6440_pwm, "samsung,s5p6440-pwm", samsung_pwm_clocksource_init_of); CLOCKSOURCE_OF_DECLARE(s5pc100_pwm, "samsung,s5pc100-pwm", samsung_pwm_clocksource_init_of); +#endif void __init samsung_pwm_clocksource_init(struct platform_device *pdev) {