From patchwork Fri May 11 09:17:27 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 158482 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 7F4C4B6FB4 for ; Fri, 11 May 2012 21:24:24 +1000 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SSnf1-00019p-Ok; Fri, 11 May 2012 11:05:42 +0000 Received: from mail-pb0-f49.google.com ([209.85.160.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SSlyX-00074e-3a for linux-arm-kernel@lists.infradead.org; Fri, 11 May 2012 09:17:36 +0000 Received: by pbbrq13 with SMTP id rq13so3438023pbb.36 for ; Fri, 11 May 2012 02:17:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent :x-gm-message-state; bh=qIBZvljUCu8Av4KwnbAkfpCk40UzcJ1GiblnNGM2t9o=; b=Leo4jE/8Y6EiOnobEOBFTqxDu4AGKjCq/6eYsNp6iHwxlDcBCUczoIVjT+Vj5boHGg xsjbMiVSvcGDVCd4pwYEtsOGBI+YwBqeUbSyd3/16uq2VHe2Bqtc0tVLsF0ExuiikolR hKKBH6lrHmtgeF1G2uGZq4oRU8TS1JHyQh6P209ccJV6ImrDQrpDt9r1v+A/nBnErrwc uRufooSY7EFE2tqtbpHjAsN/4NsSXWGOUCyxzNUtHIvSmIy9h81D1U7Tz1Y/o3r6mH7H 4FQXZ5AXKKXOTG1Wvdaarh4RlwNC/nY1G5wXGmkjSaZzAceeQniFX2YDX9ZxmP506mOF 50UA== Received: by 10.68.200.9 with SMTP id jo9mr9243528pbc.122.1336727843583; Fri, 11 May 2012 02:17:23 -0700 (PDT) Received: from S2101-09.ap.freescale.net ([114.219.80.234]) by mx.google.com with ESMTPS id kb12sm12272835pbb.15.2012.05.11.02.17.19 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 11 May 2012 02:17:22 -0700 (PDT) Date: Fri, 11 May 2012 17:17:27 +0800 From: Shawn Guo To: Sascha Hauer Subject: Re: [PATCH 1/5] ARM: imx: add more imx5 ssi clocks Message-ID: <20120511091725.GZ17875@S2101-09.ap.freescale.net> References: <1336718568-26810-1-git-send-email-shawn.guo@linaro.org> <1336718568-26810-2-git-send-email-shawn.guo@linaro.org> <20120511074701.GD27341@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120511074701.GD27341@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQnvISPuLlZycSUmexpQdyw3lEQ0QZMs3qa61+RAEChlEU5ECyCjmPM5TiKqJ/PPq3WjphAk X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.160.49 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org On Fri, May 11, 2012 at 09:47:01AM +0200, Sascha Hauer wrote: > > + clk_register_clkdev(clk[ssi_ext1_gate], NULL, "ssi_ext.0"); > > + clk_register_clkdev(clk[ssi_ext2_gate], NULL, "ssi_ext.1"); > > Another thing I just noticed is that you use ssi_ext.0|1 as the device id, > is that what you want? I think the device id should either match a real > device present in the system or be NULL. > Good catch. Thanks, Sascha. Fixed as below. Regards, Shawn diff --git a/arch/arm/mach-imx/clk-imx51-imx53.c b/arch/arm/mach-imx/clk-imx51-imx53.c index 26ba1c5..fcd94f3 100644 --- a/arch/arm/mach-imx/clk-imx51-imx53.c +++ b/arch/arm/mach-imx/clk-imx51-imx53.c @@ -269,8 +269,8 @@ static void __init mx5_clocks_common_init(unsigned long rate_ckil, clk_register_clkdev(clk[ssi1_ipg_gate], NULL, "imx-ssi.0"); clk_register_clkdev(clk[ssi2_ipg_gate], NULL, "imx-ssi.1"); clk_register_clkdev(clk[ssi3_ipg_gate], NULL, "imx-ssi.2"); - clk_register_clkdev(clk[ssi_ext1_gate], NULL, "ssi_ext.0"); - clk_register_clkdev(clk[ssi_ext2_gate], NULL, "ssi_ext.1"); + clk_register_clkdev(clk[ssi_ext1_gate], "ssi_ext1", NULL); + clk_register_clkdev(clk[ssi_ext2_gate], "ssi_ext2", NULL); clk_register_clkdev(clk[sdma_gate], NULL, "imx35-sdma"); clk_register_clkdev(clk[cpu_podf], "cpu", NULL); clk_register_clkdev(clk[iim_gate], "iim", NULL); diff --git a/arch/arm/mach-imx/imx53-dt.c b/arch/arm/mach-imx/imx53-dt.c index 52455ea..8b002fcd 100644 --- a/arch/arm/mach-imx/imx53-dt.c +++ b/arch/arm/mach-imx/imx53-dt.c @@ -87,9 +87,9 @@ static void __init imx53_qsb_init(void) { struct clk *clk; - clk = clk_get_sys("ssi_ext.0", NULL); + clk = clk_get_sys(NULL, "ssi_ext1"); if (IS_ERR(clk)) { - pr_err("failed to get clk ssi_ext.0\n"); + pr_err("failed to get clk ssi_ext1\n"); return; }