| Message ID | 1475085056-5205-4-git-send-email-noralf@tronnes.org |
|---|---|
| State | New |
| Headers | show |
On 28.09.2016, at 19:50, Noralf Trønnes <noralf@tronnes.org> wrote: > > Writing to an AT24C32 generates on average 2x i2c transfer errors per > 32-byte page write. Which amounts to a lot for a 4k write. This is due > to the fact that the chip doesn't respond during it's internal write > cycle when the at24 driver tries and retries the next write. > Only a handful drivers use dev_err() on transfer error, so switch to > dev_dbg() instead. > > Signed-off-by: Noralf Trønnes <noralf@tronnes.org> Reviewed-by: Martin Sperl <kernel@martin.sperl.org>
diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c index df036ed..8cdb139 100644 --- a/drivers/i2c/busses/i2c-bcm2835.c +++ b/drivers/i2c/busses/i2c-bcm2835.c @@ -207,7 +207,7 @@ static int bcm2835_i2c_xfer_msg(struct bcm2835_i2c_dev *i2c_dev, (msg->flags & I2C_M_IGNORE_NAK)) return 0; - dev_err(i2c_dev->dev, "i2c transfer failed: %x\n", i2c_dev->msg_err); + dev_dbg(i2c_dev->dev, "i2c transfer failed: %x\n", i2c_dev->msg_err); if (i2c_dev->msg_err & BCM2835_I2C_S_ERR) return -EREMOTEIO;
Writing to an AT24C32 generates on average 2x i2c transfer errors per 32-byte page write. Which amounts to a lot for a 4k write. This is due to the fact that the chip doesn't respond during it's internal write cycle when the at24 driver tries and retries the next write. Only a handful drivers use dev_err() on transfer error, so switch to dev_dbg() instead. Signed-off-by: Noralf Trønnes <noralf@tronnes.org> --- Changes: - use dev_dbg instead of dev_err_ratelimited drivers/i2c/busses/i2c-bcm2835.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.8.2