| Message ID | 1409953475-23130-1-git-send-email-f.fainelli@gmail.com |
|---|---|
| State | New |
| Headers | show |
On Friday 05 September 2014 14:44:35 Florian Fainelli wrote: > Arnd, Olof, > > This pull request contains the basic Broadcom BCM63138 DSL SoC support > that has been posted a few weeks ago. Arnd has reviewed those changes, and > I was expecting Matt to carry these changes for me, but I did not get an > answer so far and I don't want these patches to be held much longer. You still need to take him on Cc at least. It's bad if Matt doesn't reply to your emails, but that's no excuse to send a pull request without giving him a chance to Ack or Nack it. Did you try contacting him on IRC? According to my logs, he was on #armlinux at the time you sent the pull request, although he's marked as idle now. Let's give Matt and Christian a few more days to reply, we can take the pull request if there is no reaction. Arnd
On 09/06/14 07:33, Arnd Bergmann wrote: > On Friday 05 September 2014 14:44:35 Florian Fainelli wrote: >> Arnd, Olof, >> >> This pull request contains the basic Broadcom BCM63138 DSL SoC support >> that has been posted a few weeks ago. Arnd has reviewed those changes, and >> I was expecting Matt to carry these changes for me, but I did not get an >> answer so far and I don't want these patches to be held much longer. > > You still need to take him on Cc at least. It's bad if Matt doesn't reply > to your emails, but that's no excuse to send a pull request without giving > him a chance to Ack or Nack it. > > Did you try contacting him on IRC? According to my logs, he was on #armlinux > at the time you sent the pull request, although he's marked as idle now. I have, but did not get an answer so far. > > Let's give Matt and Christian a few more days to reply, we can take the > pull request if there is no reaction. Works for me. We might want to come up with a different strategy for handling mach-bcm stuff in the future, the BCM_MOBILE code will most likely not be the highest activity. Thanks -- Florian
On Sat, Sep 6, 2014 at 7:33 AM, Arnd Bergmann <arnd@arndb.de> wrote: > On Friday 05 September 2014 14:44:35 Florian Fainelli wrote: >> Arnd, Olof, >> >> This pull request contains the basic Broadcom BCM63138 DSL SoC support >> that has been posted a few weeks ago. Arnd has reviewed those changes, and >> I was expecting Matt to carry these changes for me, but I did not get an >> answer so far and I don't want these patches to be held much longer. > Hi Florian, Apologies for the untimeliness of replies, I've been leaning heavily on Matt to lead mach-bcm maintainership but given recent changes at Broadcom he's found himself pressed for time to do this also. I'm looking at this patchset to pull it, but I don't see any acks on the patches (the git commits in your repo do not have them, and searching through linux-arm-kernel doesn't seem to indicate acks/sign-offs for them). Have they been reviewed ? If not, I'll have to review them prior to pulling. Thanks, csd
On 09/14/14 21:56, Christian Daudt wrote: > On Sat, Sep 6, 2014 at 7:33 AM, Arnd Bergmann <arnd@arndb.de> wrote: >> On Friday 05 September 2014 14:44:35 Florian Fainelli wrote: >>> Arnd, Olof, >>> >>> This pull request contains the basic Broadcom BCM63138 DSL SoC support >>> that has been posted a few weeks ago. Arnd has reviewed those changes, and >>> I was expecting Matt to carry these changes for me, but I did not get an >>> answer so far and I don't want these patches to be held much longer. >> > Hi Florian, > Apologies for the untimeliness of replies, I've been leaning heavily > on Matt to lead mach-bcm maintainership but given recent changes at > Broadcom he's found himself pressed for time to do this also. Based on our earlier conversations on IRC this week, I was expecting you to send an update to the MAINTAINERS file reflecting the fact that we (Brian, Gregory, Marc and myself) should be listed as mach-bcm maintainers as well. > I'm looking at this patchset to pull it, but I don't see any acks on > the patches (the git commits in your repo do not have them, and > searching through linux-arm-kernel doesn't seem to indicate > acks/sign-offs for them). Have they been reviewed ? If not, I'll have > to review them prior to pulling. Arnd has reviewed v2, and v3 addresses his former comments, he has not replied with an Ack though I do not mind waiting for this. Thank you -- Florian
On Sun, Sep 14, 2014 at 10:16 PM, Florian Fainelli <f.fainelli@gmail.com> wrote: > On 09/14/14 21:56, Christian Daudt wrote: >> >> On Sat, Sep 6, 2014 at 7:33 AM, Arnd Bergmann <arnd@arndb.de> wrote: >>> >>> On Friday 05 September 2014 14:44:35 Florian Fainelli wrote: >>>> >>>> Arnd, Olof, >>>> >>>> This pull request contains the basic Broadcom BCM63138 DSL SoC support >>>> that has been posted a few weeks ago. Arnd has reviewed those changes, >>>> and >>>> I was expecting Matt to carry these changes for me, but I did not get an >>>> answer so far and I don't want these patches to be held much longer. >>> >>> >> Hi Florian, >> Apologies for the untimeliness of replies, I've been leaning heavily >> on Matt to lead mach-bcm maintainership but given recent changes at >> Broadcom he's found himself pressed for time to do this also. > > > Based on our earlier conversations on IRC this week, I was expecting you to > send an update to the MAINTAINERS file reflecting the fact that we (Brian, > Gregory, Marc and myself) should be listed as mach-bcm maintainers as well. > Yes, I do plan update the MAINTAINERS to include you. I don't see a need to include 4 more people at this point. That patch is coming. >> I'm looking at this patchset to pull it, but I don't see any acks on >> the patches (the git commits in your repo do not have them, and >> searching through linux-arm-kernel doesn't seem to indicate >> acks/sign-offs for them). Have they been reviewed ? If not, I'll have >> to review them prior to pulling. > > > Arnd has reviewed v2, and v3 addresses his former comments, he has not > replied with an Ack though I do not mind waiting for this. Ok - explicit is better than implicit. Arnd - can you pls confirm your ack to these patches ? Thanks, csd
On Monday 15 September 2014, Christian Daudt wrote: > > > > > > Arnd has reviewed v2, and v3 addresses his former comments, he has not > > replied with an Ack though I do not mind waiting for this. > > Ok - explicit is better than implicit. Arnd - can you pls confirm your > ack to these patches ? I'm glad you asked, because it triggered me to look at the pull request. The patches are all good, feel free to add Acked-by: Arnd Bergmann <arnd@arndb.de> to each patch, or to the merge, whichever works for you. However, the pull request was done wrong, so don't merge this changeset into your branch or we won't pull it from you. The problem is that it is based on top of out for-next branch, which is not meant to be sent upstream to Linus. Instead as you know we expect all pull requests coming in from platform maintainers to be done as topic branches and normall based on top of the previous -rc1 release, or possibly a later -rcX release if you have a strong dependency on a bug fix that went into that release. I'd recommend that Florian rebases from 244a68e90d0775d3e579 to v3.17-rc1 and send a new pull request, but it's also fine if you do the rebase and add your Signed-off-by to the patches in the process. Arnd
On 09/16/2014 09:27 AM, Arnd Bergmann wrote: > On Monday 15 September 2014, Christian Daudt wrote: >>> >>> >>> Arnd has reviewed v2, and v3 addresses his former comments, he has not >>> replied with an Ack though I do not mind waiting for this. >> >> Ok - explicit is better than implicit. Arnd - can you pls confirm your >> ack to these patches ? > > I'm glad you asked, because it triggered me to look at the pull request. > The patches are all good, feel free to add > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > to each patch, or to the merge, whichever works for you. > > However, the pull request was done wrong, so don't merge this changeset > into your branch or we won't pull it from you. > > The problem is that it is based on top of out for-next branch, which is > not meant to be sent upstream to Linus. Instead as you know we expect > all pull requests coming in from platform maintainers to be done as > topic branches and normall based on top of the previous -rc1 release, > or possibly a later -rcX release if you have a strong dependency on > a bug fix that went into that release. > > I'd recommend that Florian rebases from 244a68e90d0775d3e579 to > v3.17-rc1 and send a new pull request, but it's also fine if you > do the rebase and add your Signed-off-by to the patches in the process. I will do this and create a tag for Christian to pull from. Thanks! -- Florian
Arnd, Olof, This pull request contains the basic Broadcom BCM63138 DSL SoC support that has been posted a few weeks ago. Arnd has reviewed those changes, and I was expecting Matt to carry these changes for me, but I did not get an answer so far and I don't want these patches to be held much longer. Thanks! The following changes since commit 244a68e90d0775d3e579020768ef3d5409473adc: Merge fixes branch into for-next (2014-09-05 22:56:46 +0200) are available in the git repository at: https://github.com/brcm/linux.git bcm63138-v3 for you to fetch changes up to ad672f6d6aaf748488ee6a759c23d4f8528f1b6c: MAINTAINERS: add entry for the Broadcom BCM63xx ARM SoCs (2014-09-05 14:30:56 -0700) ---------------------------------------------------------------- Florian Fainelli (5): ARM: BCM63XX: add basic support for the Broadcom BCM63138 DSL SoC ARM: BCM63XX: add low-level UART debug support ARM: BCM63XX: add BCM63138 minimal Device Tree ARM: BCM63XX: add BCM963138DVT Reference platform DTS MAINTAINERS: add entry for the Broadcom BCM63xx ARM SoCs .../devicetree/bindings/arm/bcm/bcm63138.txt | 9 ++ MAINTAINERS | 8 ++ arch/arm/Kconfig.debug | 18 ++- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/bcm63138.dtsi | 134 +++++++++++++++++++++ arch/arm/boot/dts/bcm963138dvt.dts | 30 +++++ arch/arm/include/debug/bcm63xx.S | 33 +++++ arch/arm/mach-bcm/Kconfig | 17 +++ arch/arm/mach-bcm/Makefile | 3 + arch/arm/mach-bcm/bcm63xx.c | 27 +++++ 10 files changed, 278 insertions(+), 2 deletions(-) create mode 100644 Documentation/devicetree/bindings/arm/bcm/bcm63138.txt create mode 100644 arch/arm/boot/dts/bcm63138.dtsi create mode 100644 arch/arm/boot/dts/bcm963138dvt.dts create mode 100644 arch/arm/include/debug/bcm63xx.S create mode 100644 arch/arm/mach-bcm/bcm63xx.c