| Message ID | 1361968035-18644-1-git-send-email-mkl@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
On 02/27/2013 01:27 PM, Marc Kleine-Budde wrote: > From: Sascha Hauer <s.hauer@pengutronix.de> > > Most of otg/otg.c is not otg specific, but phy specific, so move it > to the phy directory. > > Cc: Felipe Balbi <balbi@ti.com> > Reported-by: Kishon Vijay Abraham I <kishon@ti.com> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> Felipe, can you please review this patch and give us your Acked-by? regards, Marc
On Wed, Feb 27, 2013 at 01:29:40PM +0100, Marc Kleine-Budde wrote: > On 02/27/2013 01:27 PM, Marc Kleine-Budde wrote: > > From: Sascha Hauer <s.hauer@pengutronix.de> > > > > Most of otg/otg.c is not otg specific, but phy specific, so move it > > to the phy directory. > > > > Cc: Felipe Balbi <balbi@ti.com> > > Reported-by: Kishon Vijay Abraham I <kishon@ti.com> > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> > > Felipe, can you please review this patch and give us your Acked-by? I will take it through my tree
On 02/27/2013 01:27 PM, Marc Kleine-Budde wrote: > From: Michael Grzeschik <m.grzeschik@pengutronix.de> > > This adds two little devicetree helper functions for determining the dr_mode > (host, peripheral, otg, dual-role) and phy_type (utmi, ulpi,...) from the > devicetree. > > Cc: Felipe Balbi <balbi@ti.com> > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> Felipe, same here. Your Acked-by is appreciated. Marc
On Wed, Feb 27, 2013 at 01:27:07PM +0100, Marc Kleine-Budde wrote: > In patch "5d3c28b usb: otg: add device tree support to otg library" > devm_usb_get_phy_by_phandle() was added. It uses try_module_get() to lock the > phy driver in memory. The corresponding module_put() is missing in that patch. > > This patch adds try_module_get() to usb_get_phy() and usb_get_phy_dev(). > Further the missing module_put() is added to usb_put_phy(). > > Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com> > Acked-by: Felipe Balbi <balbi@ti.com> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> this one doesn't apply to my tree. What did you use as a base ?
On Wed, Feb 27, 2013 at 01:27:09PM +0100, Marc Kleine-Budde wrote: > From: Michael Grzeschik <m.grzeschik@pengutronix.de> > > This adds two little devicetree helper functions for determining the dr_mode it looks to me that "mode" is enough. s/dr_mode/mode/
On Wed, Feb 27, 2013 at 01:31:02PM +0100, Marc Kleine-Budde wrote: > On 02/27/2013 01:27 PM, Marc Kleine-Budde wrote: > > From: Michael Grzeschik <m.grzeschik@pengutronix.de> > > > > This adds two little devicetree helper functions for determining the dr_mode > > (host, peripheral, otg, dual-role) and phy_type (utmi, ulpi,...) from the > > devicetree. > > > > Cc: Felipe Balbi <balbi@ti.com> > > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> > > Felipe, same here. Your Acked-by is appreciated. likewise, I'll take it through my tree
On 02/27/2013 01:32 PM, Felipe Balbi wrote: > On Wed, Feb 27, 2013 at 01:27:09PM +0100, Marc Kleine-Budde wrote: >> From: Michael Grzeschik <m.grzeschik@pengutronix.de> >> >> This adds two little devicetree helper functions for determining the dr_mode > > it looks to me that "mode" is enough. s/dr_mode/mode/ There already is that DT binding, we just created a helper function for that. git grep -e dr_mode\ *: linus/master Documentation/ linus/master:Documentation/devicetree/bindings/usb/fsl-usb.txt: - dr_mode : indicates the working mode for "fsl-usb2-dr" compatible linus/master:Documentation/devicetree/bindings/usb/nvidia,tegra20-ehci.txt: - dr_mode : dual role mode. Indicates the working mode for Marc
On 02/27/2013 01:31 PM, Felipe Balbi wrote: > On Wed, Feb 27, 2013 at 01:27:07PM +0100, Marc Kleine-Budde wrote: >> In patch "5d3c28b usb: otg: add device tree support to otg library" >> devm_usb_get_phy_by_phandle() was added. It uses try_module_get() to lock the >> phy driver in memory. The corresponding module_put() is missing in that patch. >> >> This patch adds try_module_get() to usb_get_phy() and usb_get_phy_dev(). >> Further the missing module_put() is added to usb_put_phy(). >> >> Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com> >> Acked-by: Felipe Balbi <balbi@ti.com> >> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> >> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> > > this one doesn't apply to my tree. What did you use as a base ? As stated in the cover letter: Greg's usb-next. git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git I'd really appreciate if this series goes into a single tree. So that other chipidea developers can base their work on this. Marc
On Wed, Feb 27, 2013 at 01:38:41PM +0100, Marc Kleine-Budde wrote: > On 02/27/2013 01:32 PM, Felipe Balbi wrote: > > On Wed, Feb 27, 2013 at 01:27:09PM +0100, Marc Kleine-Budde wrote: > >> From: Michael Grzeschik <m.grzeschik@pengutronix.de> > >> > >> This adds two little devicetree helper functions for determining the dr_mode > > > > it looks to me that "mode" is enough. s/dr_mode/mode/ > > There already is that DT binding, we just created a helper function for > that. > > git grep -e dr_mode\ *: linus/master Documentation/ > linus/master:Documentation/devicetree/bindings/usb/fsl-usb.txt: - dr_mode : indicates the working mode for "fsl-usb2-dr" compatible > linus/master:Documentation/devicetree/bindings/usb/nvidia,tegra20-ehci.txt: - dr_mode : dual role mode. Indicates the working mode for fair enough, then there's nothing we can do :-p I'll take it soonish.
Hi, On Wed, Feb 27, 2013 at 01:40:51PM +0100, Marc Kleine-Budde wrote: > On 02/27/2013 01:31 PM, Felipe Balbi wrote: > > On Wed, Feb 27, 2013 at 01:27:07PM +0100, Marc Kleine-Budde wrote: > >> In patch "5d3c28b usb: otg: add device tree support to otg library" > >> devm_usb_get_phy_by_phandle() was added. It uses try_module_get() to lock the > >> phy driver in memory. The corresponding module_put() is missing in that patch. > >> > >> This patch adds try_module_get() to usb_get_phy() and usb_get_phy_dev(). > >> Further the missing module_put() is added to usb_put_phy(). > >> > >> Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com> > >> Acked-by: Felipe Balbi <balbi@ti.com> > >> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> > >> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> > > > > this one doesn't apply to my tree. What did you use as a base ? > > As stated in the cover letter: Greg's usb-next. > > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > > I'd really appreciate if this series goes into a single tree. So that > other chipidea developers can base their work on this. it eventually will all go through Greg's queue, but drivers/usb/phy and drivers/usb/otg/ needs to go through my tree so we avoid conflicts later, sorry.
On 02/27/2013 01:43 PM, Felipe Balbi wrote: > Hi, > > On Wed, Feb 27, 2013 at 01:40:51PM +0100, Marc Kleine-Budde wrote: >> On 02/27/2013 01:31 PM, Felipe Balbi wrote: >>> On Wed, Feb 27, 2013 at 01:27:07PM +0100, Marc Kleine-Budde wrote: >>>> In patch "5d3c28b usb: otg: add device tree support to otg library" >>>> devm_usb_get_phy_by_phandle() was added. It uses try_module_get() to lock the >>>> phy driver in memory. The corresponding module_put() is missing in that patch. >>>> >>>> This patch adds try_module_get() to usb_get_phy() and usb_get_phy_dev(). >>>> Further the missing module_put() is added to usb_put_phy(). >>>> >>>> Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com> >>>> Acked-by: Felipe Balbi <balbi@ti.com> >>>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> >>>> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> >>> >>> this one doesn't apply to my tree. What did you use as a base ? >> >> As stated in the cover letter: Greg's usb-next. >> >> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git >> >> I'd really appreciate if this series goes into a single tree. So that >> other chipidea developers can base their work on this. > > it eventually will all go through Greg's queue, but drivers/usb/phy and > drivers/usb/otg/ needs to go through my tree so we avoid conflicts > later, sorry. Oh - this is going to be complicated. I'll rip the series into 3 parts and repost. Marc
On Wed, Feb 27, 2013 at 01:46:21PM +0100, Marc Kleine-Budde wrote: > On 02/27/2013 01:43 PM, Felipe Balbi wrote: > > Hi, > > > > On Wed, Feb 27, 2013 at 01:40:51PM +0100, Marc Kleine-Budde wrote: > >> On 02/27/2013 01:31 PM, Felipe Balbi wrote: > >>> On Wed, Feb 27, 2013 at 01:27:07PM +0100, Marc Kleine-Budde wrote: > >>>> In patch "5d3c28b usb: otg: add device tree support to otg library" > >>>> devm_usb_get_phy_by_phandle() was added. It uses try_module_get() to lock the > >>>> phy driver in memory. The corresponding module_put() is missing in that patch. > >>>> > >>>> This patch adds try_module_get() to usb_get_phy() and usb_get_phy_dev(). > >>>> Further the missing module_put() is added to usb_put_phy(). > >>>> > >>>> Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com> > >>>> Acked-by: Felipe Balbi <balbi@ti.com> > >>>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> > >>>> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> > >>> > >>> this one doesn't apply to my tree. What did you use as a base ? > >> > >> As stated in the cover letter: Greg's usb-next. > >> > >> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > >> > >> I'd really appreciate if this series goes into a single tree. So that > >> other chipidea developers can base their work on this. > > > > it eventually will all go through Greg's queue, but drivers/usb/phy and > > drivers/usb/otg/ needs to go through my tree so we avoid conflicts > > later, sorry. > > Oh - this is going to be complicated. I'll rip the series into 3 parts > and repost. let's try like this: drivers/usb/otg and drivers/usb/phy which don't create dependencies for chipidea and other patches which create dependencies. Then we can figure out how to handle the dependencies.
On 02/27/2013 01:47 PM, Felipe Balbi wrote: > On Wed, Feb 27, 2013 at 01:46:21PM +0100, Marc Kleine-Budde wrote: >> On 02/27/2013 01:43 PM, Felipe Balbi wrote: >>> Hi, >>> >>> On Wed, Feb 27, 2013 at 01:40:51PM +0100, Marc Kleine-Budde wrote: >>>> On 02/27/2013 01:31 PM, Felipe Balbi wrote: >>>>> On Wed, Feb 27, 2013 at 01:27:07PM +0100, Marc Kleine-Budde wrote: >>>>>> In patch "5d3c28b usb: otg: add device tree support to otg library" >>>>>> devm_usb_get_phy_by_phandle() was added. It uses try_module_get() to lock the >>>>>> phy driver in memory. The corresponding module_put() is missing in that patch. >>>>>> >>>>>> This patch adds try_module_get() to usb_get_phy() and usb_get_phy_dev(). >>>>>> Further the missing module_put() is added to usb_put_phy(). >>>>>> >>>>>> Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com> >>>>>> Acked-by: Felipe Balbi <balbi@ti.com> >>>>>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> >>>>>> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> >>>>> >>>>> this one doesn't apply to my tree. What did you use as a base ? >>>> >>>> As stated in the cover letter: Greg's usb-next. >>>> >>>> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git >>>> >>>> I'd really appreciate if this series goes into a single tree. So that >>>> other chipidea developers can base their work on this. >>> >>> it eventually will all go through Greg's queue, but drivers/usb/phy and >>> drivers/usb/otg/ needs to go through my tree so we avoid conflicts >>> later, sorry. >> >> Oh - this is going to be complicated. I'll rip the series into 3 parts >> and repost. > > let's try like this: > > drivers/usb/otg and drivers/usb/phy which don't create dependencies for > chipidea and other patches which create dependencies. > > Then we can figure out how to handle the dependencies. > That'll be these 3 branches then: otg-for-v3.9 (bugfix for v3.9): 6bef020 USB otg: use try_module_get in all usb_get_phy functions and add missing module_put otg-for-v3.10 (depends on otg-for-v3.9): a0e17f5 USB: move bulk of otg/otg.c to phy/phy.c a6fc0d1 USB: add devicetree helpers for determining dr_mode and phy_type 8a4c9f8 USB mxs-phy: Register phy with framework chipidea-for-v3.10 (most patches depend on otg-for-v3.10): 15c930e USB chipidea: ci13xxx-imx: create dynamic platformdata 9466e85 USB chipidea: add PTW and PTS handling ad2cc0d USB chipidea: introduce dual role mode pdata flags 8e7f1bb USB chipidea i.MX: introduce dr_mode property 5d83722 USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy Marc
Hi, On Wed, Feb 27, 2013 at 01:55:35PM +0100, Marc Kleine-Budde wrote: > On 02/27/2013 01:47 PM, Felipe Balbi wrote: > > On Wed, Feb 27, 2013 at 01:46:21PM +0100, Marc Kleine-Budde wrote: > >> On 02/27/2013 01:43 PM, Felipe Balbi wrote: > >>> Hi, > >>> > >>> On Wed, Feb 27, 2013 at 01:40:51PM +0100, Marc Kleine-Budde wrote: > >>>> On 02/27/2013 01:31 PM, Felipe Balbi wrote: > >>>>> On Wed, Feb 27, 2013 at 01:27:07PM +0100, Marc Kleine-Budde wrote: > >>>>>> In patch "5d3c28b usb: otg: add device tree support to otg library" > >>>>>> devm_usb_get_phy_by_phandle() was added. It uses try_module_get() to lock the > >>>>>> phy driver in memory. The corresponding module_put() is missing in that patch. > >>>>>> > >>>>>> This patch adds try_module_get() to usb_get_phy() and usb_get_phy_dev(). > >>>>>> Further the missing module_put() is added to usb_put_phy(). > >>>>>> > >>>>>> Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com> > >>>>>> Acked-by: Felipe Balbi <balbi@ti.com> > >>>>>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> > >>>>>> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> > >>>>> > >>>>> this one doesn't apply to my tree. What did you use as a base ? > >>>> > >>>> As stated in the cover letter: Greg's usb-next. > >>>> > >>>> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > >>>> > >>>> I'd really appreciate if this series goes into a single tree. So that > >>>> other chipidea developers can base their work on this. > >>> > >>> it eventually will all go through Greg's queue, but drivers/usb/phy and > >>> drivers/usb/otg/ needs to go through my tree so we avoid conflicts > >>> later, sorry. > >> > >> Oh - this is going to be complicated. I'll rip the series into 3 parts > >> and repost. > > > > let's try like this: > > > > drivers/usb/otg and drivers/usb/phy which don't create dependencies for > > chipidea and other patches which create dependencies. > > > > Then we can figure out how to handle the dependencies. > > > > That'll be these 3 branches then: > > otg-for-v3.9 (bugfix for v3.9): > 6bef020 USB otg: use try_module_get in all usb_get_phy functions and add missing module_put > > otg-for-v3.10 (depends on otg-for-v3.9): > a0e17f5 USB: move bulk of otg/otg.c to phy/phy.c > a6fc0d1 USB: add devicetree helpers for determining dr_mode and phy_type > 8a4c9f8 USB mxs-phy: Register phy with framework > > chipidea-for-v3.10 (most patches depend on otg-for-v3.10): > 15c930e USB chipidea: ci13xxx-imx: create dynamic platformdata > 9466e85 USB chipidea: add PTW and PTS handling > ad2cc0d USB chipidea: introduce dual role mode pdata flags > 8e7f1bb USB chipidea i.MX: introduce dr_mode property > 5d83722 USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy sounds good to me, please make sure to always split your series like this. You can't expect me (or any maintainer for that matter) to pick patches to proper branches based on your commit logs alone. remeber that every single maintainer needs to handle hundreds of emails a week (if not a day) and if patches are properly split and cleanly mention if it's a bugfix or not, things will go wrong.
On 02/27/2013 02:42 PM, Felipe Balbi wrote: >> That'll be these 3 branches then: >> >> otg-for-v3.9 (bugfix for v3.9): >> 6bef020 USB otg: use try_module_get in all usb_get_phy functions and add missing module_put >> >> otg-for-v3.10 (depends on otg-for-v3.9): >> a0e17f5 USB: move bulk of otg/otg.c to phy/phy.c >> a6fc0d1 USB: add devicetree helpers for determining dr_mode and phy_type >> 8a4c9f8 USB mxs-phy: Register phy with framework >> >> chipidea-for-v3.10 (most patches depend on otg-for-v3.10): >> 15c930e USB chipidea: ci13xxx-imx: create dynamic platformdata >> 9466e85 USB chipidea: add PTW and PTS handling >> ad2cc0d USB chipidea: introduce dual role mode pdata flags >> 8e7f1bb USB chipidea i.MX: introduce dr_mode property >> 5d83722 USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy > > sounds good to me, please make sure to always split your series like > this. You can't expect me (or any maintainer for that matter) to pick > patches to proper branches based on your commit logs alone. > > remeber that every single maintainer needs to handle hundreds of emails > a week (if not a day) and if patches are properly split and cleanly > mention if it's a bugfix or not, things will go wrong. That was just a proposal. You'll find these series in your inbox in a few minutes. Marc
On 02/27/2013 02:55 PM, Marc Kleine-Budde wrote: > On 02/27/2013 02:42 PM, Felipe Balbi wrote: >>> That'll be these 3 branches then: >>> >>> otg-for-v3.9 (bugfix for v3.9): >>> 6bef020 USB otg: use try_module_get in all usb_get_phy functions and add missing module_put >>> >>> otg-for-v3.10 (depends on otg-for-v3.9): >>> a0e17f5 USB: move bulk of otg/otg.c to phy/phy.c >>> a6fc0d1 USB: add devicetree helpers for determining dr_mode and phy_type >>> 8a4c9f8 USB mxs-phy: Register phy with framework >>> >>> chipidea-for-v3.10 (most patches depend on otg-for-v3.10): >>> 15c930e USB chipidea: ci13xxx-imx: create dynamic platformdata >>> 9466e85 USB chipidea: add PTW and PTS handling >>> ad2cc0d USB chipidea: introduce dual role mode pdata flags >>> 8e7f1bb USB chipidea i.MX: introduce dr_mode property >>> 5d83722 USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy >> >> sounds good to me, please make sure to always split your series like >> this. You can't expect me (or any maintainer for that matter) to pick >> patches to proper branches based on your commit logs alone. >> >> remeber that every single maintainer needs to handle hundreds of emails >> a week (if not a day) and if patches are properly split and cleanly >> mention if it's a bugfix or not, things will go wrong. > > That was just a proposal. You'll find these series in your inbox in a > few minutes. Done. regards, Marc
Hello, this is the 5th round of Sascha's patch series, rebased to Greg's usb-next. Please consider to apply. regards, Marc changes since v4: - add support for USB_DR_MODE_DUAL_ROLE in dt helper changes since v3: - add phy patches (which were accidently already part of v2) - Use OP_DEVLC instead of OP_PORTSC for lpm case - Use enum usb_dr_mode ub ci_hdrc_probe() changes since v2: - fix adding of GPL Header was in wrong patch - add missing hunk for new file of.c changes since v1: - move phy specific of helper to drivers/usb/phy/of.c - use strcmp instead of strcasecmp for matching property values - change usb_phy_dr_mode to usb_dr_mode - change USBPHY_INTERFACE_MODE_NA to USBPHY_INTERFACE_MODE_UNKNOWN - add copyright header to new files - chipidea: drop mdelay at end of PTS/PTW setup - chipidea: implement lpm core type handling for PTS/PTW The following changes since commit 74e1a2a39355b2d3ae8c60c78d8add162c6d7183: Merge tag 'usb-3.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb (2013-02-21 12:20:00 -0800) are available in the git repository at: git://git.pengutronix.de/git/mkl/linux.git tags/usb-chipidea-for-next-v5 for you to fetch changes up to 1065bb064c06565cc0b86337d52977ab5afc3e90: USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy (2013-02-27 12:54:13 +0100) ---------------------------------------------------------------- USB: chipidea patches for v3.10 These add OF helpers for handling the dr_mode and phy_type property and makes use of them in the chipidea driver. ---------------------------------------------------------------- Marc Kleine-Budde (1): USB otg: use try_module_get in all usb_get_phy functions and add missing module_put Michael Grzeschik (3): USB: add devicetree helpers for determining dr_mode and phy_type USB chipidea: ci13xxx-imx: create dynamic platformdata USB chipidea: add PTW and PTS handling Sascha Hauer (5): USB: move bulk of otg/otg.c to phy/phy.c USB chipidea: introduce dual role mode pdata flags USB chipidea i.MX: introduce dr_mode property USB mxs-phy: Register phy with framework USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy .../devicetree/bindings/usb/ci13xxx-imx.txt | 6 + drivers/usb/chipidea/bits.h | 14 +- drivers/usb/chipidea/ci13xxx_imx.c | 67 +-- drivers/usb/chipidea/core.c | 61 ++- drivers/usb/otg/mxs-phy.c | 9 + drivers/usb/otg/otg.c | 423 ------------------- drivers/usb/phy/Makefile | 2 + drivers/usb/phy/of.c | 47 +++ drivers/usb/phy/phy.c | 438 ++++++++++++++++++++ drivers/usb/usb-common.c | 37 ++ include/linux/usb/chipidea.h | 3 +- include/linux/usb/of.h | 27 ++ include/linux/usb/otg.h | 8 + include/linux/usb/phy.h | 9 + 14 files changed, 689 insertions(+), 462 deletions(-) create mode 100644 drivers/usb/phy/of.c create mode 100644 drivers/usb/phy/phy.c create mode 100644 include/linux/usb/of.h