Message ID | 1341490136-25901-1-git-send-email-santosh.shilimkar@ti.com |
---|---|
State | New |
Headers | show |
On Thu, Jul 5, 2012 at 5:38 PM, Santosh Shilimkar <santosh.shilimkar@ti.com> wrote: > Tony, > > The series adds minimal OMAP5 support. OMAP5430 has a dual core Cortex-A15 > based MPU subsystem with 2MB L2 cache. The SOC has many compatible blocks > with OMAP4 SOCS and hence large part of the peripherals are re-used. > > OMAP5432 is another variant of OMAP5430, with a memory controller supporting > DDR3 and SATA. > > Series is generated against cleanup-part2 branch at commit 74dd9ec6. > 4 patches are repeated with [PATCH x/5] while posting. Just ignore them. Regards santosh
Hi, * Santosh Shilimkar <santosh.shilimkar@ti.com> [120705 05:13]: > From: R Sricharan <r.sricharan@ti.com> > > Adding the OMAP5 ES1.0, 2.0 and OMAP5432 cpu revision > detection support. > > --- a/arch/arm/mach-omap2/id.c > +++ b/arch/arm/mach-omap2/id.c > @@ -50,6 +50,11 @@ int omap_type(void) > val = omap_ctrl_readl(OMAP343X_CONTROL_STATUS); > } else if (cpu_is_omap44xx()) { > val = omap_ctrl_readl(OMAP4_CTRL_MODULE_CORE_STATUS); > + } else if (cpu_is_omap54xx()) { > + val = omap_ctrl_readl(OMAP5XXX_CONTROL_STATUS); > + val &= OMAP5_DEVICETYPE_MASK; > + val >>= 6; > + goto out; > } else { > pr_err("Cannot detect omap type!\n"); > goto out; > @@ -100,7 +105,7 @@ static u16 tap_prod_id; > > void omap_get_die_id(struct omap_die_id *odi) > { > - if (cpu_is_omap44xx()) { > + if (cpu_is_omap44xx() || cpu_is_omap54xx()) { Please update all these patches to use soc_is_omap54xx() instead of cpu_is_omap54xx() as that's where we are heading. Regards, Tony
On Thu, Jul 5, 2012 at 7:56 PM, Tony Lindgren <tony@atomide.com> wrote: > Hi, > > * Santosh Shilimkar <santosh.shilimkar@ti.com> [120705 05:13]: >> From: R Sricharan <r.sricharan@ti.com> >> >> Adding the OMAP5 ES1.0, 2.0 and OMAP5432 cpu revision >> detection support. >> >> --- a/arch/arm/mach-omap2/id.c >> +++ b/arch/arm/mach-omap2/id.c >> @@ -50,6 +50,11 @@ int omap_type(void) >> val = omap_ctrl_readl(OMAP343X_CONTROL_STATUS); >> } else if (cpu_is_omap44xx()) { >> val = omap_ctrl_readl(OMAP4_CTRL_MODULE_CORE_STATUS); >> + } else if (cpu_is_omap54xx()) { >> + val = omap_ctrl_readl(OMAP5XXX_CONTROL_STATUS); >> + val &= OMAP5_DEVICETYPE_MASK; >> + val >>= 6; >> + goto out; >> } else { >> pr_err("Cannot detect omap type!\n"); >> goto out; >> @@ -100,7 +105,7 @@ static u16 tap_prod_id; >> >> void omap_get_die_id(struct omap_die_id *odi) >> { >> - if (cpu_is_omap44xx()) { >> + if (cpu_is_omap44xx() || cpu_is_omap54xx()) { > > Please update all these patches to use soc_is_omap54xx() > instead of cpu_is_omap54xx() as that's where we are heading. > Damn. We missed to update this. Will fix this and update the branch. Thanks for pointing it out. Regards santosh
* Santosh Shilimkar <santosh.shilimkar@ti.com> [120705 05:13]: > --- a/arch/arm/plat-omap/Makefile > +++ b/arch/arm/plat-omap/Makefile > @@ -10,9 +10,7 @@ obj-n := > obj- := > > # omap_device support (OMAP2+ only at the moment) > -obj-$(CONFIG_ARCH_OMAP2) += omap_device.o > -obj-$(CONFIG_ARCH_OMAP3) += omap_device.o > -obj-$(CONFIG_ARCH_OMAP4) += omap_device.o > +obj-$(CONFIG_ARCH_OMAP2PLUS) += omap_device.o > > obj-$(CONFIG_OMAP_DM_TIMER) += dmtimer.o > obj-$(CONFIG_OMAP_DEBUG_DEVICES) += debug-devices.o FYI, this we already have as commit b4cb410d in devel-am33xx-part2. I can merge first few patches in devel-am33xx-part2 branch into cleanup-part2 so this part can be just left out. Regards, Tony
On Thu, Jul 5, 2012 at 8:03 PM, Tony Lindgren <tony@atomide.com> wrote: > * Santosh Shilimkar <santosh.shilimkar@ti.com> [120705 05:13]: >> --- a/arch/arm/plat-omap/Makefile >> +++ b/arch/arm/plat-omap/Makefile >> @@ -10,9 +10,7 @@ obj-n := >> obj- := >> >> # omap_device support (OMAP2+ only at the moment) >> -obj-$(CONFIG_ARCH_OMAP2) += omap_device.o >> -obj-$(CONFIG_ARCH_OMAP3) += omap_device.o >> -obj-$(CONFIG_ARCH_OMAP4) += omap_device.o >> +obj-$(CONFIG_ARCH_OMAP2PLUS) += omap_device.o >> >> obj-$(CONFIG_OMAP_DM_TIMER) += dmtimer.o >> obj-$(CONFIG_OMAP_DEBUG_DEVICES) += debug-devices.o > > FYI, this we already have as commit b4cb410d in devel-am33xx-part2. > I can merge first few patches in devel-am33xx-part2 branch into > cleanup-part2 so this part can be just left out. > Ok. Once you update the branch this can be easily dropped. regards santosh
* Shilimkar, Santosh <santosh.shilimkar@ti.com> [120705 07:41]: > On Thu, Jul 5, 2012 at 8:03 PM, Tony Lindgren <tony@atomide.com> wrote: > > * Santosh Shilimkar <santosh.shilimkar@ti.com> [120705 05:13]: > >> --- a/arch/arm/plat-omap/Makefile > >> +++ b/arch/arm/plat-omap/Makefile > >> @@ -10,9 +10,7 @@ obj-n := > >> obj- := > >> > >> # omap_device support (OMAP2+ only at the moment) > >> -obj-$(CONFIG_ARCH_OMAP2) += omap_device.o > >> -obj-$(CONFIG_ARCH_OMAP3) += omap_device.o > >> -obj-$(CONFIG_ARCH_OMAP4) += omap_device.o > >> +obj-$(CONFIG_ARCH_OMAP2PLUS) += omap_device.o > >> > >> obj-$(CONFIG_OMAP_DM_TIMER) += dmtimer.o > >> obj-$(CONFIG_OMAP_DEBUG_DEVICES) += debug-devices.o > > > > FYI, this we already have as commit b4cb410d in devel-am33xx-part2. > > I can merge first few patches in devel-am33xx-part2 branch into > > cleanup-part2 so this part can be just left out. > > > Ok. Once you update the branch this can be easily dropped. Updated cleanup-part2 at commit ecc46cfd now has it. Regards, Tony