| Message ID | 1307891100-31123-4-git-send-email-ynezz@true.cz |
|---|---|
| State | New |
| Headers | show |
On Sunday, June 12, 2011 8:05 AM, Petr Štetiar wrote: > > I've got hands on one ts-7300 board, which is equiped with 128MB RAM in two > 64MB memory chips, so it's 16 banks/8MB each. Without this patch, the bootmem > init code complains about small NR_BANKS number and only lower 64MB is > accessible. > > Cc: Russell King <linux@arm.linux.org.uk> > Cc: Hartley Sweeten <hsweeten@visionengravers.com> > Cc: Ryan Mallon <ryan@bluewatersys.com> > Signed-off-by: Petr Štetiar <ynezz@true.cz> > --- > arch/arm/include/asm/setup.h | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/include/asm/setup.h b/arch/arm/include/asm/setup.h > index ee2ad8a..b13720d 100644 > --- a/arch/arm/include/asm/setup.h > +++ b/arch/arm/include/asm/setup.h > @@ -192,7 +192,11 @@ static struct tagtable __tagtable_##fn __tag = { tag, fn } > /* > * Memory map description > */ > -#define NR_BANKS 8 > +#ifdef CONFIG_ARCH_EP93XX > +# define NR_BANKS 16 > +#else > +# define NR_BANKS 8 > +#endif > > struct membank { > phys_addr_t start; I would like Russell's opinion on this patch before it's accepted into his Patch Tracker. But, as far as the ep93xx support goes... Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>
H Hartley Sweeten <hartleys@visionengravers.com> [2011-06-13 12:43:25]: > On Sunday, June 12, 2011 8:05 AM, Petr Štetiar wrote: > > > > I've got hands on one ts-7300 board, which is equiped with 128MB RAM in two > > 64MB memory chips, so it's 16 banks/8MB each. Without this patch, the bootmem > > init code complains about small NR_BANKS number and only lower 64MB is > > accessible. > > > > Cc: Russell King <linux@arm.linux.org.uk> > > Cc: Hartley Sweeten <hsweeten@visionengravers.com> > > Cc: Ryan Mallon <ryan@bluewatersys.com> > > Signed-off-by: Petr Štetiar <ynezz@true.cz> > > --- > > arch/arm/include/asm/setup.h | 6 +++++- > > 1 files changed, 5 insertions(+), 1 deletions(-) > > > > diff --git a/arch/arm/include/asm/setup.h b/arch/arm/include/asm/setup.h > > index ee2ad8a..b13720d 100644 > > --- a/arch/arm/include/asm/setup.h > > +++ b/arch/arm/include/asm/setup.h > > @@ -192,7 +192,11 @@ static struct tagtable __tagtable_##fn __tag = { tag, fn } > > /* > > * Memory map description > > */ > > -#define NR_BANKS 8 > > +#ifdef CONFIG_ARCH_EP93XX > > +# define NR_BANKS 16 > > +#else > > +# define NR_BANKS 8 > > +#endif > > > > struct membank { > > phys_addr_t start; > > I would like Russell's opinion on this patch before it's accepted into his > Patch Tracker. > > But, as far as the ep93xx support goes... > > Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com> Hello Russell, could I kindly ask you about your opinnion on this patch? Thanks a lot. -- ynezz
Petr Štetiar <ynezz@true.cz> [2011-06-17 12:32:49]: > H Hartley Sweeten <hartleys@visionengravers.com> [2011-06-13 12:43:25]: > > > On Sunday, June 12, 2011 8:05 AM, Petr Štetiar wrote: > > > > > > I've got hands on one ts-7300 board, which is equiped with 128MB RAM in two > > > 64MB memory chips, so it's 16 banks/8MB each. Without this patch, the bootmem > > > init code complains about small NR_BANKS number and only lower 64MB is > > > accessible. > > > > > > Cc: Russell King <linux@arm.linux.org.uk> > > > Cc: Hartley Sweeten <hsweeten@visionengravers.com> > > > Cc: Ryan Mallon <ryan@bluewatersys.com> > > > Signed-off-by: Petr Štetiar <ynezz@true.cz> > > > --- > > > arch/arm/include/asm/setup.h | 6 +++++- > > > 1 files changed, 5 insertions(+), 1 deletions(-) > > > > > > diff --git a/arch/arm/include/asm/setup.h b/arch/arm/include/asm/setup.h > > > index ee2ad8a..b13720d 100644 > > > --- a/arch/arm/include/asm/setup.h > > > +++ b/arch/arm/include/asm/setup.h > > > @@ -192,7 +192,11 @@ static struct tagtable __tagtable_##fn __tag = { tag, fn } > > > /* > > > * Memory map description > > > */ > > > -#define NR_BANKS 8 > > > +#ifdef CONFIG_ARCH_EP93XX > > > +# define NR_BANKS 16 > > > +#else > > > +# define NR_BANKS 8 > > > +#endif > > > > > > struct membank { > > > phys_addr_t start; > > > > I would like Russell's opinion on this patch before it's accepted into his > > Patch Tracker. > > > > But, as far as the ep93xx support goes... > > > > Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com> > > Hello Russell, > > could I kindly ask you about your opinnion on this patch? Thanks a lot. Ping. Thanks a lot. -- ynezz
On Sat, Jul 09, 2011 at 10:20:08AM +0200, Petr Štetiar wrote: > Petr Štetiar <ynezz@true.cz> [2011-06-17 12:32:49]: > > > H Hartley Sweeten <hartleys@visionengravers.com> [2011-06-13 12:43:25]: > > > > > On Sunday, June 12, 2011 8:05 AM, Petr Štetiar wrote: > > > > > > > > I've got hands on one ts-7300 board, which is equiped with 128MB RAM in two > > > > 64MB memory chips, so it's 16 banks/8MB each. Without this patch, the bootmem > > > > init code complains about small NR_BANKS number and only lower 64MB is > > > > accessible. > > > > > > > > Cc: Russell King <linux@arm.linux.org.uk> > > > > Cc: Hartley Sweeten <hsweeten@visionengravers.com> > > > > Cc: Ryan Mallon <ryan@bluewatersys.com> > > > > Signed-off-by: Petr Štetiar <ynezz@true.cz> > > > > --- > > > > arch/arm/include/asm/setup.h | 6 +++++- > > > > 1 files changed, 5 insertions(+), 1 deletions(-) > > > > > > > > diff --git a/arch/arm/include/asm/setup.h b/arch/arm/include/asm/setup.h > > > > index ee2ad8a..b13720d 100644 > > > > --- a/arch/arm/include/asm/setup.h > > > > +++ b/arch/arm/include/asm/setup.h > > > > @@ -192,7 +192,11 @@ static struct tagtable __tagtable_##fn __tag = { tag, fn } > > > > /* > > > > * Memory map description > > > > */ > > > > -#define NR_BANKS 8 > > > > +#ifdef CONFIG_ARCH_EP93XX > > > > +# define NR_BANKS 16 > > > > +#else > > > > +# define NR_BANKS 8 > > > > +#endif > > > > > > > > struct membank { > > > > phys_addr_t start; > > > > > > I would like Russell's opinion on this patch before it's accepted into his > > > Patch Tracker. > > > > > > But, as far as the ep93xx support goes... > > > > > > Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com> > > > > Hello Russell, > > > > could I kindly ask you about your opinnion on this patch? Thanks a lot. > > Ping. Thanks a lot. It's fine.
diff --git a/arch/arm/include/asm/setup.h b/arch/arm/include/asm/setup.h index ee2ad8a..b13720d 100644 --- a/arch/arm/include/asm/setup.h +++ b/arch/arm/include/asm/setup.h @@ -192,7 +192,11 @@ static struct tagtable __tagtable_##fn __tag = { tag, fn } /* * Memory map description */ -#define NR_BANKS 8 +#ifdef CONFIG_ARCH_EP93XX +# define NR_BANKS 16 +#else +# define NR_BANKS 8 +#endif struct membank { phys_addr_t start;
I've got hands on one ts-7300 board, which is equiped with 128MB RAM in two 64MB memory chips, so it's 16 banks/8MB each. Without this patch, the bootmem init code complains about small NR_BANKS number and only lower 64MB is accessible. Cc: Russell King <linux@arm.linux.org.uk> Cc: Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ryan Mallon <ryan@bluewatersys.com> Signed-off-by: Petr Štetiar <ynezz@true.cz> --- arch/arm/include/asm/setup.h | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)