From patchwork Fri Apr 29 00:43:23 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 93357 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E577AB6EEE for ; Fri, 29 Apr 2011 10:43:54 +1000 (EST) Received: from canuck.infradead.org ([2001:4978:20e::1]) by bombadil.infradead.org with esmtps (Exim 4.72 #1 (Red Hat Linux)) id 1QFboG-0006ee-7G; Fri, 29 Apr 2011 00:43:52 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1QFboE-00057h-Pu; Fri, 29 Apr 2011 00:43:50 +0000 Received: from mail-yw0-f49.google.com ([209.85.213.49]) by canuck.infradead.org with esmtps (Exim 4.72 #1 (Red Hat Linux)) id 1QFbny-00056c-80 for linux-arm-kernel@lists.infradead.org; Fri, 29 Apr 2011 00:43:35 +0000 Received: by ywf9 with SMTP id 9so1354959ywf.36 for ; Thu, 28 Apr 2011 17:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references; bh=hXTN8MOeKDjE6p/ETJEtz6c1N+1uDs+QJUS26gMZpNM=; b=p4NLTK0rl3sFyZoVjr+ItAnl+puS39FqJ1i4XpLniISXXWg2TbXfB2C2L/jCMOkIg4 28TktH42kxQsXx2Fuw9B4Xf8P5p6GixqN8Vx1F9GK487qlemnEhpaP2i5GSibPSP3jJW pDbyzUiIcV79RwU2khYDGgbKpHLG6BHkK2qDI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=Cf9ayYOYD3Zrwle3uWugAQsAJX6a3mGj0mRT1SRrN3md8yURDijvQDPmPTceYiUDX1 RTpMQhTI6NBTSxUhCMNP6r45r4fdQADhB6CHTaDV2e6WAKuyiaw1Okau9WIQiuUiqNR2 RGT5nNSnndU/2ZZrdObbcRI8c5jmXo+IXlVQY= Received: by 10.236.168.8 with SMTP id j8mr5214003yhl.378.1304037813648; Thu, 28 Apr 2011 17:43:33 -0700 (PDT) Received: from localhost.localdomain ([201.82.76.9]) by mx.google.com with ESMTPS id 11sm1140255yhl.9.2011.04.28.17.43.31 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 28 Apr 2011 17:43:33 -0700 (PDT) From: Fabio Estevam To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 2/3] ARM: mx5/mx51_babbage: Use gpio_request_one when possible Date: Thu, 28 Apr 2011 21:43:23 -0300 Message-Id: <1304037804-4411-2-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.6.0.4 In-Reply-To: <1304037804-4411-1-git-send-email-festevam@gmail.com> References: <1304037804-4411-1-git-send-email-festevam@gmail.com> X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110428_204334_420767_DB59A5CD X-CRM114-Status: GOOD ( 12.39 ) X-Spam-Score: -0.8 (/) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (-0.8 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.213.49 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is freemail (festevam[at]gmail.com) -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 RFC_ABUSE_POST Both abuse and postmaster missing on sender domain 0.0 T_TO_NO_BRKTS_FREEMAIL T_TO_NO_BRKTS_FREEMAIL Cc: Fabio Estevam , Fabio Estevam , kernel@pengutronix.de X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org Instead of using gpio_request followed by gpio_direction_output use gpio_request_one. Signed-off-by: Fabio Estevam --- No changes since v1. Only added a third patch to the series arch/arm/mach-mx5/board-mx51_babbage.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-mx5/board-mx51_babbage.c b/arch/arm/mach-mx5/board-mx51_babbage.c index 7b919bc..00203fb 100644 --- a/arch/arm/mach-mx5/board-mx51_babbage.c +++ b/arch/arm/mach-mx5/board-mx51_babbage.c @@ -179,25 +179,25 @@ static int gpio_usbh1_active(void) /* Set USBH1_STP to GPIO and toggle it */ mxc_iomux_v3_setup_pad(usbh1stp_gpio); - ret = gpio_request(BABBAGE_USBH1_STP, "usbh1_stp"); + ret = gpio_request_one(BABBAGE_USBH1_STP, + GPIOF_OUT_INIT_LOW, "usbh1_stp"); if (ret) { pr_debug("failed to get MX51_PAD_USBH1_STP__GPIO_1_27: %d\n", ret); return ret; } - gpio_direction_output(BABBAGE_USBH1_STP, 0); gpio_set_value(BABBAGE_USBH1_STP, 1); msleep(100); gpio_free(BABBAGE_USBH1_STP); /* De-assert USB PHY RESETB */ - ret = gpio_request(BABBAGE_USB_PHY_RESET, "phy_reset"); + ret = gpio_request_one(BABBAGE_USB_PHY_RESET, + GPIOF_OUT_INIT_HIGH, "phy_reset"); if (ret) { pr_debug("failed to get MX51_PAD_EIM_D21__GPIO_2_5: %d\n", ret); return ret; } - gpio_direction_output(BABBAGE_USB_PHY_RESET, 1); return 0; }