From patchwork Wed Oct 26 11:49:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 1694895 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=pbGs02He; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=alistair23.me header.i=@alistair23.me header.a=rsa-sha256 header.s=fm3 header.b=wguQpGpJ; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=kKXNGot4; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4My6Yl2g9Mz20KC for ; Wed, 26 Oct 2022 22:50:03 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=WvLaQz4JXZ3wYbb72IcRQ34Zp5l8nfl0weOtZai14T4=; b=pbGs02HeDmSyJU G7t0SM3VipJbyu3YZPmHZ4Kaq5xwhO5RfQKX4XoFh7pSJyJzcfOtgbkO+cdWgmq4L66F5pYgtlSv7 UEV/e9RRwgPJfOjTOKg3gLW5TTC3EEb2Rxw6Gj0o9JKT6bULmMgN38+ZzgdZu/K8Iw6li5B+tVCUj CQMQBC+7Mgj97pDM+iwRQ2YCul4U8ISquVjPiMQZar4kHsaWIgAPSoT3ftiEehZJRCnoJuPLQk4Wn a46YVRr6YGR3eK3BODLtcqJC6ewWvAe+DOeWtMSsJVP6yvb2aOSV+Y0nDkUe3MIm3dG8u7SwA++qz jJB7y3LXIGIosGCdASrA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oneui-0094wz-GT; Wed, 26 Oct 2022 11:49:40 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oneuf-0094vm-11 for linux-arm-kernel@lists.infradead.org; Wed, 26 Oct 2022 11:49:38 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 8A17A32003CE; Wed, 26 Oct 2022 07:49:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 26 Oct 2022 07:49:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alistair23.me; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to; s=fm3; t=1666784965; x=1666871365; bh=Fs O0gPfX2wHmErfPj9SmHjSOURVfbrKHD0GjwO7ZwVk=; b=wguQpGpJB+dw8/sOY7 LLeySXpRG3RP0n5L14JU/FaYJiN3r0kUN6jw2eGYikDd93TOsJVIkoVXFEOtVE5Z uDMU4CJoBph8oPHuYLXSGFaKgDEXMq5cHExDcvYEs7WEtqE/UT+RBLqvQ7VAZ+3v CCYevACGdoWityOQsXB9PiuO31Dv7fbrBX521juoWjTrF4lQrjxbVxqcPadVthuR eeosC508IAqq5g7ocvRmy9QFYcYpateK9DaXAuyYHT4GPSw89aa/a/hP8kRmwFq4 zgbkr9K3dS7JpaTePv+ne1o9CiLR5mlVqnQ1Iij1cTjcPKpz1JLjpUUyDVCA+D1F u3Xg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1666784965; x=1666871365; bh=FsO0gPfX2wHmE rfPj9SmHjSOURVfbrKHD0GjwO7ZwVk=; b=kKXNGot4HwX9HZLQpWN2eO25Rn4Aw 8KMBK7puUOgt9RAl95V/dAzpuw4x1bYOMogRuSZPrVO7+/NB1ShRblVme+Pow0Jr b6JGyva8vSaIbqyT0gGDsj9+msQvV6+kFH5tF3CJ+vz7NVTDUkA7dkqxOLhVHY5Q saQ4DnOlrEPijwKiWMZHgFov5Pg+vVCWpBtPc6ckZanUZXjUOesG5CsUVN6k30eA 6RXQNPbUO1QHC+JQHccazuZMKvHySq1fCZPwZHPigDkL1uj8WQutwb7oesHU+LlA 2nQ1UG9mCHLuHIqon1rtL8UWGGUXRZupYN3y6tdbQPatz/+HCzsBPt2/g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtddvgdeggecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofggtgfgsehtkeertd ertdejnecuhfhrohhmpeetlhhishhtrghirhcuhfhrrghntghishcuoegrlhhishhtrghi rhesrghlihhsthgrihhrvdefrdhmvgeqnecuggftrfgrthhtvghrnhepgedtvdfffeffje ekgefggeetfffftdeuveekfedvjeevtedvueduvddvtdeigfelnecuffhomhgrihhnpehl fihnrdhnvghtpdhgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpegrlhhishhtrghirhesrghlihhsthgrihhrvdefrdhm vg X-ME-Proxy: Feedback-ID: ifd214418:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 26 Oct 2022 07:49:15 -0400 (EDT) From: Alistair Francis To: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Cc: krzysztof.kozlowski+dt@linaro.org, linus.walleij@linaro.org, robh+dt@kernel.org, dmitry.torokhov@gmail.com, shawnguo@kernel.org, rydberg@bitmath.org, alistair23@gmail.com, s.hauer@pengutronix.de, andreas@kemnade.info, Alistair Francis Subject: [PATCH v10 0/4] Add support for the Cypress cyttsp5 Date: Wed, 26 Oct 2022 21:49:04 +1000 Message-Id: <20221026114908.191472-1-alistair@alistair23.me> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221026_044937_122239_6363B4A0 X-CRM114-Status: GOOD ( 14.57 ) X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This patch series builds on top of [1] and adds support for the cyttsp5 touchscreen controller for the reMarkable 2. I first tried to add an I2C HID device. Although the cyttsp5 has some HID looking aspects it is not HID compatible. Just in trying to probe the device I found: - The HID descriptor has extra padding - [...] Content analysis details: (-0.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [64.147.123.19 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org This patch series builds on top of [1] and adds support for the cyttsp5 touchscreen controller for the reMarkable 2. I first tried to add an I2C HID device. Although the cyttsp5 has some HID looking aspects it is not HID compatible. Just in trying to probe the device I found: - The HID descriptor has extra padding - The HID descriptor sets the high bytes of the descriptor length - The HID descriptor has extra unrecognised tags - The HID reset command doesn't appear to work I don't think there is a way to use the I2C HID framework with the cyttsp5. For anyone interested you can see the work here [2]. In that branch though I can only obtain a HID descriptor, nothing else works without more core changes. So instead I rebased the series from [1]. Converted to the new yaml DTS documentation, added regulator support and fixed a x/y miscalculation bug. 1: https://lwn.net/ml/linux-kernel/20180703094309.18514-1-mylene.josserand@bootlin.com/ 2: https://github.com/alistair23/linux/commits/rM2-mainline-cyttsp5-hid v10: - Fix device tree binding errors - Add commit message about defcofig cahnges v9: - Fixup kernel robot failures v8: - Rebase and resend v7: - Fix device tree warnings v6: - Use reg for the button properties v5: - Address review comments from v4 Alistair Francis (4): Input: Add driver for Cypress Generation 5 touchscreen dt-bindings: input: Add Cypress TT21000 touchscreen controller ARM: imx_v6_v7_defconfig: Enable the cyttsp5 touchscreen ARM: dts: imx7d-remarkable2: Enable the cyttsp5 .../input/touchscreen/cypress,tt21000.yaml | 106 ++ arch/arm/boot/dts/imx7d-remarkable2.dts | 100 ++ arch/arm/configs/imx_v6_v7_defconfig | 1 + drivers/input/touchscreen/Kconfig | 16 + drivers/input/touchscreen/Makefile | 1 + drivers/input/touchscreen/cyttsp5.c | 902 ++++++++++++++++++ 6 files changed, 1126 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml create mode 100644 drivers/input/touchscreen/cyttsp5.c